[Bug 16200] New: 'Hold waiting too long' fee has a translation problem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Bug ID: 16200 Summary: 'Hold waiting too long' fee has a translation problem Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The fee entry for 'hold waiting too long' creates an accountlines entry containing untranslatable text and using an F fee type. It would be better to have use a unique fee type that can be used to show a translated entry in the GUI. CancelReserve(): manualinvoice($reserve->{'borrowernumber'}, $reserve->{'itemnumber'}, 'Hold waiting too long', 'F', $charge); Shows in the German GUI as: Mahngebühr , Hold waiting too long 130251 Medium ansehen Physik in Demonstrationsversuchen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 --- Comment #1 from Lari Taskula <larit@student.uef.fi> --- Created attachment 51571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51571&action=edit Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype Holds that have expired have been untranslatable in Patron's Fines-tab. Also, they are mixed with other type of fines with accounttype "F". This patch gives expired holds an own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize this new accounttype in order to make it translatable. To test: 1. Make a hold and let it expire 2. Go to Patron's Fines tab 3. Change Koha's language to some other than English 4. Observe that there is a "Hold waiting too long" fine described in English 5. Apply patch 6. Make another hold and let it expire 7. Update translations 8. Find "Hold waiting too long" from your .po file 9. Translate it and install translations 10. Go back to Fines tab and observe that the new expired hold is translated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 --- Comment #2 from Lari Taskula <larit@student.uef.fi> --- Created attachment 51572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51572&action=edit Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this bug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Lari! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #4 from Lari Taskula <larit@student.uef.fi> --- *** Bug 11387 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51572|0 |1 is obsolete| | --- Comment #5 from Lari Taskula <larit@student.uef.fi> --- Created attachment 51574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51574&action=edit Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this bug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51571|0 |1 is obsolete| | --- Comment #6 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 51589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51589&action=edit Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype Holds that have expired have been untranslatable in Patron's Fines-tab. Also, they are mixed with other type of fines with accounttype "F". This patch gives expired holds an own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize this new accounttype in order to make it translatable. To test: 1. Make a hold and let it expire 2. Go to Patron's Fines tab 3. Change Koha's language to some other than English 4. Observe that there is a "Hold waiting too long" fine described in English 5. Apply patch 6. Make another hold and let it expire 7. Update translations 8. Find "Hold waiting too long" from your .po file 9. Translate it and install translations 10. Go back to Fines tab and observe that the new expired hold is translated Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51574|0 |1 is obsolete| | --- Comment #7 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 51590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51590&action=edit Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this buug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |olli-antti.kivilahti@jns.fi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51589|0 |1 is obsolete| | Attachment #51590|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51605&action=edit [PASSED QA] Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this buug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |larit@student.uef.fi --- Comment #9 from Lari Taskula <larit@student.uef.fi> --- What happened to the first patch "Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype"? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, I am sorry. I missed the second patch when signing off and reattaching. Please feel free to fix - or I will do it tonight. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Lari Taskula <larit@student.uef.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51589|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51589|0 |1 is obsolete| | Attachment #51605|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51631&action=edit [PASSED QA] Bug 16200: Make 'Hold waiting too long' translatable and give it an unique accounttype Holds that have expired have been untranslatable in Patron's Fines-tab. Also, they are mixed with other type of fines with accounttype "F". This patch gives expired holds an own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize this new accounttype in order to make it translatable. To test: 1. Make a hold and let it expire 2. Go to Patron's Fines tab 3. Change Koha's language to some other than English 4. Observe that there is a "Hold waiting too long" fine described in English 5. Apply patch 6. Make another hold and let it expire 7. Update translations 8. Find "Hold waiting too long" from your .po file 9. Translate it and install translations 10. Go back to Fines tab and observe that the new expired hold is translated Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 51632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51632&action=edit [PASSED QA] Bug 16200: Convert all existing expired holds accounttype to HE Before Bug 16200 expired holds have used accounttype F which is also used by other type of fines. This patch updates all existing expired holds to new accounttype HE (Hold Expired). To test: -1. Make sure you translated the string in previous patch of this buug 1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab 2. Change Koha's language to some other than English 3. Observe that "Hold waiting too long" is still in English 4. Apply patch and run database update 5. Go back to Patron's Fines tab 6. Observe that "Hold waiting too long" is now translated Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #13 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #14 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.8 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org