[Bug 11347] New: PROG/CCSR deprecation: Remove opacsmallimage system-preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Bug ID: 11347 Summary: PROG/CCSR deprecation: Remove opacsmallimage system-preference Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: liz@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Blocks: 11346 the opacsmallimage system preference is unused in the bootstrap theme, it should be removed when the themes are removed. To replace the functionality of customizing the logo in the top corner, one would use CSS to change the background of #logo. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@jns.fi --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- BTW Adding a new css directive #logo { background:transparent url("../images/vaara-kirjastot-logo-medium.png") no-repeat scroll 0; border:0; float:left!important; margin:0; padding:0; width: 163px; height: 50px; } to overwrite the one in opac.css:1's monster oneliner will break the responsive design. This is especially true when the logo is of different size. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Olli-Antti Kivilahti from comment #1)
to overwrite the one in opac.css:1's monster oneliner will break the responsive design. This is especially true when the logo is of different size.
I recommend putting custom logos in the opacheader region if you're using the Bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29418&action=edit Bug 11347 - PROG/CCSR deprecation: Remove opacsmallimage system-preference The opacsmallimage system preference is unused in the bootstrap theme. It can be removed now that prog and ccsr are deprecated. This patch does so. To test, apply the patch and run updatedatabase. Confirm that the OPAC works properly and the preference can no longer be found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29418|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 29470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29470&action=edit [SIGNED-OFF] Bug 11347 - PROG/CCSR deprecation: Remove opacsmallimage system-preference The opacsmallimage system preference is unused in the bootstrap theme. It can be removed now that prog and ccsr are deprecated. This patch does so. To test, apply the patch and run updatedatabase. Confirm that the OPAC works properly and the preference can no longer be found. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Preference removed, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29470|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29483&action=edit [PASSED QA] Bug 11347 - PROG/CCSR deprecation: Remove opacsmallimage system-preference The opacsmallimage system preference is unused in the bootstrap theme. It can be removed now that prog and ccsr are deprecated. This patch does so. To test, apply the patch and run updatedatabase. Confirm that the OPAC works properly and the preference can no longer be found. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Preference removed, no koha-qa errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11347 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |tomascohen@gmail.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org