[Bug 36475] New: members/summary-print.pl tables cannot be column configured
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Bug ID: 36475 Summary: members/summary-print.pl tables cannot be column configured Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Have a patron with some checkouts and some holds. 2. Go to Table settings > Circulation > print_summary and mark some of the columns as hidden. 3. Go to the patron account and click Print > Print summary 4. The hidden columns still appear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I recently ran into this in 22.11 as well, but thought it was me :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I can reproduce this in master. Note that if you have anything in IntranetSlipPrinterJS or the default print-then-close JS isn't executed. The problem is that "window.print()" fires before DataTables has a chance to load and format the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #2)
I can reproduce this in master. Note that if you have anything in IntranetSlipPrinterJS or the default print-then-close JS isn't executed.
The problem is that "window.print()" fires before DataTables has a chance to load and format the table.
Excellent detective work! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 167859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167859&action=edit Bug 36475: Enable table configurations on patrons print summary This patch fixes table configuration to the tables shown on the patron's print summary page, adding default display length and default sort as well. I removed the JS for moving around the DataTable controls to make them display better and instead swapped the <caption>s for <h2>. It's not perfect but it's better than it was. Previously table configuration wasn't working because the window.print() function was firing before the DataTables code had time to run. I've added a use of onbeforeprint event to make sure we run the DataTables initiation before automatic printing. To test, apply the patch and restart services. - In the staff client, go to Administration -> Table settings -> Circulation -> print_summary. - Configure the print-summary-checkouts, print-summary-fines, and print-summary-holds tables with some custom options (e.g. hide columns, change default sort). - In the staff client, find a patron with checkouts, holds, and fines. - In the toolbar, click Print -> Print summary. A new tab should appear with the print summary view. A print dialog should appear immediately. - In the print preview you should see that the tables you configured are displayed correctly (sort is correct, columns correctly hidden, etc). - If you print the page or cancel the tab should close. - If you want to test the table configurations without having the tab automatically close you can go to Administration -> System preferences -> IntranetSlipPrinterJS and enter any dummy code, e.g. "console.log('Testing');" With that preference populated, the automatic closing isn't included. - Test other pages which use the slip-print include, e.g. other patron print options and quick spine labels in Cataloging. Sponsored-By: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Lucas <lchirlias@ville-roubaix.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lchirlias@ville-roubaix.fr Keywords| |Sandbox --- Comment #5 from Lucas <lchirlias@ville-roubaix.fr> ---
If you want to test the table configurations without having the tab automatically close you can go to Administration -> System preferences -> IntranetSlipPrinterJS and enter any dummy code, e.g. "console.log('Testing');" With that preference populated, the automatic closing isn't included.
- Test other pages which use the slip-print include, e.g. other patron
I don't know if i really need to test this. But the septs before works print options and quick spine labels in Cataloging. I didn' had the time to test that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167859|0 |1 is obsolete| | --- Comment #6 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 170196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170196&action=edit Bug 36475: Enable table configurations on patrons print summary This patch fixes table configuration to the tables shown on the patron's print summary page, adding default display length and default sort as well. I removed the JS for moving around the DataTable controls to make them display better and instead swapped the <caption>s for <h2>. It's not perfect but it's better than it was. Previously table configuration wasn't working because the window.print() function was firing before the DataTables code had time to run. I've added a use of onbeforeprint event to make sure we run the DataTables initiation before automatic printing. To test, apply the patch and restart services. - In the staff client, go to Administration -> Table settings -> Circulation -> print_summary. - Configure the print-summary-checkouts, print-summary-fines, and print-summary-holds tables with some custom options (e.g. hide columns, change default sort). - In the staff client, find a patron with checkouts, holds, and fines. - In the toolbar, click Print -> Print summary. A new tab should appear with the print summary view. A print dialog should appear immediately. - In the print preview you should see that the tables you configured are displayed correctly (sort is correct, columns correctly hidden, etc). - If you print the page or cancel the tab should close. - If you want to test the table configurations without having the tab automatically close you can go to Administration -> System preferences -> IntranetSlipPrinterJS and enter any dummy code, e.g. "console.log('Testing');" With that preference populated, the automatic closing isn't included. - Test other pages which use the slip-print include, e.g. other patron print options and quick spine labels in Cataloging. Sponsored-By: Athens County Public Libraries Signed-off-by: Thibaud Guillot <thibaud.guillot@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot@biblibre.co | |m --- Comment #7 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- *** Bug 36974 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170196|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 170535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170535&action=edit Bug 36475: Enable table configurations on patrons print summary This patch fixes table configuration to the tables shown on the patron's print summary page, adding default display length and default sort as well. I removed the JS for moving around the DataTable controls to make them display better and instead swapped the <caption>s for <h2>. It's not perfect but it's better than it was. Previously table configuration wasn't working because the window.print() function was firing before the DataTables code had time to run. I've added a use of onbeforeprint event to make sure we run the DataTables initiation before automatic printing. To test, apply the patch and restart services. - In the staff client, go to Administration -> Table settings -> Circulation -> print_summary. - Configure the print-summary-checkouts, print-summary-fines, and print-summary-holds tables with some custom options (e.g. hide columns, change default sort). - In the staff client, find a patron with checkouts, holds, and fines. - In the toolbar, click Print -> Print summary. A new tab should appear with the print summary view. A print dialog should appear immediately. - In the print preview you should see that the tables you configured are displayed correctly (sort is correct, columns correctly hidden, etc). - If you print the page or cancel the tab should close. - If you want to test the table configurations without having the tab automatically close you can go to Administration -> System preferences -> IntranetSlipPrinterJS and enter any dummy code, e.g. "console.log('Testing');" With that preference populated, the automatic closing isn't included. - Test other pages which use the slip-print include, e.g. other patron print options and quick spine labels in Cataloging. Sponsored-By: Athens County Public Libraries Signed-off-by: Thibaud Guillot <thibaud.guillot@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the fix, working well. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Sandbox | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|members/summary-print.pl |"Print summary" tables |tables cannot be column |cannot be column configured |configured | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.04 released in| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36475 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org