[Bug 38041] New: Not all self checkout errors behave the same
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 Bug ID: 38041 Summary: Not all self checkout errors behave the same Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org For example: 1. Enable SCO and go to the SCO module 2. Attempt to checkout a non-existent barcode. 3. See the error that appears, nothing else. 4. Attempt to checkout something that is already checked out. 5. The error is much the same but you still see all parts of the SCO module. This is a problem for some libraries attempting smooth user experience for SCO users. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- sco-main.pl passes a hide_main template variable when issuing is impossible. ( Determined by CanBookBeIssued ) Other problems get needsconfirm ( see CanBookBeIssued for a list ) sco-main.pl should also pass the 'hide_main' variable when the issue is needsconfirm. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172236&action=edit Bug 38041: Pass hide_main for all needsconfirm warnings in SCO To test: 1. APPLY PATCH and restart_all 2. Make sure the following errors when issuing in SCO show just the error, no other info. on screen: DEBT RENEW_ISSUE ISSUED_TO_ANOTHER RESERVED TRANSFERRED INVALID_DATE ( cant test in SCO ) TOO_MANY RECALLED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172236|0 |1 is obsolete| | --- Comment #3 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 172531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172531&action=edit Bug 38041: Pass hide_main for all needsconfirm warnings in SCO To test: 1. APPLY PATCH and restart_all 2. Make sure the following errors when issuing in SCO show just the error, no other info. on screen: DEBT RENEW_ISSUE ISSUED_TO_ANOTHER RESERVED TRANSFERRED INVALID_DATE ( cant test in SCO ) TOO_MANY RECALLED Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g Status|Needs Signoff |Signed Off --- Comment #4 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Patch works great, tested the various listed situations and all show just the error, no other info. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172531|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 173525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173525&action=edit Bug 38041: Pass hide_main for all needsconfirm warnings in SCO To test: 1. APPLY PATCH and restart_all 2. Make sure the following errors when issuing in SCO show just the error, no other info. on screen: DEBT RENEW_ISSUE ISSUED_TO_ANOTHER RESERVED TRANSFERRED INVALID_DATE ( cant test in SCO ) TOO_MANY RECALLED Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 23.11.x please provide specific patch if you can -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38041 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org