[Bug 31374] New: Add a non-public note column to the suggestions table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Bug ID: 31374 Summary: Add a non-public note column to the suggestions table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: lucas@bywatersolutions.com Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some libraries would like to have a non-public note field when entering suggestions so they can add suggestion notes that would not be visible to the public. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 139212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139212&action=edit Bug 31374: Database/Schema update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 139213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139213&action=edit Bug 31374: Add non-public note to template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 139214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139214&action=edit Bug 31374: Add privatenote column to table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 139216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139216&action=edit Bug 31374: Update API spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 139508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139508&action=edit Bug 31374: Update Suggestion.pm To test: 1. Apply patch and restart services 2. Go to Acquistions -> Suggestions -> New Purchase suggestion 3. Notice the new 'Non-public notes:' textarea 4. Make sure you 'Set a patron' so we can later look at the suggestion from the OPAC 5. Make a new suggestion and make sure you add some Non-public notes 6. Back on the 'Suggestions management' page you should see a new column for 'Non-public note' 7. Go to table settings and make sure you can properly hide the column 8. Change the status and make sure it shows up on the table with all statuses (pending, accepted, rejected, etc ) 9. Check the API by going to (/api/v1/suggestions). Your suggestion should show up and 'privatenote' should include your non-public note. 10. Log in to the OPAC as the patron we set the suggestion to earlier. You should not see anything related to the non-public note displaying from the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139212|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 139526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139526&action=edit Bug 31374: Database/Schema update Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139213|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 139527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139527&action=edit Bug 31374: Add non-public note to template Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139214|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 139528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139528&action=edit Bug 31374: Add privatenote column to table settings Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139216|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 139529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139529&action=edit Bug 31374: Update API spec Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139508|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 139530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139530&action=edit Bug 31374: Update Suggestion.pm To test: 1. Apply patch and restart services 2. Go to Acquistions -> Suggestions -> New Purchase suggestion 3. Notice the new 'Non-public notes:' textarea 4. Make sure you 'Set a patron' so we can later look at the suggestion from the OPAC 5. Make a new suggestion and make sure you add some Non-public notes 6. Back on the 'Suggestions management' page you should see a new column for 'Non-public note' 7. Go to table settings and make sure you can properly hide the column 8. Change the status and make sure it shows up on the table with all statuses (pending, accepted, rejected, etc ) 9. Check the API by going to (/api/v1/suggestions). Your suggestion should show up and 'privatenote' should include your non-public note. 10. Log in to the OPAC as the patron we set the suggestion to earlier. You should not see anything related to the non-public note displaying from the OPAC Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement adds a release notes| |non-public notes field to | |the suggestions tables in | |the staff interface. It is | |displayed by default in the | |suggestion management | |tables, and is configurable | |using the table settings. --- Comment #11 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): - For step 1 in the test plan, run the updatedatabase command as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, could we discuss renaming the database column? It's now: privatenote We don't use private as a term in any of the other tables or the GUI so I am hesitating to use completely new terminology here. What about: staff_note? If I see correctly we already have some of those in kohastructure.sql git grep note *.sql The second thing is me wondering if we should keep the status as the last column of the table, moving the new column forward by one. ... happy to hear your thoughts about that one! Otherwise this works really well! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Cait, Thanks for looking at this one. I was unsure when I named the DB column privatenote, I am happy to change it to 'staff_note'. As for the order of where the column lives, I sort of arbitrarily put it where I put it. I will move it to be right before 'Status'? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 139627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139627&action=edit Bug 31374: (follow-up) change private note to staff_note and reorder columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Since I only changed the column names I am keeping David's sign-off and setting this one to 'Signed-off'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139526|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139858&action=edit Bug 31374: Database/Schema update Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139527|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139859&action=edit Bug 31374: Add non-public note to template Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139528|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139860&action=edit Bug 31374: Add privatenote column to table settings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139529|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139861&action=edit Bug 31374: Update API spec Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139530|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139862&action=edit Bug 31374: Update Suggestion.pm To test: 1. Apply patch and restart services 2. Go to Acquistions -> Suggestions -> New Purchase suggestion 3. Notice the new 'Non-public notes:' textarea 4. Make sure you 'Set a patron' so we can later look at the suggestion from the OPAC 5. Make a new suggestion and make sure you add some Non-public notes 6. Back on the 'Suggestions management' page you should see a new column for 'Non-public note' 7. Go to table settings and make sure you can properly hide the column 8. Change the status and make sure it shows up on the table with all statuses (pending, accepted, rejected, etc ) 9. Check the API by going to (/api/v1/suggestions). Your suggestion should show up and 'privatenote' should include your non-public note. 10. Log in to the OPAC as the patron we set the suggestion to earlier. You should not see anything related to the non-public note displaying from the OPAC Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139627|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139863&action=edit Bug 31374: (follow-up) change private note to staff_note and reorder columns Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139864&action=edit Bug 31374: (QA follow-up) Fix typo collumn in database update Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to the 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.thornton@educampus.ie --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 23134 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org