[Bug 33233] New: OPAC advanced search inputs stay disabled when using browser's back button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Bug ID: 33233 Summary: OPAC advanced search inputs stay disabled when using browser's back button Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org
From a comment in Bug 7607:
On the OPAC when you click the back button the fields are not enabled - on the staff side they are, I leave this problem for someone else to solve We should solve this now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #1 from Donna <bwsdonna@gmail.com> --- This is really confusing for staff and patrons! I know the preferred behavior is to click the link to Return to last advanced search, but that is not a floating link, so unless you are at the top of the page, you don't see it. Typical use by a patron/staff is to do the search, scroll down the first page of results, and if the search is not on target, hit the back arrow and refine the search. The specifics of the search should be retained, but the user needs the ability to add additional fields etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- There seems to be a pretty large variation here depending on what browser is being used. Maybe it would be better to deal with these empty values at the script level, instead of in the templates? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149476&action=edit Bug 33233: Don't allow disabled attribute to remain when using browser's back button To test: 1. Go to OPAC advanced search and do a search using only one of the inputs. 2. Once the search is complete use the browser's back button to return to the advanced search. 3. Notice the unused inputs are disabled. 4. Apply patch and try again. Now the inputs should not be disabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149476|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 149701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149701&action=edit Bug 33233: Don't allow disabled attribute to remain when using browser's back button To test: 1. Go to OPAC advanced search and do a search using only one of the inputs. 2. Once the search is complete use the browser's back button to return to the advanced search. 3. Notice the unused inputs are disabled. 4. Apply patch and try again. Now the inputs should not be disabled. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov Status|Needs Signoff |Signed Off --- Comment #5 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- This worked great - so glad to see this fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149701|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 150141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150141&action=edit Bug 33233: Don't allow disabled attribute to remain when using browser's back button To test: 1. Go to OPAC advanced search and do a search using only one of the inputs. 2. Once the search is complete use the browser's back button to return to the advanced search. 3. Notice the unused inputs are disabled. 4. Apply patch and try again. Now the inputs should not be disabled. Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.06 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.06 |23.05.00,22.11.06,22.05.14 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Danyon Sewell <danyonsewell@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danyonsewell@catalyst.net.n | |z Version(s)|23.05.00,22.11.06,22.05.14 |23.05.00,22.11.06,22.05.14, released in| |21.11.22 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Danyon Sewell <danyonsewell@catalyst.net.nz> --- Backported to 21.11.x for upcoming 21.11.22 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33233 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34857 [Bug 34857] OPAC advanced search operator "not" is searching as "and" on chrome -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org