[Bug 39142] New: Add debug permission to allow user to toggle JS and CSS customizations on/off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Bug ID: 39142 Summary: Add debug permission to allow user to toggle JS and CSS customizations on/off Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 14004 We all love bug 14004 and its fun tools for loading pages without JS or CSS from sysprefs. We'd like to extend that idea to toggles that would appear on every page to turn UserJS and UserCSS on and off. We'd tie those toggles to a new "debug" permission, so only users with that permission will be shown those toggles. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14004 [Bug 14004] Add ability to temporarily disable added CSS and Javascript in OPAC and interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |imani.thomas@bywatersolutio |ity.org |ns.com CC| |imani.thomas@bywatersolutio | |ns.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #1 from Imani <imani.thomas@bywatersolutions.com> --- Created attachment 178123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178123&action=edit Bug 39142 Add debug permission to allow user to toggle JS and CSS customizations on/off Database changes for 39142 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #2 from Imani <imani.thomas@bywatersolutions.com> --- Created attachment 178294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178294&action=edit Bug 39142: Add debug permission to allow user to toggle JS and CSS customizations on/off to test: 1. apply the patch 2. use updatedatabase run to update your db 3. add custom JS and CSS in the IntranetUserJS and IntranetUserCSS fields 4. with as SuperLibrarian account confirm you have 3 buttons at the bottom of your screen, Disable User JS, Disable User CSS, and load only default stylesheets 5. clicking the buttons should reload the current page with a query to disable those things. 6. Log in as a user that is not a superlibrarian and does not have the debug UI permission enabled 7. confirm the buttons are no longer visible 8. Add the debug UI permission to the user 9. confirm the debug buttons are now visible for that user. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178123|0 |1 is obsolete| | --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 178481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178481&action=edit Bug 39142 Add debug permission to allow user to toggle JS and CSS customizations on/off Database changes for 39142 Signed-off-by: Lari Strand <lari.strand@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178294|0 |1 is obsolete| | --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 178482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178482&action=edit Bug 39142: Add debug permission to allow user to toggle JS and CSS customizations on/off to test: 1. apply the patch 2. use updatedatabase run to update your db 3. add custom JS and CSS in the IntranetUserJS and IntranetUserCSS fields 4. with as SuperLibrarian account confirm you have 3 buttons at the bottom of your screen, Disable User JS, Disable User CSS, and load only default stylesheets 5. clicking the buttons should reload the current page with a query to disable those things. 6. Log in as a user that is not a superlibrarian and does not have the debug UI permission enabled 7. confirm the buttons are no longer visible 8. Add the debug UI permission to the user 9. confirm the debug buttons are now visible for that user. Signed-off-by: Lari Strand <lari.strand@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmstrand@gmail.com --- Comment #5 from Lari Strand <lmstrand@gmail.com> --- Just a thought, we use multiple Koha plugins that inject Javascript or CSS to the intranet views (subs intranet_js/css in plugin main modules). The plugins can always be disabled but maybe it should be considered as an option in this new feature? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #6 from Imani <imani.thomas@bywatersolutions.com> --- A possible future enhancement to enable that maybe setting up a plugin hook for plugins to either add to the query string generated by the debug buttons here or add debug buttons of their own. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com CC| |baptiste.wojtkowski@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178481|0 |1 is obsolete| | --- Comment #7 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 183392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183392&action=edit Bug 39142 Add debug permission to allow user to toggle JS and CSS customizations on/off Database changes for 39142 Signed-off-by: Lari Strand <lari.strand@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178482|0 |1 is obsolete| | --- Comment #8 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 183393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183393&action=edit Bug 39142: Add debug permission to allow user to toggle JS and CSS customizations on/off to test: 1. apply the patch 2. use updatedatabase run to update your db 3. add custom JS and CSS in the IntranetUserJS and IntranetUserCSS fields 4. with as SuperLibrarian account confirm you have 3 buttons at the bottom of your screen, Disable User JS, Disable User CSS, and load only default stylesheets 5. clicking the buttons should reload the current page with a query to disable those things. 6. Log in as a user that is not a superlibrarian and does not have the debug UI permission enabled 7. confirm the buttons are no longer visible 8. Add the debug UI permission to the user 9. confirm the debug buttons are now visible for that user. Signed-off-by: Lari Strand <lari.strand@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #9 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Rebased on main. Waiting on feedback to PQA but looks good and working. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- I was reflecting on this idea... and it doesn't really seem like a user "permission" but rather a user "preference". This could be an opportunity to add a "borrower_ui_preferences" table for storing this sort of user preference. -- Alternatively, there are other user preferences like language which are managed by cookies like KohaOpacLanguage (see the patches on Bug 39206 for other Koha managed cookies). While I don't like the idea of adding more cookies to Koha... that could be an alternative path forward. -- As an aside, I'm trying to re-think Koha permission models, and something like this really sticks out. I suppose an argument could be made for it as a "view_debug_button" permission, but I think that's a stretch. If there were a permission, it would be on the ability to disable those sysprefs and then the "view_debug_button" operation would be hinged off that permission, so that only people authorized to perform that operation could view that button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I think it would make sense to introduce patron preferences as David said. Not sure whether this needs to necessarily be tied to just ui preferences, though. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40229 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #12 from David Cook <dcook@prosentient.com.au> --- On Mattermost, Lisette raised an interesting point. A permission would make sense, if the permission actually controlled the functionality added by bug 14004. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186913&action=edit Bug 39142: Add debug permission This patch adds the database foundation for the debug permission feature: - Creates bit 31 in userflags table for 'debug' permission - Updates mandatory userflags.sql for fresh installations - Provides atomic update script for existing installations The debug permission will allow authorized users to access debugging tools for toggling JavaScript and CSS customizations. Signed-off-by: Lari Strand <lari.strand@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183393|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186914&action=edit Bug 39142: Add debug permission to allow user to toggle JS and CSS customizations on/off To test: 1. Apply the patch 2. Use updatedatabase run to update your db 3. Add custom JS and CSS in the IntranetUserJS and IntranetUserCSS fields 4. With a superLibrarian account confirm you have 3 buttons at the bottom of your screen, Disable User JS, Disable User CSS, and load only default stylesheets 5. Clicking the buttons should reload the current page with a query to disable those things. 6. Log in as a user that is not a superlibrarian and does not have the debug UI permission enabled 7. Confirm the buttons are no longer visible 8. Add the debug UI permission to the user 9. Confirm the debug buttons are now visible for that user. Signed-off-by: Lari Strand <lari.strand@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186915&action=edit Bug 39142: (QA follow-up) Add unit tests for DISABLE_SYSPREF permission checking This commit adds a unit test for the syspref override permission checking functionality to ensure: - Users without debug permission cannot override system preferences via URL parameters - Users with debug permission can successfully override system preferences - Superlibrarians maintain their ability to override system preferences - The permission checking logic works correctly with haspermission() The test creates three test patrons: 1. Regular patron with only catalogue permission (should be denied) 2. Patron with debug permission (should be allowed) 3. Superlibrarian (should be allowed) Tests verify both the permission checking and the actual environment variable setting that controls syspref overrides. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186916&action=edit Bug 39142: (QA follow-up) Add permission checking for syspref overrides This follow-up adds proper security controls for the DISABLE_SYSPREF_* URL parameter functionality introduced in Bug 14004. Previously, any user could bypass system preferences by using URL parameters without authorization. Changes: - Restricts DISABLE_SYSPREF_* parameter processing to users with debug permission - Uses existing haspermission() method for consistent authorization checking - Maintains superlibrarian access as expected - Closes potential security loophole where unauthorized users could disable system preferences like IntranetUserJS and IntranetUserCSS The debug UI buttons will only appear for authorized users, and now the underlying syspref override functionality requires the same permission, ensuring both UI and functional security are aligned. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Attachment #183392|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I decided to take over on QA here. I felt we should add a follow-up to use the permission as a permission and properly close off a loophole. I really like the idea of a new table with user preferences etc, but I think that should take a new bug and discussion. Code wise, I'm happy now and with the follow-ups I feel we're in a good position to PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|baptiste.wojtkowski@biblibr |martin.renvoize@openfifth.c |e.com |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nitpicking here but please have a look at the coding guidelines for when to use upper case vs lower case strings: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_lowe... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #19 from Imani <imani.thomas@bywatersolutions.com> --- Created attachment 187061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187061&action=edit Bug 39142: fixing capitalization as per coding guidelines https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_lowe... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #20 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I have a few issues with this, mainly the UI component. Right now it all goes in: <div style="position: fixed; bottom: 0;"></div> 1. This is going to get really annoying and be in the way for superlibrarians. 2. If I click "Disable User CSS" the button still reads "Disable User CSS" leading to me believe it is NOT disabled. 3. If I click "Disable User CSS" more than once it continues to append the URL param over and over again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #21 from Imani <imani.thomas@bywatersolutions.com> --- Would Adding a button to temporarily hide the div be sufficient for #1? for the rest I am imagining just detecting if the relevant parameter is already in the url and hiding the button if so. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189754&action=edit Bug 39142: Add debug permission This patch adds the database foundation for the debug permission feature: - Creates bit 31 in userflags table for 'debug' permission - Updates mandatory userflags.sql for fresh installations - Provides atomic update script for existing installations The debug permission will allow authorized users to access debugging tools for toggling JavaScript and CSS customizations. Signed-off-by: Lari Strand <lari.strand@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189755&action=edit Bug 39142: Add debug permission to allow user to toggle JS and CSS customizations on/off To test: 1. Apply the patch 2. Use updatedatabase run to update your db 3. Add custom JS and CSS in the IntranetUserJS and IntranetUserCSS fields 4. With a superLibrarian account confirm you have 3 buttons at the bottom of your screen, Disable User JS, Disable User CSS, and load only default stylesheets 5. Clicking the buttons should reload the current page with a query to disable those things. 6. Log in as a user that is not a superlibrarian and does not have the debug UI permission enabled 7. Confirm the buttons are no longer visible 8. Add the debug UI permission to the user 9. Confirm the debug buttons are now visible for that user. Signed-off-by: Lari Strand <lari.strand@koha-suomi.fi> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189756&action=edit Bug 39142: (QA follow-up) Add unit tests for DISABLE_SYSPREF permission checking This commit adds a unit test for the syspref override permission checking functionality to ensure: - Users without debug permission cannot override system preferences via URL parameters - Users with debug permission can successfully override system preferences - Superlibrarians maintain their ability to override system preferences - The permission checking logic works correctly with haspermission() The test creates three test patrons: 1. Regular patron with only catalogue permission (should be denied) 2. Patron with debug permission (should be allowed) 3. Superlibrarian (should be allowed) Tests verify both the permission checking and the actual environment variable setting that controls syspref overrides. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189757&action=edit Bug 39142: (QA follow-up) Add permission checking for syspref overrides This follow-up adds proper security controls for the DISABLE_SYSPREF_* URL parameter functionality introduced in Bug 14004. Previously, any user could bypass system preferences by using URL parameters without authorization. Changes: - Restricts DISABLE_SYSPREF_* parameter processing to users with debug permission - Uses existing haspermission() method for consistent authorization checking - Maintains superlibrarian access as expected - Closes potential security loophole where unauthorized users could disable system preferences like IntranetUserJS and IntranetUserCSS The debug UI buttons will only appear for authorized users, and now the underlying syspref override functionality requires the same permission, ensuring both UI and functional security are aligned. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189758&action=edit Bug 39142: fixing capitalization as per coding guidelines https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_lowe... Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189759&action=edit Bug 39142: Improve debug controls UI integration Moves debug controls from fixed bottom position (which overlapped navbar) to an integrated navbar dropdown with bug icon. Improves UX with: - Proper navbar integration at far right after user menu - Dynamic button text (Enable/Disable) reflecting current state - Icon color change (amber) when any toggles are active - Prevents duplicate URL parameters on multiple clicks Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186913|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186914|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186915|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187061|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- To get this over the line I went ahead and added an improved UI patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191081&action=edit Bug 39142: (RM follow-up) Add missing comma to userflags.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_26_05_candidate | --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- please add release notes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #32 from Jonathan Druart <jonathan.druart@gmail.com> --- Koha/Template/Plugin/Koha +sub debug_flag { This is VERY confusing. There is a "debug" in the config already Why don't you simply use the Koha::Patron object stored in the logged_in_user TT variable? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Imani <imani.thomas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fix adds GUI controls release notes| |to disable custom CSS and | |JS on the page. It also | |includes a system | |preference, user flag, to | |control managing this along | |with updates to permissions | |for being able to do this. | |This works alongside the | |pre-existing url parameters | |to disable custom css and | |JS in the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #33 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191193&action=edit Bug 39142: Remove Koha::Template::Plugin::debug_flag Patch from commit 3f8d031 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191193|0 |1 is obsolete| | --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 191194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191194&action=edit Bug 39142: Remove Koha::Template::Plugin::debug_flag Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloe.zermatten@openfifth.c | |o.uk --- Comment #35 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Not backporting to 25.11.x (stable) as it's an enhancement / new feature. Happy to reconsider if needed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #36 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This bug won't be backported to the 25.11.x branch as it has been deemed an enhancement or new feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43260 [Bug 43260] Debug options in navigation bar untranslatable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 --- Comment #37 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This is cool, but I don't see the strings in the po files, making the feature untranslatable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39142 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1221 Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #38 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I documented this for the manual. I noticed in the code (patch Add debug permission to allow user to toggle...) that the toggle also includes the OPAC prefs, but I was not able to disable the OPAC using the drop down in the staff interface. In fact, I was not able to find the toggles in the "intranet-bottom". I wonder if it's code that should not have been pushed? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org