[Bug 37888] New: Default filtering of background jobs could be improved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Bug ID: 37888 Summary: Default filtering of background jobs could be improved Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com
From Julian:
I don't like the two available filters and the fact that they are enabled by default. 99% of the time I see an empty table because the jobs I just launched are already finished by the time I go to this page or because the job I want to check was queued more than an hour ago. Why don't we display the last X queued jobs by default ? I don't want to see unfinished jobs or "queued less than an hour ago" jobs. I want to see the more recent jobs. An option to filter out finished jobs is useful but in my case it would be less annoying if it was disabled by default. However, the 1 hour filter is arbitrary (why 1 hour ?) and not so useful in my opinion, as long as we can sort by queued date/time -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36217 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36217 [Bug 36217] Jobs page include last hour filter does not work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu --- Comment #1 from Eric Phetteplace <ephetteplace@cca.edu> --- I agree that for my purposes seeing the last X jobs is probably better than last hour. A filter for unfinished jobs would definitely be helpful. I am almost always checking on a batch metadata ingest and I just want to keep tabs on only that until it finishes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36217 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36217 [Bug 36217] Jobs page include last hour filter does not work -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37905 [Bug 37905] Correctly fix the "last hour" filter on the job list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 172388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172388&action=edit Bug 37888: Show all jobs, order by "queued", remove last hour filter By default the background jobs page now shows the most recently queued jobs, whatever their status is. By doing that, the jobs enqueued less an hour ago are always visible if there are any (well, the first page at least), so the "last hour" filter becomes way less useful and it's better to remove it as it caused problems (see bug 37905) and the "1 hour" duration was arbitrary. The "current jobs only" filter is still useful as lots of quick background jobs can push running jobs away from the first page and it's a common use case to list running jobs Test plan: 1. Start some background jobs (batch item modification for instance) 2. Make them run and wait for finish 3. Stop the background jobs workers 4. Start some more background jobs 5. You should now have running and non-running background jobs. Go to the admin background jobs page 6. Verify that all background jobs are shown and that they ordered by queued time (last queued job first) 7. Verify that "Current jobs only" filter still works -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | CC| |julian.maurice@biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 --- Comment #3 from Eric Phetteplace <ephetteplace@cca.edu> --- I can't get this patch to apply against main. Am I perhaps doing something wrong? I will leave it at needs signoff. I'm doing this manually, not with git-bz, and I've successfully applied patches before. If I `git am -3 -i -u <name_of_patch_file>` like the wiki recommends, I get "error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt). error: could not build fake ancestor" If I try `git apply` or `cat patch_file | patch -p1` I get portions that are unable to be applied: "2 out of 4 hunks failed--saving rejects to 'koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt.rej'" The rejected chunks are the `let additional_filters...` JS is and the third chunk of JS further down that references that var and adds an on change handler. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 --- Comment #4 from Eric Phetteplace <ephetteplace@cca.edu> --- If I'm not mistaken, the patch also needs to update the `query_filters` function on lines 262-72 here https://gitlab.com/koha-community/Koha/-/blob/main/koha-tmpl/intranet-tmpl/p... since the #include_last_hour element no longer exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Eric Phetteplace from comment #3)
I can't get this patch to apply against main. The patch depends on bug 37905. You need to apply it first.
(In reply to Eric Phetteplace from comment #4)
If I'm not mistaken, the patch also needs to update the `query_filters` function on lines 262-72 here https://gitlab.com/koha-community/Koha/-/blob/main/koha-tmpl/intranet-tmpl/ prog/en/modules/admin/background_jobs.tt#L262-272 since the #include_last_hour element no longer exists.
the query_filters function is removed by bug 37905 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 --- Comment #6 from Eric Phetteplace <ephetteplace@cca.edu> --- OK my apologies! I've never signed off on a bug where I needed to apply a dependent patch. I should be able to QA this today or tomorrow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172388|0 |1 is obsolete| | --- Comment #7 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 172503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172503&action=edit Bug 37888: Show all jobs, order by "queued", remove last hour filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Eric Phetteplace from comment #6)
OK my apologies! I've never signed off on a bug where I needed to apply a dependent patch. I should be able to QA this today or tomorrow. No need for apologies, we've all been there ;) Thank you for testing!
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172503|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172905&action=edit Bug 37888: Show all jobs, order by "queued", remove last hour filter By default the background jobs page now shows the most recently queued jobs, whatever their status is. By doing that, the jobs enqueued less an hour ago are always visible if there are any (well, the first page at least), so the "last hour" filter becomes way less useful and it's better to remove it as it caused problems (see bug 37905) and the "1 hour" duration was arbitrary. The "current jobs only" filter is still useful as lots of quick background jobs can push running jobs away from the first page and it's a common use case to list running jobs Test plan: 1. Start some background jobs (batch item modification for instance) 2. Make them run and wait for finish 3. Stop the background jobs workers 4. Start some more background jobs 5. You should now have running and non-running background jobs. Go to the admin background jobs page 6. Verify that all background jobs are shown and that they ordered by queued time (last queued job first) 7. Verify that "Current jobs only" filter still works Signed-off-by: Eric Phetteplace <phette23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Simpler and cleaner UX with this.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This updates the display release notes| |and filter option for | |background jobs. By default | |the background jobs page | |now shows the most recently | |queued jobs, whatever their | |status is, and allows to | |filter on the current | |pending and running jobs. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37888 Bug 37888 depends on bug 37905, which changed state. Bug 37905 Summary: Correctly fix the "last hour" filter on the job list https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37905 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org