[Bug 36527] New: Patron category or item type not changing when editing another circulation rule
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Bug ID: 36527 Summary: Patron category or item type not changing when editing another circulation rule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This was reported to me as a slightly different problem, but I was able to recreate it partially in master. When editing circulation rules, if you click on "Edit" on another rule and confirm you want to change that rule, the patron category and item type don't always change to the new one. To recreate: 1. Go to Administration > Circulation and fine rules 2. Add a couple of rules with various patron category/item type combinations 3. Click on "Edit" next to one of the rules --> The line should become highlighted in yellow and the values should be copied in the very last row 4. Click on "Edit" next to another rule 5. Click OK in the browser dialog box to confirm you want to edit another rule --> Depending on the rules, the values for the patron category and/or item type might not change in the editing row 6. Repeat steps 4 and 5 --> The patron category and item type do not always change I'm using Chrome with 23.12.00.015 on KTD (it does the same on my local master and my local 23.05.05 too). The person who reported it to me has 23.05.01. And their problem is that even on the first click (step 3), the values in the edit row are not the correct ones. The patron category stays "All" (the default value in the edit row), and the item type changes to the correct item type. I thought it could be a cache problem, but with KTD I assumed that was all included and taken care of. We also restarted plack and memcache on the client's install and the problem remains. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 --- Comment #1 from Phan Tung Bui <phan-tung.bui@inlibro.com> --- Created attachment 164779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164779&action=edit Bug 36527: Patron category or item type not changing when editing another circulation rule Plan test : 1. Go to Administration > Circulation and fine rules 2. Add a couple of rules with various patron category/item type combinations 3. Click on "Edit" next to one of the rules --> The line should become highlighted in yellow and the values should be copied in the very last row 4. Click on "Edit" next to another rule 5. Click OK in the browser dialog box to confirm you want to edit another rule --> Depending on the rules, the values for the patron category and/or item type might not change in the editing row 6. Repeat steps 4 and 5 --> The patron category and item type do not always change 7. Apply the batch 8. Redo step from 3 to 6 9. Observe that category and item type change accordingly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164779|0 |1 is obsolete| | --- Comment #2 from Phan Tung Bui <phan-tung.bui@inlibro.com> --- Created attachment 164781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164781&action=edit Bug 36527: Patron category or item type not changing when editing another circulation rule Plan test : 1. Go to Administration > Circulation and fine rules 2. Add a couple of rules with various patron category/item type combinations 3. Click on "Edit" next to one of the rules --> The line should become highlighted in yellow and the values should be copied in the very last row 4. Click on "Edit" next to another rule 5. Click OK in the browser dialog box to confirm you want to edit another rule --> Depending on the rules, the values for the patron category and/or item type might not change in the editing row 6. Repeat steps 4 and 5 --> The patron category and item type do not always change 7. Apply the batch 8. Redo step from 3 to 6 9. Observe that category and item type change accordingly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |phan-tung.bui@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164781|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 164855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164855&action=edit Bug 36527: Patron category or item type not changing when editing another circulation rule Plan test : 1. Go to Administration > Circulation and fine rules 2. Add a couple of rules with various patron category/item type combinations 3. Click on "Edit" next to one of the rules --> The line should become highlighted in yellow and the values should be copied in the very last row 4. Click on "Edit" next to another rule 5. Click OK in the browser dialog box to confirm you want to edit another rule --> Depending on the rules, the values for the patron category and/or item type might not change in the editing row 6. Repeat steps 4 and 5 --> The patron category and item type do not always change 7. Apply the batch 8. Redo step from 3 to 6 9. Observe that category and item type change accordingly Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |hammat.wele@inlibro.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164855|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168144&action=edit Bug 36527: Patron category or item type not changing when editing another circulation rule Plan test : 1. Go to Administration > Circulation and fine rules 2. Add a couple of rules with various patron category/item type combinations 3. Click on "Edit" next to one of the rules --> The line should become highlighted in yellow and the values should be copied in the very last row 4. Click on "Edit" next to another rule 5. Click OK in the browser dialog box to confirm you want to edit another rule --> Depending on the rules, the values for the patron category and/or item type might not change in the editing row 6. Repeat steps 4 and 5 --> The patron category and item type do not always change 7. Apply the batch 8. Redo step from 3 to 6 9. Observe that category and item type change accordingly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02,23.11.07 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes editing release notes| |circulation rules, where | |the patron category and | |item type didn't change | |when you were editing one | |rule and then changed to | |editing another rule. This | |could happen if you were: | |1. Editing a rule. 2. | |Clicked on Edit to change | |another rule. 3. Confirmed | |that you wanted to edit | |another rule. Depending on | |your rules, the values for | |the patron category or item | |type in the editing row may | |not have changed. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #8 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36527 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #10 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org