http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20946&action=edit Bug 10857: Add facets cancellation When searching (at the OPAC or pro), facets can be enabled but never disabled. So a user is obliged to relaunch the search. This patch adds a new link "[x]" at the right of each selected facet. This link relaunch the search without this facet. Test plan: - Launch a search (OPAC and pro) - Enable some facets - Disable some facets -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I made 4 tests : click on a Series facet, then remove it => OK click on an Author facet, then remove it => OK click on a Serial facet, then an Author facet, then remove the Author facet, then remove the Serial facet => OK click on a Serial facet, then an Author facet, then remove the Serial facet, then remove the Author facet => KO For me the last test failed : if the facets are removed in a different order than the order used to enable them, the [x] disappears, but Koha does not relaunch the search. Do you think you can fix that? I hope this is not too complex. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Maybe a js problem in my browser! I will take an other look. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to mathieu saby from comment #6)

Sorry, still not working. I made a little screencast. Better than long speeches... https://www.youtube.com/watch?v=5ANbVtjpnNA

Mathieu

How many results did you get with only the author facet selected? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to mathieu saby from comment #8)

5 results with one facet, 2 results with 2 facets.

On the screencast I see 5 results for the "Series" facets. So you got 5 results for the author facet too? If you got only 2, the behavior is normal. If you got 5, it is not.

Maybe my records are not very "clean" and that could explain the issue. Should I try on a sandbox?

Yes, it will be easiest to debug an issue on a sandbox. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mathieu, did you have a chance to test? I would really like to see this happen :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #13 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- And sandbox 3 crashed to, but probably for another reason... Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- (In reply to mathieu saby from comment #12)

I made some tests : I was not satisfied, and had probably not related problems (I crashed my browers 3 times because of too big http header or something like that).

Here's what I got after testing a few times: Bad Request Your browser sent a request that this server could not understand. Size of a request header field exceeds server limit. Cookie /n -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #16 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- OH, exactly the same bug here! But I thought it was not linked. M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- As Julian said, I am not sure the problem is from this patch. I think the issue already exists in master. Switch back to needs signoff. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- I haven't run across the "Bad request" error again, but I did find this: 1. Perform a search 2. Click a library facet 3. Cancel the library facet 4. Click another library facet At this point there is no "[x]" by the facet I clicked in step 4. Same results in the OPAC and staff client. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #19)

I haven't run across the "Bad request" error again, but I did find this:

1. Perform a search 2. Click a library facet 3. Cancel the library facet 4. Click another library facet

At this point there is no "[x]" by the facet I clicked in step 4. Same results in the OPAC and staff client.

I cannot reproduced, tested in the OPAC and staff. The link appears and works. What is the url generated in step 4? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Owen Leonard from comment #22)

1. Keyword search from the main search bar: /cgi-bin/koha/opac-search.pl?idx=&q=blue

2. Click library facet:

/cgi-bin/koha/opac-search. pl?q=blue%2520%2523relevance_dsc&sort_by=relevance_dsc&limit=branch:APL

3. Cancel library facet:

/cgi-bin/koha/opac-search.pl?idx=kw&q=blue%2520&limit=branch: APL&sort_by=relevance_dsc&nolimit=branch:APL

4. Click another library facet:

/cgi-bin/koha/opac-search. pl?q=kw%253Ablue%2520%2523relevance_dsc&sort_by=relevance_dsc&limit=branch: NPL

Here I get: 1/ opac-search.pl?q=d 2/ opac-search.pl?idx=kw&q=d&sort_by=author_asc&limit=branch:CPL 3/ opac-search.pl?idx=kw&q=d&limit=branch:CPL&sort_by=author_asc&nolimit=branch:CPL 4/ opac-search.pl?idx=kw&q=d&sort_by=author_asc&limit=branch:MPL I don't understand why between your 3 and 4 the idx=kw&q=blue become kw:blue. But in all cases, a facet is considered as active if a limit param is index:value. Since it works with the first query, it is really odd that it does not work with the second one. Mathieu, did you reproduce on a sandbox? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to mathieu saby from comment #24)

- Sandbox 1 did not set up

The sandbox is now available. I blocked it for tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #27 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Note : it is easier to test by setting maxRecordsForFacets to a big number (say 500 or 1000) and activate displayFacetCount. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #29 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Test 3 : I confirm the problem if the 2 facets are in the same category. And I experienced again the crash server again, but I have no idea whether it is related to your patch. - search "e*" - click on library "Le Canet (1000)" => [x] before 3950 result(s) found for 'kw,wrdl: e*' with limit(s): 'branch:Le Cannet' in Médiathèque municipale Le Cannet des Maures Catalog. http://pro.test1.biblibre.com/cgi-bin/koha/catalogue/search.pl?idx=kw&q=e%252A&limit=branch:MAURES - click on library "Médiathèque départementale de prêt (4)" http://pro.test1.biblibre.com/cgi-bin/koha/catalogue/search.pl?idx=kw&q=e%252A&limit=branch:MAURES&limit=branch:BDP BOUM! FF Error "La connexion avec le serveur a été réinitialisée pendant le chargement de la page." I broke sandbox staff interface! I had made the same test 5 before, but I did not note the results at that time. And I did not experience the server error. Strange. I try to test the same search on OPAC - search "e*" - click on library "Le Canet (1000)" => [x] before http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=e%252A&limit=branch:MAURES Your search returned 3950 results - click on library "Médiathèque départementale de prêt" [x] before the 2 facets http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=e%252A&limit=branch:MAURES&limit=branch:BDP Your search returned 21 results. Subscribe to this search - uncheck "Le Canet" => still 21 results! http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=e%252A&limit=branch:MAURES&limit=branch:BDP&nolimit=branch:MAURES Your search returned 21 results. Médiathèque Départementale de Prêt [x] Le Cannet (21) Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #31 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- In fact, there is only 21 documents in BDP http://catalogue.test1.biblibre.com/cgi-bin/koha/opac-search.pl?idx=kw&q=e%252A&limit=branch:BDP and all of these seems to be also in "Le Canet" (I cannot see "Le Canet" items on records, maybe they are hidden). So my 3d test does not prove anything :( And I cannot go back to staff interface so suppress some items, as I broke it... Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-24 00:00:00 |2013-10-28 last check this| | --- Comment #33 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24082&action=edit Bug 10857: Encode 'limit' parameter values to allow facets with '&' character. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #38 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I made several searchs and tested several facets : authors - series - topics and I have used several facets in the same time (in the same categries or not). When I remove a facet with [x], I have the logical number of results. I have the same results in OPAC or in pro interface. It's ok for me. Sonia -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24081|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #40 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 24125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24125&action=edit Bug 10857: Add facets cancellation When searching (at the OPAC or pro), facets can be enabled but never disabled. So a user is obliged to relaunch the search. This patch adds a new link "[x]" at the right of each selected facet. This link relaunch the search without this facet. Test plan: - Launch a search (OPAC and pro) - Enable some facets - Disable some facets Signed-off-by: sonia bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Needs updated to include bootstrap theme. Other than that, it looks great! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #43 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24162&action=edit Bug 10857: Add facets cancellation - bootstrap theme. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24202&action=edit [PASSED QA] Bug 10857: Encode 'limit' parameter values to allow facets with '&' character. Signed-off-by: sonia bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11524 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think maybe the little x could be formatted a bit differently to be more obvious, but that is not enough for failing QA on this :) I discovered bug 11524 while testing this, which could be related to bug 10952 this depends on. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.