[Bug 11741] New: < > not displaying correctly in XSLT result list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Bug ID: 11741 Summary: < > not displaying correctly in XSLT result list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org If you have a record, that contains < >, those are incorrectly escaped on the OPAC and staff XSLT result lists. The detail pages display correctly. Example: Record: Wer ist wer? <TEST> Display: Wer ist wer? <TEST> HTML source: <TEST> It looks like a problem with the sequence of escaping characters. First < > are changed to HTML entities, then the apersand itself is changed, leaving us with a mix. This was reported by one of our librares and seems to have changed between 3.6 and 3.12 as they were recently updated. The problem doesn't seem to appear on master. I couldn't test with 3.14 so far. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, thinking more about it - I think it could also be a configuration/indexing problem. Needs more testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, it's not related to the version actually - it's related to indexing: rebuild_zebra.pl -x = broken display rebuild_zebra.pl without -x = display ok -x is the default on package installations. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 25199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25199&action=edit Bug 11741: Correct display of < > in XSLT result lists < and > are incorrectly transformed into HTML entities on the XSLT result list. Example: Record: <TEST> Result list: <TEST> HTML source: <TEST> To test: - catalog a record that contains > and < - Reindex, without using the -x option - Confirm the display is correct - Reindex again, using the -x option - Confirm the display is now broken - Apply patch - Reindex again with and without -x - Verify that now the display is always correct -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I found a way to fix the display, but I am not totally persuaded this is a good solution - please comment :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- I think the patch is good, but I can't duplicate. I added a record from z39.50, but tweaked the title to have >TEST< I then did: ./misc/migration_tools/rebuild_zebra.pl -b -a -r -x -v Then realized OOPS! 3.14.x not master. git checkout -b bug_11741 origin/3.14.x And then I tried to browse for the record https://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=... And everything displayed nicely. I then thought, "Oh wait! XSLT junk!" So, I changed the OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to default. And retried. Still looked okay. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think Tomas tried to dig out the real problem, maybe he has an idea why reproducing the problem proved difficult? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to M. Tompsett from comment #5)
I think the patch is good, but I can't duplicate.
You need to be in a GRS-1 setup to reproduce. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25199|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 25617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25617&action=edit Bug 11741: Correct display of < > in XSLT result lists < and > are incorrectly transformed into HTML entities on the XSLT result list. Example: Record: <TEST> Result list: <TEST> HTML source: <TEST> To test: - catalog a record that contains > and < - Reindex, without using the -x option - Confirm the display is correct - Reindex again, using the -x option - Confirm the display is now broken - Apply patch - Reindex again with and without -x - Verify that now the display is always correct Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Note: the problem is only visible in GRS-1 setup. It works as expected. No behaviour change in DOM. I belive we shouldn't be (de)escaping data ad-hoc, but it seems that GRS-1 needs it because it doesn't handle HTML entities properly. This fix is OK for GRS-1, unneeded for DOM and probably any other modern search engine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Isaac <isaacbrodsky@live.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isaacbrodsky@live.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25617|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 26106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26106&action=edit [PASSED QA] Bug 11741: Correct display of < > in XSLT result lists < and > are incorrectly transformed into HTML entities on the XSLT result list. Example: Record: <TEST> Result list: <TEST> HTML source: <TEST> To test: - catalog a record that contains > and < - Reindex, without using the -x option - Confirm the display is correct - Reindex again, using the -x option - Confirm the display is now broken - Apply patch - Reindex again with and without -x - Verify that now the display is always correct Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Note: the problem is only visible in GRS-1 setup. It works as expected. No behaviour change in DOM. I belive we shouldn't be (de)escaping data ad-hoc, but it seems that GRS-1 needs it because it doesn't handle HTML entities properly. This fix is OK for GRS-1, unneeded for DOM and probably any other modern search engine. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11741 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org