[Bug 36003] New: Printing list from OPAC shows "Cookies" when CookieConsent enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Bug ID: 36003 Summary: Printing list from OPAC shows "Cookies" when CookieConsent enabled Change sponsored?: --- Product: Koha Version: 23.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Lists Assignee: koha-bugs@lists.koha-community.org Reporter: mirjam.vantieghem@etf.edu QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl If system preference CookieConsent is set to "Required", the word "Cookies" appears at the bottem left on the last page, under the last result, when printing a list from the OPAC. Funny, but not desirable. Not sure if similar to bug #12260. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161801&action=edit Bug 36003: Add cookie consent buttons to hidden list on print This patch adds #consentMoreInfo, #cookieConsentFooter and .consentAcceptEssential to the hidden fields for OPAC printing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on| |35348 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 [Bug 35348] Cookie information should be available regardless of whether you are logged in or not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161801|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 162001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162001&action=edit Bug 36003: Add cookie consent buttons to hidden list on print This patch adds #consentMoreInfo, #cookieConsentFooter and .consentAcceptEssential to the hidden fields for OPAC printing. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): 1. Set the CookieConsent system preference to required. 2. Create a public list and add some items. 3. Go to the OPAC and view the list (don't log in, or click the 'Accept all cookies' prompt in the footer). 4. Print the list. 5. Note that "Accept all cookies" is printed near the bottom of the page. 6. Apply the patch. 7. Rebuild the CSS: yarn build 8. Restart everything: reset_all 9. Refresh the list page and print the list again - it should now not show "Accept all cookies" near the bottom of the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Whole bunch of deps in PQA and SO too. Skipping for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162001|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166120&action=edit Bug 36003: Add cookie consent buttons to hidden list on print This patch adds #consentMoreInfo, #cookieConsentFooter and .consentAcceptEssential to the hidden fields for OPAC printing. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|23.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Bug 36003 depends on bug 35348, which changed state. Bug 35348 Summary: Cookie information should be available regardless of whether you are logged in or not https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35348 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 35348 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36003 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED Text to go in the| |This fixes an issue with release notes| |printing lists. If the | |CookieConsent system | |preference was set to | |"Required", printing a list | |from the OPAC resulted in | |the word "Cookies" | |appearing at the bottom | |left on the last page, | |under the last result. --- Comment #8 from David Nind <david@davidnind.com> --- No updates required to the manual - this fixes an issue with the output from printing a list, -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org