[Bug 38727] New: Improve translatability in categories.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Bug ID: 38727 Summary: Improve translatability in categories.tt Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: f.demians@tamil.fr, jonathan.druart@gmail.com There are three strings that are more or less like this: ``` If set, this will override the global value set in the {preference} preference ``` They are built in a way that splits it into * `If set, this will override the global value set in the` * `preference` At least in spanish, `preference` needs to be put in before `{preference}`: `Si se define, tendrá precedencia sobre el valor global definido en la preferencia de sistema {preference}` So (in the translation) we need to put a space or similar for `preference`. But it turns out this string is reused in many other places, so translating it correctly actually breaks translations in many places. I think (at least) other latin languages will suffer the same. This is terrible and needs to get fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 175609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175609&action=edit Bug 38727: Improve translatability in categories.tt This makes the strings easier to translated for maintaining them as a whole instead of splitting them Extra: it adds a missing dot for consistency. To test: 1. In the categories edit page, check the 3 'If set...' texts 2. Apply this patch and reload => SUCCESS: No visual change 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28924 Keywords| |rel_24_11_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28924 [Bug 28924] Allow checkout fine limit to be determined by patron category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- You should escape the result of a translation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175609|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 175619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175619&action=edit Bug 38727: Improve translatability in categories.tt This makes the strings easier to translated for maintaining them as a whole instead of splitting them Bonus 1: it adds a missing dot for consistency. Bonus 2: makes a string more idiomatic. To test: 1. In the categories edit page, check the 3 'If set...' texts 2. Apply this patch and reload => SUCCESS: No visual change 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #2)
You should escape the result of a translation.
Thanks for pointing me in that direction :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Bug 38727 depends on bug 28924, which changed state. Bug 28924 Summary: Allow checkout fine limit to be determined by patron category https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28924 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175619|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 176107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176107&action=edit Bug 38727: Improve translatability in categories.tt This makes the strings easier to translated for maintaining them as a whole instead of splitting them Bonus 1: it adds a missing dot for consistency. Bonus 2: makes a string more idiomatic. To test: 1. In the categories edit page, check the 3 'If set...' texts 2. Apply this patch and reload => SUCCESS: No visual change 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve translatability in |Improve the translatability |categories.tt |of the patron categories | |page (categories.tt) CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Still this one is ugly: msgid ", holds placed by patrons of this category will not be given priority." Because of the "If <i>Yes</i>" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176107|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176675&action=edit Bug 38727: Improve translatability in categories.tt This makes the strings easier to translated for maintaining them as a whole instead of splitting them Bonus 1: it adds a missing dot for consistency. Bonus 2: makes a string more idiomatic. To test: 1. In the categories edit page, check the 3 'If set...' texts 2. Apply this patch and reload => SUCCESS: No visual change 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176676&action=edit Bug 38727: Add missing closing div Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improve the translatability |Improve the translatability |of the patron categories |of the patron categories |page (categories.tt) |administration page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This improves the release notes| |translatability of the hint | |text when adding or | |modifying the "Block | |expired patron OPAC | |actions" field on the | |patron categories | |administration page | |(Administration > Patrons | |and circulation > Patron | |categories). --- Comment #10 from David Nind <david@davidnind.com> --- Did some patches get lost here? For adding the release note, it only looks like the "Block expired patron OPAC actions" field hint text is changed. The patch mentions other text was changed, and obsoleted patches have some changes to the "If set, ...." and other hint text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 --- Comment #11 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to David Nind from comment #10)
Did some patches get lost here?
For adding the release note, it only looks like the "Block expired patron OPAC actions" field hint text is changed.
The patch mentions other text was changed, and obsoleted patches have some changes to the "If set, ...." and other hint text.
I see the two patches in main: ```shell tig log 7cb370904b4c6ee0abf13db85b6893b6eeca6793 tig log aff29616abc3a791c3b3ccf656313c77e21b19db ``` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This improves the |This improves the release notes|translatability of the hint |translatability of the hint |text when adding or |text for these fields on |modifying the "Block |the patron categories form |expired patron OPAC |(Administration > Patrons |actions" field on the |and administration > Patron |patron categories |categories): |administration page |- Block |(Administration > Patrons |expired patron OPAC actions |and circulation > Patron |- Exclude from local holds |categories). |priority | |- Checkout charge | |limit | |- Guarantees checkout | |charge limit | |- Guarantors | |with guarantees checkout | |charge limit --- Comment #12 from David Nind <david@davidnind.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #11)
(In reply to David Nind from comment #10)
Did some patches get lost here?
For adding the release note, it only looks like the "Block expired patron OPAC actions" field hint text is changed.
The patch mentions other text was changed, and obsoleted patches have some changes to the "If set, ...." and other hint text.
I see the two patches in main:
```shell tig log 7cb370904b4c6ee0abf13db85b6893b6eeca6793 tig log aff29616abc3a791c3b3ccf656313c77e21b19db ```
Not sure what I was thinking/seeing. Everything looks OK now that I've looked at it again! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38727 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org