[Bug 38227] New: Collapse authority popup search form when showing results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Bug ID: 38227 Summary: Collapse authority popup search form when showing results Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 38221 I propose to convert the authority popup search form to a collapsible panel like we have on the patron entry form. It would be expanded when the popup is initially triggered but collapsed when displaying search results. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38221 [Bug 38221] Add Bootstrap styling to pagination in authority plugin search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 173162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173162&action=edit Bug 38227: Collapse authority popup search form when showing results This patch takes the collapsing-panel functionality of the patron entry form and generalizes it so that it can be used on the authority search popup window in cataloging. To test, apply the patch and rebuild the staff interface CSS. - Go to Cataloging -> New record (basic MARC editor) - Switch to tab 1 and click the tag editor link next to tag 100 subfield a. - The search form should be expanded in the pop-up window. - Perform a search. When the window reloads with search results the search form should be collapsed. - Confirm that clicking the "Search options" legend works correctly to expand and collapse the form. - Collapse the form and click the "Clear form" button. The form should expand -- This is based on the assumption that the "Clear form" button would be used when the user wants to initiate a new search. - Go to Patrons -> New patron and confirm that collapsible sections still work correctly. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173162|0 |1 is obsolete| | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 173245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173245&action=edit Bug 38227: Collapse authority popup search form when showing results This patch takes the collapsing-panel functionality of the patron entry form and generalizes it so that it can be used on the authority search popup window in cataloging. To test, apply the patch and rebuild the staff interface CSS. - Go to Cataloging -> New record (basic MARC editor) - Switch to tab 1 and click the tag editor link next to tag 100 subfield a. - The search form should be expanded in the pop-up window. - Perform a search. When the window reloads with search results the search form should be collapsed. - Confirm that clicking the "Search options" legend works correctly to expand and collapse the form. - Collapse the form and click the "Clear form" button. The form should expand -- This is based on the assumption that the "Clear form" button would be used when the user wants to initiate a new search. - Go to Patrons -> New patron and confirm that collapsible sections still work correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- I've just PQAed bug 7508 that has a collapse behaviour as well, but styled totally different. I think they should closer in look. The minimum would be to have "cursor: pointer". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- This change and the one in 7508 should look exactly the same. Could you look again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173245|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176660&action=edit Bug 38227: Collapse authority popup search form when showing results This patch takes the collapsing-panel functionality of the patron entry form and generalizes it so that it can be used on the authority search popup window in cataloging. To test, apply the patch and rebuild the staff interface CSS. - Go to Cataloging -> New record (basic MARC editor) - Switch to tab 1 and click the tag editor link next to tag 100 subfield a. - The search form should be expanded in the pop-up window. - Perform a search. When the window reloads with search results the search form should be collapsed. - Confirm that clicking the "Search options" legend works correctly to expand and collapse the form. - Collapse the form and click the "Clear form" button. The form should expand -- This is based on the assumption that the "Clear form" button would be used when the user wants to initiate a new search. - Go to Patrons -> New patron and confirm that collapsible sections still work correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #4)
This change and the one in 7508 should look exactly the same. Could you look again?
Oops, indeed! Not sure what I missed (certainly a css rebuild). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have tried to rebase this with the auto_rebase.pl script, but there is a conflict in memberentrygen.tt that is not relaeted to the tidy. Could you please have a look? Make sure you have the latest ktd and images, then run: perl misc/devel/auto_rebase.pl --bugzilla 38227 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176660|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178331&action=edit Bug 38227: Collapse authority popup search form when showing results This patch takes the collapsing-panel functionality of the patron entry form and generalizes it so that it can be used on the authority search popup window in cataloging. To test, apply the patch and rebuild the staff interface CSS. - Go to Cataloging -> New record (basic MARC editor) - Switch to tab 1 and click the tag editor link next to tag 100 subfield a. - The search form should be expanded in the pop-up window. - Perform a search. When the window reloads with search results the search form should be collapsed. - Confirm that clicking the "Search options" legend works correctly to expand and collapse the form. - Collapse the form and click the "Clear form" button. The form should expand -- This is based on the assumption that the "Clear form" button would be used when the user wants to initiate a new search. - Go to Patrons -> New patron and confirm that collapsible sections still work correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38227 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org