[Bug 25641] New: Koha/XSLT/Base.t is failing on U20
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Bug ID: 25641 Summary: Koha/XSLT/Base.t is failing on U20 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org kohadev-koha@a72d3d9a1f4d:/kohadevbox/koha$ prove t/db_dependent/Koha/XSLT/Base.t t/db_dependent/Koha/XSLT/Base.t .. 1/33 # Failed test 'Malformed XML warning correctly displayed' # at t/db_dependent/Koha/XSLT/Base.t line 87. # found warning: XSLT::Base: :1: parser error : Opening and ending tag mismatch: a line 0 and b # expected to find warning: (?^u:parser error : Opening and ending tag mismatch: a line 1 and b) # Failed test 'Malformed XML warning correctly displayed' # at t/db_dependent/Koha/XSLT/Base.t line 99. # found warning: XSLT::Base: :1: parser error : Opening and ending tag mismatch: a line 0 and b # expected to find warning: (?^u:parser error : Opening and ending tag mismatch: a line 1 and b) # Failed test 'Malformed XML warning correctly displayed' # at t/db_dependent/Koha/XSLT/Base.t line 104. # found warning: XSLT::Base: :1: parser error : Opening and ending tag mismatch: a line 0 and b # expected to find warning: (?^u:parser error : Opening and ending tag mismatch: a line 1 and b) # Failed test 'Malformed XML warning correctly displayed' # at t/db_dependent/Koha/XSLT/Base.t line 110. # found warning: XSLT::Base: :1: parser error : Opening and ending tag mismatch: a line 0 and b # expected to find warning: (?^u:parser error : Opening and ending tag mismatch: a line 1 and b) # Looks like you failed 4 tests of 33. t/db_dependent/Koha/XSLT/Base.t .. Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/33 subtests Test Summary Report ------------------- t/db_dependent/Koha/XSLT/Base.t (Wstat: 1024 Tests: 33 Failed: 4) Failed tests: 10, 12, 14, 16 Non-zero exit status: 4 Files=1, Tests=33, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.44 cusr 0.04 csys = 0.52 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25640 [Bug 25640] [OMNIBUS] Ubuntu 20.04 support -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 105469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105469&action=edit Bug 25641: Fix Koha/XSLT/Base.t failures on U20 There is a change in the version number. On U20 we get Opening and ending tag mismatch: a line 0 and b On others (D9, D10, U18) we get: Opening and ending tag mismatch: a line 1 and b I did not find where it did come from, so assuming it's just a minor change and won't have side-effects. Test plan: Make sure the tests pass on U20 and another OS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #2 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #1)
Created attachment 105469 [details] [review] Bug 25641: Fix Koha/XSLT/Base.t failures on U20
There is a change in the version number. On U20 we get Opening and ending tag mismatch: a line 0 and b On others (D9, D10, U18) we get: Opening and ending tag mismatch: a line 1 and b
I did not find where it did come from, so assuming it's just a minor change and won't have side-effects.
Test plan: Make sure the tests pass on U20 and another OS
hi, i've seen the same error on deb11 too https://jenkins.koha-community.org/job/Koha_Master_D11/2/ https://jenkins.koha-community.org/job/Koha_Master_D11/2/testReport/junit/(r... not ok 10 - Malformed XML warning correctly displayed ok 11 - Engine returns error on malformed xml not ok 12 - Malformed XML warning correctly displayed ok 13 - Engine respects do_not_return_source==1 not ok 14 - Malformed XML warning correctly displayed ok 15 - Second engine respects it too not ok 16 - Malformed XML warning correctly displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105469|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 105606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105606&action=edit Bug 25641: Fix Koha/XSLT/Base.t failures on U20 There is a change in the version number. On U20 we get Opening and ending tag mismatch: a line 0 and b On others (D9, D10, U18) we get: Opening and ending tag mismatch: a line 1 and b I did not find where it did come from, so assuming it's just a minor change and won't have side-effects. Test plan: Make sure the tests pass on U20 and another OS Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! (U20, D10, D11) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Skipping QA, I want this one pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Is U20 counting lines in a file from 0 now ? Maybe we should just use \d+ ? The line number is not really relevant.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- That's how I fixed it at the beginning. But then it sounded more accurate to test 0|1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- t/db_dependent/Koha/XSLT/Base.t is not in 19.11.x, not backporting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 108622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108622&action=edit Bug 25641: [19.11.x] Fix XSLT_Handler.t failures on U20 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Aleisha Amohia from comment #10)
t/db_dependent/Koha/XSLT/Base.t is not in 19.11.x, not backporting
This test was failing on Koha_19.11_U20 #59 Here is a patch for 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.01 |20.11.00, 20.05.01, released in| |19.11.09 Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported second patch to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25641 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.01, |20.11.00, 20.05.01, released in|19.11.09 |19.11.09, 19.05.15 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.15 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org