[Bug 26000] New: Holiday exceptions are incorrectly cached for an individual branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Bug ID: 26000 Summary: Holiday exceptions are incorrectly cached for an individual branch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When updating exception holidays they are cleared from the cache until Koha::Calendar->exception_holidays is called That routine checks the cache, and then generates the holidays for a single branch and sets them in the cache. This is incorrect. single_holidays handles the situation correctly and exception_holidays should do the same. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 106968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106968&action=edit Bug 26000: Unit test -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 106969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106969&action=edit Bug 26000: Cache all branches for exception_holidays To test: 0 - Have an itemtype rule shared for branch A and B, or same period 1 - Set some holidays for branch A within circ period for an itemtype 2 - Set same holidays, but make some an exception, for branch b 3 - Set useDaysMode to 'Use the calendar to skip days the library is closed' 4 - Checkout an item for branch A, date is pushed forward 5 - Checkout an item for branch B, date is pushed forward? It hsould not be the same as A because fo holiday exception 6 - Apply patch 7 - Restart all 8 - Checkout an item for branch A, date is pushed forward 9 - Checkout an item for branch B, date is not pushed forward -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Lots of overlap here with bug 25723.. might be worth a look 😉 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25723 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 106987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106987&action=edit Bug 26000: [alternate] Make exception_holidays cache with branch in key In light of 25723 offering a simpler solution here. This would just let us avoid backporting larger changes, but this can be marked as a duplicate if 25723 is preferred to this change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 19426 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So this is for stable branches only? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |19.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think bug 25723 is a trivial backport for 20.05, but this patch is still useful for 19.11 and beyond.. I'd be interested to see what the remains do.. if they all choose to backport 25723 then this is entirely a duplicate and can be closed. I'll touch base with them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- I did not backport Bug 25723 to 19.11.x because it was framed as an enhancement. If this patch could be reworked on top of that for 19.11.x, I'd be happy to backport this fix as it sorts a bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106968|0 |1 is obsolete| | Attachment #106969|0 |1 is obsolete| | Attachment #106987|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107746&action=edit Bug 26000: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107747&action=edit Bug 26000: Make exception_holidays cache with branch in key In light of 25723 offering a simpler solution here. This would just let us avoid backporting larger changes, but this can be marked as a duplicate if 25723 is preferred to this change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Aleisha Amohia from comment #8)
I did not backport Bug 25723 to 19.11.x because it was framed as an enhancement. If this patch could be reworked on top of that for 19.11.x, I'd be happy to backport this fix as it sorts a bug.
These apply cleanly to 19.11.x and tests pass - you only need this or 25723, not both. It would be nice to get an SO on this one. Martin, could you check as you wrote the other fix? :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107746|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107762&action=edit Bug 26000: Unit test Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107747|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 107763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107763&action=edit Bug 26000: Make exception_holidays cache with branch in key In light of 25723 offering a simpler solution here. This would just let us avoid backporting larger changes, but this can be marked as a duplicate if 25723 is preferred to this change Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Passing QA Works well and is basically a simplified version of but 25723 for backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sending to oldstable RM queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #16 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26000 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|19.11.09 |19.11.09, 19.05.15 released in| | --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.15 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org