[Bug 15154] New: Allow correct translation for upload local cover image
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Bug ID: 15154 Summary: Allow correct translation for upload local cover image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org CC: bgkriegel@gmail.com, frederic@tamil.fr On intranet catalog detail in tab Image, the way in which the the link is displayed for "Please <a>upload</a> one" for some languages (Spanish my case) does not allow translate properly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Sorry my mistake, the string really works well for translation purpose. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Still can use for a better context in translation The phrase "Please, %upload% one" isn't a good phrase for translation. It is much better something like "Select the image file to upload" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44607&action=edit Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44607|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 44608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44608&action=edit Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Select a bib record without a local cover image -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44608|0 |1 is obsolete| | --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44609&action=edit Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES Signed-off-by: Frederic Demians <f.demians@tamil.fr> A native English speaker could confirm that the wording is ok: Please select the image file to upload -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44609|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44784&action=edit [PASSED QA] Bug 15154 - Allow correct translation for upload local cover image To test: -Set syspref LocalCoverImages and OPACLocalCoverImages to Allow -A new tab 'Images' appear in bib record detail on Intranet. -Notice about the phrase "Please upload one" -Apply the patch and reload the page. -New phrase appear "Select the image file to upload" with button Upload -Update translation files : cd misc/translator; perl translate update es-ES -You will see in es-ES-staff-prog.po the new entry "Select the image file to upload. %sUpload%s" -You can see the result installing the translation cd misc/translator ; perl translate install es-ES Signed-off-by: Frederic Demians <f.demians@tamil.fr> A native English speaker could confirm that the wording is ok: Please select the image file to upload Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Hector! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15154 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |liz@catalyst.net.nz --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org