http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.20 |master OS|Linux |All Hardware|PC |All --- Comment #1 from Marc Véron <veron@veron.ch> --- intranet-error.log says: label-create-pdf.pl: Barcode generation failed for item 11 with this error: Invalid Characters Lines 539 (for COOP2of5 ) and 557 (for INDUSTRIAL2OF5) of C4/Labels/Label.pm surround the value with asterisks, however only digits are allowed. After removing the asterisks the barcodes are generated. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 42378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42378&action=edit Bug 14781 - Creation of barcode types 2of5 not functional This patch fixes the rendering of "COOP2of5" or "Industrial2of5" barcodes in the label creator module. To test: - Create a label layout with COOP2of5 barcode type - Create labels (make sure that the items's barcode values are numeric only!) - Export batch and download PDF. Without patch: - No barcodes rendered With patch - Barcodes should render as expected. Test for both barcode types. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 --- Comment #3 from Michael Kuhn <mik@adminkuhn.ch> --- When removing the asterisks the layout actually renders. Though the resulting barcodes don't really look like barcode type Industrial2of5 or COOP2of5 (see the attachment). To me it looks like the resulting barcodes are formatted like barcode type Code 39 (they apparently have the same length), so I doubt if an ordinary barcode reader would accept these codes. Correct me if I'm wrong. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 --- Comment #5 from Michael Kuhn <mik@adminkuhn.ch> --- Created attachment 42382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42382&action=edit Examples of resulting barcodes (2015-09-03 COOP2of5) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 --- Comment #7 from Michael Kuhn <mik@adminkuhn.ch> --- Yes, I have printed the resulting barcodes. But no, I have no barcode reader at hand, so I couldn't test if the printed barcodes are really COOP2of5 resp. Industrial2of5. They sure look like barcodes but to me they just don't look like I would expect the correct barcode type 2of5 to look like... The barcode numbers have just 8 digits and I think the resulting barcode is far too long... However, I think these barcodes should be tested with an barcode reader. I will try to actually test them on 15 September when I'm at a library which owns an appropriate barcode reader. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 --- Comment #9 from Marc Véron <veron@veron.ch> --- (In reply to Chris Nighswonger from comment #8)

FTR, many of the less commonly used barcode types were simply brought over from the (very) old label code and not were not tested much at all. IIRC some of them may have even been left in a semi-complete state, so checking to be sure the resulting barcodes a) are actually the format they claim to be, and b) actually produce successful scans is imperative.

Chris, using this patch and changing the label dimensions (height) I could produce barcodes that look OK for me (I compared with same barcode values found in the internet). I suppose the problem Michael encounters is due to the hard coded barcode height (0.01 * label height), see related Bug 14149. That said, I would appreciate if somebody could sign off on this patch. Marc -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 --- Comment #11 from Marc Véron <veron@veron.ch> --- (In reply to bondiurbano from comment #10)

Created attachment 42444 [details] Selection links are missing

Thanks for testing, bondiurbano. I suppose you wanted to create pateron cards, not labels? This problem is already described in: Bug 14123 - Patroncard: Patron search for batch no longer has Select / Select All / Add selected http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14123 See attachment 14123: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38773 However, our bug 14781 is about creating labels, not patron cards: Tools > Labels home > Manage label -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 --- Comment #13 from Marc Véron <veron@veron.ch> --- Ping for Signoff :-) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42378|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44002&action=edit [SIGNED-OFF] Bug 14781 - Creation of barcode types 2of5 not functional This patch fixes the rendering of "COOP2of5" or "Industrial2of5" barcodes in the label creator module. To test: - Create a label layout with COOP2of5 barcode type - Create labels (make sure that the items's barcode values are numeric only!) - Export batch and download PDF. Without patch: - No barcodes rendered With patch - Barcodes should render as expected. Test for both barcode types. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, tested both formats. Non digit barcode is not printed. No koha-qa errors, no t/ & xt/ errors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44002|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44459&action=edit [PASSED QA] Bug 14781 - Creation of barcode types 2of5 not functional This patch fixes the rendering of "COOP2of5" or "Industrial2of5" barcodes in the label creator module. To test: - Create a label layout with COOP2of5 barcode type - Create labels (make sure that the items's barcode values are numeric only!) - Export batch and download PDF. Without patch: - No barcodes rendered With patch - Barcodes should render as expected. Test for both barcode types. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works as described, tested both formats. Non digit barcode is not printed. No koha-qa errors, no t/ & xt/ errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Note: To be printed, barcode should be numerical. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #17 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.