[Bug 38033] New: Koha::Biblio->record does not return items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38033 Bug ID: 38033 Summary: Koha::Biblio->record does not return items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: januszop@gmail.com Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 33083 Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward alias for Koha::Biblio::Metadata->record but it does not pass the parameters to $self->metadata->record call. This may lead to misunderstandings and possible bugs. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33083 [Bug 33083] Handle generic collection of records methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38033 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38033 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 172221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172221&action=edit Bug 38033: Koha::Biblio->record does not return items Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward alias for Koha::Biblio::Metadata->record but it does not pass the parameters to $self->metadata->record call. This may lead to misunderstandings and possible bugs. The provided patch corrects this issue. Use unit test to test. Sponsored-by: Ignatianum University in Cracow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38033 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38033 --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Use case: one would expect $biblio->record({ embed_items => 1 }) returns the linked items (as it does $biblio->metadata->record({ embed_items => 1 }) ) -- but unfortunately now it does not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38033 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38033 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172221|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 172237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172237&action=edit Bug 38033: Koha::Biblio->record does not return items Koha::Biblio->record introduced by Bug 33083 seems to be a straigtforward alias for Koha::Biblio::Metadata->record but it does not pass the parameters to $self->metadata->record call. This may lead to misunderstandings and possible bugs. The provided patch corrects this issue. Use unit test to test. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38033 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- This is an interesting one. Probably should have a different title, but looking at the code... it seems pretty reasonable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38033 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- We are headed toward bug 31224 instead of this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38033 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Signed Off |RESOLVED CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #5)
We are headed toward bug 31224 instead of this.
Setting as RESOLVED INVALID. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org