[Bug 27753] New: Automate resolution of return claim when checking in an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Bug ID: 27753 Summary: Automate resolution of return claim when checking in an item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When an item has been marked Claims Returned and is later checked in, it would be good to let Koha automatically resolve that claim. We'd need a way to tell it which resolution status to go to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com --- Comment #1 from Lisette Scheer <lisetteslatah@gmail.com> --- Ideally from a workflow perspective checking in a claim return item would open up the options to set the resolution and update the note if needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- That's a fine idea -- to have the alert at checkin include some interface with which to mark the claim as resolve, rather than just a link to the patron -- but I'm suggesting something wholly automated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #3 from Lisette Scheer <lisetteslatah@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #2)
That's a fine idea -- to have the alert at checkin include some interface with which to mark the claim as resolve, rather than just a link to the patron -- but I'm suggesting something wholly automated.
Ah yes that makes sense. Maybe a sys pref that can say "If a claim return item is checked in on the returns.pl resolve the claim and set it to X resolution?" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us --- Comment #4 from Rebecca Coert <rcoert@arlingtonva.us> ---
Maybe a sys pref that can say "If a claim return item is checked in on the returns.pl resolve the claim and set it to X resolution?"
That's exactly what we'd like to see happen. Fully automated and no staff interaction required. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28271 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28594 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Koha Team University Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #5 from Koha Team University Lyon 3 <koha@univ-lyon3.fr> --- Hi, For me if a book is really returned, the claims retruned note should desappear.
Maybe a sys pref that can say "If a claim return item is checked in on the returns.pl resolve the claim and set it to X resolution?"
I'm Ok for a syspref but it should also be done if the return is done on a selfcheckout system via SIP. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Daniel Gaghan <daniel.gaghan@pueblolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan@pueblolibrary | |.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 cghattas <cghattas@rclstn.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cghattas@rclstn.org --- Comment #6 from cghattas <cghattas@rclstn.org> --- Yes, we would like to see this as an automated resolution in Koha upon check-in by staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 162517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162517&action=edit Bug 27753: Added two new system preferences for automatically resolving claims. NOT READY FOR TESTING Current status: ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162517|0 |1 is obsolete| | --- Comment #8 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163058&action=edit Bug 27753: Added two new system preferences for automatically resolving claims. Bug 27753: Removed syspref code in order to move it over to Circulation.pl Bug: 27753 - Updates to AutoClaimResolutionOnCheckin Bug 27753: Added code for AutoClaimResolutionOnCheckout Bug 27753: Added CLAIM_RESOLUTION alert Bug 27753: Made updates to AutoClaimResolved messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163059&action=edit Bug 27753: Testing - not ready -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163059|0 |1 is obsolete| | --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163060&action=edit Bug 27753: Testing - not ready -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163060|0 |1 is obsolete| | --- Comment #11 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163061&action=edit Bug 27753: Testing - not ready -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163058|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163084&action=edit Bug 27753: Added new system preferences for automatically resolving claims To test: 1. Configure Claims returned 1. Go to Administration > Authorized Values > LOST 2. Add a new authorized value with value:6 and description:Claims returned 3. Go to Administration > System Preferences 4. Set ClaimReturnedLostValue to 6 and save 2. Check out an item to a patron. 1. Mark the item as claim returned 2. Check the item in. 3. A message stating that the item has been claimed as returned pops up with an option to resolve. 4. Resolve the claim. 3. Check out the item to the patron again. 1. Mark the item as claim returned. 2. Check out the item to a new patron. Select “Yes, check out” 3. Go back to the previous patron. Notice that their claim was not resolved. 4. Apply the patch. 1. Updatedatabase 2. restart_all 3. Go to the system preferences and set the system preference ‘AutoClaimReturnStatusOnCheckin’ to ‘Returned by patron’ 4. Set ‘AutoClaimReturnStatusOnCheckout’ to ‘Found in library’ 5. Redo step 2 1. When checking the claim returned item in you will now see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Returned by patron’ 6. Redo step 3 1. Upon checking the item out to another patron you will see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Found in library’. 7. Sign off and have a wonderful day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163061|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163085&action=edit Bug 27753: Adding patch for AutoClaimReturnStatusOnCheckout syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163085|0 |1 is obsolete| | --- Comment #14 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 163090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163090&action=edit Bug 27753: Adding patch for AutoClaimReturnStatusOnCheckout syspref Signed-off-by: Michelle <mspinney@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163084|0 |1 is obsolete| | Attachment #163090|0 |1 is obsolete| | --- Comment #15 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163469&action=edit Bug 27753: Added new system preferences for automatically resolving claims To test: 1. Configure Claims returned 1. Go to Administration > Authorized Values > LOST 2. Add a new authorized value with value:6 and description:Claims returned 3. Go to Administration > System Preferences 4. Set ClaimReturnedLostValue to 6 and save 2. Check out an item to a patron. 1. Mark the item as claim returned 2. Check the item in. 3. A message stating that the item has been claimed as returned pops up with an option to resolve. 4. Resolve the claim. 3. Check out the item to the patron again. 1. Mark the item as claim returned. 2. Check out the item to a new patron. Select “Yes, check out” 3. Go back to the previous patron. Notice that their claim was not resolved. 4. Apply the patch. 1. Updatedatabase 2. restart_all 3. Go to the system preferences and set the system preference ‘AutoClaimReturnStatusOnCheckin’ to ‘Returned by patron’ 4. Set ‘AutoClaimReturnStatusOnCheckout’ to ‘Found in library’ 5. Redo step 2 1. When checking the claim returned item in you will now see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Returned by patron’ 6. Redo step 3 1. Upon checking the item out to another patron you will see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Found in library’. 7. Sign off and have a wonderful day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #16 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163470&action=edit Bug 27753: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163470|0 |1 is obsolete| | --- Comment #17 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163474&action=edit Bug 27753: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #18 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163475&action=edit Bug 27753: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163469|0 |1 is obsolete| | --- Comment #19 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163476&action=edit Bug 27753: Added new system preferences for automatically resolving claims To test: 1. Configure Claims returned 1. Go to Administration > Authorized Values > LOST 2. Add a new authorized value with value:6 and description:Claims returned 3. Go to Administration > System Preferences 4. Set ClaimReturnedLostValue to 6 and save 2. Check out an item to a patron. 1. Mark the item as claim returned 2. Check the item in. 3. A message stating that the item has been claimed as returned pops up with an option to resolve. 4. Resolve the claim. 3. Check out the item to the patron again. 1. Mark the item as claim returned. 2. Check out the item to a new patron. Select “Yes, check out” 3. Go back to the previous patron. Notice that their claim was not resolved. 4. Apply the patch. 1. Updatedatabase 2. restart_all 3. Go to the system preferences and set the system preference ‘AutoClaimReturnStatusOnCheckin’ to ‘Returned by patron’ 4. Set ‘AutoClaimReturnStatusOnCheckout’ to ‘Found in library’ 5. Redo step 2 1. When checking the claim returned item in you will now see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Returned by patron’ 6. Redo step 3 1. Upon checking the item out to another patron you will see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Found in library’. 7. Sign off and have a wonderful day! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163474|0 |1 is obsolete| | Attachment #163475|0 |1 is obsolete| | --- Comment #20 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 163477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163477&action=edit Bug 27753: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163476|0 |1 is obsolete| | --- Comment #21 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 163479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163479&action=edit Bug 27753: Added new system preferences for automatically resolving claims To test: 1. Configure Claims returned 1. Go to Administration > Authorized Values > LOST 2. Add a new authorized value with value:6 and description:Claims returned 3. Go to Administration > System Preferences 4. Set ClaimReturnedLostValue to 6 and save 2. Check out an item to a patron. 1. Mark the item as claim returned 2. Check the item in. 3. A message stating that the item has been claimed as returned pops up with an option to resolve. 4. Resolve the claim. 3. Check out the item to the patron again. 1. Mark the item as claim returned. 2. Check out the item to a new patron. Select “Yes, check out” 3. Go back to the previous patron. Notice that their claim was not resolved. 4. Apply the patch. 1. Updatedatabase 2. restart_all 3. Go to the system preferences and set the system preference ‘AutoClaimReturnStatusOnCheckin’ to ‘Returned by patron’ 4. Set ‘AutoClaimReturnStatusOnCheckout’ to ‘Found in library’ 5. Redo step 2 1. When checking the claim returned item in you will now see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Returned by patron’ 6. Redo step 3 1. Upon checking the item out to another patron you will see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Found in library’. 7. Sign off and have a wonderful day! Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163477|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 163480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163480&action=edit Bug 27753: Unit tests Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #23 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> ---
6. Redo step 3 1. Upon checking the item out to another patron you will see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.”
One small point, this checkout to another patron required a confirmation before Koha would proceed to return it from the one patron and check out to the other. However, the claim resolved immediately, before I responded to the confirmation about the checkout. I can't think of a reason to *not* resolve the claim even if you don't complete the checkout, so I signed off anyway. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Do we need both system preferences introduced here? Could we not rely on just the one for which status to change to.. i.e. if not set don't change, otherwise set to selected status? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. I misread the prefs.. it's one for Checkout and one for Checkin!.. totally misread that first time around.. ignore my previous comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 163479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163479 Bug 27753: Added new system preferences for automatically resolving claims Review of attachment 163479: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27753&attachment=163479) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +2531,5 @@
if ( C4::Context->preference('ClaimReturnedLostValue') ) { + my $autoClaimReturnCheckin = C4::Context->preference('AutoClaimReturnStatusOnCheckin'); + + if ($autoClaimReturnCheckin) {
I think the placement of this statement is wrong.. now it all relies on there being an autoClaimReturnedCheckin status set.. I think we need to move the check for ReturnClaims up outside of this block and trigger the autoResolve or not based on this check only (and the differing return of course) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I also hate to say it, but can we get a unit test for the Circulation.pm change pretty please. This is so close, I'd love to see it over the line for release.. you have a couple of days. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #28 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165911&action=edit Bug 27753: Follow up updates to C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #29 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165912&action=edit Bug 27753: Follow up with updated unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163479|0 |1 is obsolete| | --- Comment #30 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165914&action=edit Bug 27753: Added new system preferences for automatically resolving claims To test: 1. Configure Claims returned 1. Go to Administration > Authorized Values > LOST 2. Add a new authorized value with value:6 and description:Claims returned 3. Go to Administration > System Preferences 4. Set ClaimReturnedLostValue to 6 and save 2. Check out an item to a patron. 1. Mark the item as claim returned 2. Check the item in. 3. A message stating that the item has been claimed as returned pops up with an option to resolve. 4. Resolve the claim. 3. Check out the item to the patron again. 1. Mark the item as claim returned. 2. Check out the item to a new patron. Select “Yes, check out” 3. Go back to the previous patron. Notice that their claim was not resolved. 4. Apply the patch. 1. Updatedatabase 2. restart_all 3. Go to the system preferences and set the system preference ‘AutoClaimReturnStatusOnCheckin’ to ‘Returned by patron’ 4. Set ‘AutoClaimReturnStatusOnCheckout’ to ‘Found in library’ 5. Redo step 2 1. When checking the claim returned item in you will now see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Returned by patron’ 6. Redo step 3 1. Upon checking the item out to another patron you will see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Found in library’. 7. Sign off and have a wonderful day! Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163480|0 |1 is obsolete| | --- Comment #31 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165915&action=edit Bug 27753: Unit tests Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165911|0 |1 is obsolete| | --- Comment #32 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165916&action=edit Bug 27753: Follow up updates to C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165912|0 |1 is obsolete| | --- Comment #33 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165917&action=edit Bug 27753: Follow up with updated unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #34 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165918&action=edit Bug 27753: Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #35 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165919&action=edit Bug 27753: Tidy Circulation.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #36 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165920&action=edit Bug 27753: Tidy unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165952&action=edit Bug 27753: (QA follow-up) Check that item exists before using it We're actioning the change of claim status outside of any block that checks the $item exists. As such we'll want to add that check in here. I did consider that this should live inside AddIssue, but on reflection the librarian may want to not proceed with the issue given other return values from the CanBookBeIssued call, but you still want the AutoClaimReturn to fire regardless as you've now found the item. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165953&action=edit Bug 27753: (QA follow-up) Improve unit tests This patch adds unit tests that test the functionality more specifically and adds a few notes/fixme for things we need to consider here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165958&action=edit Bug 27753: Further unit tests highlighting possible issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 165959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165959&action=edit Bug 27753: Example of how we might set to librarian instead of patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. I'm happy to tidy up here and get this over the line.. however, I have some questions. 1) In AddReturn, was it deliberate to use 'patron from last checkout' as the 'resolved_by'.. or should that be the librarian performing the return action? (Remember in both cases this could be undefined.. if we use 'librarian' then we can get that from the userenv of the session.. this "should" always be set these days.. if we are using the patron then the checkout may have already been marked at completed in which case the relation accessor will fail and you won't have a patron and the call to resolve will fail. 2) Should we be handling the lost_item_status in any way? In the interactive approach we give the librarian the option to set a new lost item status (and the resolve method accepts said status if passed).. should we be setting that here too.. or is that perhaps another bug? 3) Checkout functionality suffers from the same questions as above? 4) I tend to like subtests to be a little more self-contained with a database transaction and rollback rather than relying on other test data defined earlier in the test.. I stuck to how you started the tests here but as a future point it may be a good practice if you can to make them more isolated. I'm failing QA for now, but will happily continue to support in getting this over the line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #42 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #41)
OK.. I'm happy to tidy up here and get this over the line.. however, I have some questions.
1) In AddReturn, was it deliberate to use 'patron from last checkout' as the 'resolved_by'.. or should that be the librarian performing the return action? (Remember in both cases this could be undefined.. if we use 'librarian' then we can get that from the userenv of the session.. this "should" always be set these days.. if we are using the patron then the checkout may have already been marked at completed in which case the relation accessor will fail and you won't have a patron and the call to resolve will fail.
---Ack. For logging purposes I believe it would be useful to use the 'librarian'.
2) Should we be handling the lost_item_status in any way? In the interactive approach we give the librarian the option to set a new lost item status (and the resolve method accepts said status if passed).. should we be setting that here too.. or is that perhaps another bug?
--- Let's file a follow-up bug for this.
3) Checkout functionality suffers from the same questions as above?
4) I tend to like subtests to be a little more self-contained with a database transaction and rollback rather than relying on other test data defined earlier in the test.. I stuck to how you started the tests here but as a future point it may be a good practice if you can to make them more isolated.
--- Thank you for the feedback on unit tests! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165914|0 |1 is obsolete| | Attachment #165915|0 |1 is obsolete| | Attachment #165916|0 |1 is obsolete| | Attachment #165917|0 |1 is obsolete| | Attachment #165918|0 |1 is obsolete| | Attachment #165919|0 |1 is obsolete| | Attachment #165920|0 |1 is obsolete| | Attachment #165952|0 |1 is obsolete| | Attachment #165953|0 |1 is obsolete| | Attachment #165958|0 |1 is obsolete| | Attachment #165959|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166128&action=edit Bug 27753: Added new system preferences for automatically resolving claims To test: 1. Configure Claims returned 1. Go to Administration > Authorized Values > LOST 2. Add a new authorized value with value:6 and description:Claims returned 3. Go to Administration > System Preferences 4. Set ClaimReturnedLostValue to 6 and save 2. Check out an item to a patron. 1. Mark the item as claim returned 2. Check the item in. 3. A message stating that the item has been claimed as returned pops up with an option to resolve. 4. Resolve the claim. 3. Check out the item to the patron again. 1. Mark the item as claim returned. 2. Check out the item to a new patron. Select “Yes, check out” 3. Go back to the previous patron. Notice that their claim was not resolved. 4. Apply the patch. 1. Updatedatabase 2. restart_all 3. Go to the system preferences and set the system preference ‘AutoClaimReturnStatusOnCheckin’ to ‘Returned by patron’ 4. Set ‘AutoClaimReturnStatusOnCheckout’ to ‘Found in library’ 5. Redo step 2 1. When checking the claim returned item in you will now see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Returned by patron’ 6. Redo step 3 1. Upon checking the item out to another patron you will see a message that says “The previously claimed returned item has been found, automatically resolving the associated claim.” 2. View the previous patron. Their claim has automatically been resolved with a status of ‘Found in library’. 7. Sign off and have a wonderful day! Sponsored-by: Altadena Library District Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166129&action=edit Bug 27753: Unit tests Add unit tests for new logic introduced to C4::Circulation::AddReturn Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166130&action=edit Bug 27753: (follow-up) Update logic in AddReturn The new logic in AddReturn was flawed, we were missing return messages due to moving the if statement too high and catching more code than intended. Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166131&action=edit Bug 27753: (follow-up) Tidy introduced code in Circulation.pm Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166132&action=edit Bug 27753: (follow-up) Tidy new code in circulation.pl Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166133&action=edit Bug 27753: (follow-up) Tidy unit tests Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166134&action=edit Bug 27753: (QA follow-up) Check that item exists before using it We're actioning the change of claim status outside of any block that checks the $item exists. As such we'll want to add that check in here. I did consider that this should live inside AddIssue, but on reflection the librarian may want to not proceed with the issue given other return values from the CanBookBeIssued call, but you still want the AutoClaimReturn to fire regardless as you've now found the item. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166135&action=edit Bug 27753: (QA follow-up) Improve unit tests This patch adds unit tests that test the functionality more specifically and adds a few notes/fixme for things we need to consider here Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166136&action=edit Bug 27753: (QA follow-up) Enhance unit tests This patch further unit tests highlighting possible issues Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166137&action=edit Bug 27753: (QA follow-up) Use librarian as resolver This patch updates the changed code to set the logged in librarian as the person who resolved the return claim at checkin/checkout action. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work, nice golfing with you Laura. So.. in that final QA run I fixed up a few commit messages and added the sponsor details to the first commit for you. It's all looking great now. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed some tiny things before pushing: 1) + bug_number => "BUG_27753", Needs to be just the numerical bug number. 2) Updates preference description to show the authorized value code following the existing pattern: git grep authorised_values.pl *.pref Some notes: I feel like the preference name is not very easy to understand. It took me a few reads. Maybe instead of AutoClaimREturnStatusOnCheckin we could have used something like AutoResolveReturnClaimOnCheckin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 [Bug 27919] Split claims return from LOST -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette.scheer@bywatersolut | |ions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds two new release notes| |system preferences, | |‘AutoClaimReturnStatusOnChe | |ckin’ and | |‘AutoClaimReturnStatusOnChe | |ckout’, to allow automatic | |resolution of return claims | |on checkin and/or on | |checkout of the item | |claimed as returned. Both | |system preferences allow | |choosing between "Found in | |library" or "Returned by | |patron" as reasons for the | |resolution. The default | |value for both preferences | |is empty, meaning automatic | |resolution on | |checkin/checkout is turned | |off by default. CC| |philip.orr@lmscloud.de Status|Pushed to main |Needs documenting Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |Pushed to main Text to go in the|This patch adds two new |This patch adds two new release notes|system preferences, |system preferences, |‘AutoClaimReturnStatusOnChe |‘AutoClaimReturnStatusOnChe |ckin’ and |ckin’ and |‘AutoClaimReturnStatusOnChe |‘AutoClaimReturnStatusOnChe |ckout’, to allow automatic |ckout’, to allow automatic |resolution of return claims |resolution of return claims |on checkin and/or on |on checkin and/or on |checkout of the item |checkout of the item |claimed as returned. Both |claimed as returned. Both |system preferences allow |system preferences allow |choosing between "Found in |choosing between "Found in |library" or "Returned by |library" or "Returned by |patron" as reasons for the |patron" as reasons for the |resolution. The default |resolution. The default |value for both preferences |value for both preferences |is empty, meaning automatic |is empty, meaning automatic |resolution on |resolution on |checkin/checkout is turned |checkin/checkout is turned |off by default. |off by default. | | | |**Sponsored by** *Altadena | |Library District* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #56 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37408 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/966 CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27753 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38246 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38246 [Bug 38246] If using automatic return claim resolution on checkout, each checkout will overwrite the previous resolution -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org