[Bug 27683] New: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Bug ID: 27683 Summary: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl C4::Items::GetAnalyticsCount is part of the easy analytics feature. Like Bug 20702 make early return when the system preference EasyAnalyticalRecords is disabled. Actually it may block an item deletion for wrong reason. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22140, 20702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702 [Bug 20702] Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 [Bug 22140] More use of EasyAnalyticalRecords pref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 116767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116767&action=edit Bug 27683: Unit test for GetAnalyticsCount Run prove t/db_dependent/Items/GetAnalyticsCount.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 116768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116768&action=edit Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref C4::Items::GetAnalyticsCount is part of the easy analytics feature. Like Bug 20702 make early return when the system preference EasyAnalyticalRecords is disabled. Actually it may block an item deletion for wrong reason. Test plan : 1) Dont apply patch 2) Build an item and a linked analytical record with 773$0 and $9 3) Enable EasyAnalyticalRecords 4) Try to delete the item 5) You have an alert because linked to analytics 6) Disable EasyAnalyticalRecords 7) Try to delete the item 8) You have an alert because linked to analytics 9) Apply patch 10) Try to delete the item 11) No alert, it works :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 116769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116769&action=edit Bug 27683: Impact on catalogue/detail.pl Since EasyAnalyticalRecords pref is now in GetAnalyticsCount, remove test in catalogue/detail.pl. Test plan : 1) Build an item and a linked analytical record with 773$0 and $9 2) Go to record detail page 3) Enable EasyAnalyticalRecords 4) You see analytics tab and analytical count on item 5) Disable EasyAnalyticalRecords 6) You dont see analytics tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116767|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 127839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127839&action=edit Bug 27683: Unit test for GetAnalyticsCount Run prove t/db_dependent/Items/GetAnalyticsCount.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116768|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 127840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127840&action=edit Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref C4::Items::GetAnalyticsCount is part of the easy analytics feature. Like Bug 20702 make early return when the system preference EasyAnalyticalRecords is disabled. Actually it may block an item deletion for wrong reason. Test plan : 1) Dont apply patch 2) Build an item and a linked analytical record with 773$0 and $9 3) Enable EasyAnalyticalRecords 4) Try to delete the item 5) You have an alert because linked to analytics 6) Disable EasyAnalyticalRecords 7) Try to delete the item 8) You have an alert because linked to analytics 9) Apply patch 10) Try to delete the item 11) No alert, it works :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116769|0 |1 is obsolete| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 127841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127841&action=edit Bug 27683: Impact on catalogue/detail.pl Since EasyAnalyticalRecords pref is now in GetAnalyticsCount, remove test in catalogue/detail.pl. Test plan : 1) Build an item and a linked analytical record with 773$0 and $9 2) Go to record detail page 3) Enable EasyAnalyticalRecords 4) You see analytics tab and analytical count on item 5) Disable EasyAnalyticalRecords 6) You dont see analytics tab -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127839|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 137447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137447&action=edit Bug 27683: Unit test for GetAnalyticsCount Run prove t/db_dependent/Items/GetAnalyticsCount.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127840|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 137448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137448&action=edit Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref C4::Items::GetAnalyticsCount is part of the easy analytics feature. Like Bug 20702 make early return when the system preference EasyAnalyticalRecords is disabled. Actually it may block an item deletion for wrong reason. Test plan : 1) Dont apply patch 2) Build an item and a linked analytical record with 773$0 and $9 3) Enable EasyAnalyticalRecords 4) Try to delete the item 5) You have an alert because linked to analytics 6) Disable EasyAnalyticalRecords 7) Try to delete the item 8) You have an alert because linked to analytics 9) Apply patch 10) Try to delete the item 11) No alert, it works :D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127841|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 137449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137449&action=edit Bug 27683: Impact on catalogue/detail.pl Since EasyAnalyticalRecords pref is now in GetAnalyticsCount, remove test in catalogue/detail.pl. Test plan : 1) Build an item and a linked analytical record with 773$0 and $9 2) Go to record detail page 3) Enable EasyAnalyticalRecords 4) You see analytics tab and analytical count on item 5) Disable EasyAnalyticalRecords 6) You dont see analytics tab Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137447|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137700&action=edit Bug 27683: Unit test for GetAnalyticsCount Run prove t/db_dependent/Items/GetAnalyticsCount.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137448|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137701&action=edit Bug 27683: Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref C4::Items::GetAnalyticsCount is part of the easy analytics feature. Like Bug 20702 make early return when the system preference EasyAnalyticalRecords is disabled. Actually it may block an item deletion for wrong reason. Test plan : 1) Dont apply patch 2) Build an item and a linked analytical record with 773$0 and $9 3) Enable EasyAnalyticalRecords 4) Try to delete the item 5) You have an alert because linked to analytics 6) Disable EasyAnalyticalRecords 7) Try to delete the item 8) You have an alert because linked to analytics 9) Apply patch 10) Try to delete the item 11) No alert, it works :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137449|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137702&action=edit Bug 27683: Impact on catalogue/detail.pl Since EasyAnalyticalRecords pref is now in GetAnalyticsCount, remove test in catalogue/detail.pl. Test plan : 1) Build an item and a linked analytical record with 773$0 and $9 2) Go to record detail page 3) Enable EasyAnalyticalRecords 4) You see analytics tab and analytical count on item 5) Disable EasyAnalyticalRecords 6) You dont see analytics tab Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great to see these old routines getting a little love and cleanup, thanks Fridolin.. Tests added, tidy up works as expected.. history confirmed. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Greaaaaaate thanks to all. This was a huge performance issue for some cases. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pleaaaaaaaaaase backport to 22.05 and 21.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.11.00 |22.11.00, 22.05.05 released in| | --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.05 |22.11.00, 22.05.05, released in| |21.11.12 --- Comment #18 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx pushed to 21.11.x for 21.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37964 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org