[Bug 22140] New: More use of EasyAnalyticalRecords pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Bug ID: 22140 Summary: More use of EasyAnalyticalRecords pref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Target Milestone: --- Like Bug 20702 defined GetHostItemsInfo does nothing if EasyAnalyticalRecords pref is disabled, there are other places where code must be dependant on this pref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20702 [Bug 20702] Bind results of GetHostItemsInfo to the EasyAnalyticalRecords pref -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19279 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 84060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84060&action=edit Bug 22140: More use of EasyAnalyticalRecords pref Like Bug 20702 defined GetHostItemsInfo does nothing if EasyAnalyticalRecords pref is disabled, there are other places where code must be dependant on this pref. Test plan : 1) Build an analitical record with 773$0 and $9 2) Enable EasyAnalyticalRecords 3) Don't apply patch 4) Go to OPAC 5) Perform a search that displays the record, check there is the linked item 6) Open record detail page, check there is the linked item 7) Apply patch and redo 5) and 6) 8) Disable EasyAnalyticalRecords 9) redo 5) and 6), you should not see the linked item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 helene <hickeyhe@wgc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hickeyhe@wgc.school.nz Status|Needs Signoff |Failed QA --- Comment #2 from helene <hickeyhe@wgc.school.nz> --- We restarted memcached and plack and the link still did not disappear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to helene from comment #2)
We restarted memcached and plack and the link still did not disappear.
Sorry could you describe more please ? Where does the test plan fail ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- If memory serves there's some fun to be had regarding the EasyAnalytics and the UseControlNumber preferences around this code.. you may (or may not) want to investiage that preference a little further too before making this change. I do however like the general idea here.. tidying up a little. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also.. looking at the original diff (https://github.com/Koha-Community/Koha/commit/f09e2ca27ee89860dbdd0ca512735f...) of the EasyAnalytics submission, it looks like this could go futher. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I raise to major importance because its impact on display is very strange and difficult to debug. @Martin you mean your OK with the patch ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84060|0 |1 is obsolete| | --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 84820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84820&action=edit Bug 22140: Use of EasyAnalyticalRecords pref in search Like Bug 20702 defined GetHostItemsInfo does nothing if EasyAnalyticalRecords pref is disabled, there are other places where code must be dependant on this pref. Test plan : 1) Build an analitical record with 773$0 and $9 2) Enable EasyAnalyticalRecords 3) Don't apply patch 4) Go to OPAC 5) Perform a search that displays the record, check there is the linked item 6) Open record detail page, check there is the linked item 7) Apply patch and redo 5) and 6) 8) Disable EasyAnalyticalRecords 9) redo 5) and 6), you should not see the linked item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 84822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84822&action=edit Bug 22140: Use of EasyAnalyticalRecords pref is get_hostitemnumbers_of Like Bug 20702 defined GetHostItemsInfo does nothing if EasyAnalyticalRecords pref is disabled, get_hostitemnumbers_of must be dependant on this pref too. Test plan : 1) Build an analytical record with 773$0 and $9 2) Enable EasyAnalyticalRecords 4) Place an hold on the record 5) => You see the linked item 6) Disable EasyAnalyticalRecords 7) Place an hold on the record 8) => You dont see the linked item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Found a new method missing the syspref check. I try to create a UT on get_hostitemnumbers_of but its hard since it uses db biblio and items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 84828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84828&action=edit Bug 22140: Larger unit test for get_hostitemnumbers_of Add syspref EasyAnalyticalRecords impact in unit test for get_hostitemnumbers_of Test plan : Run t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Piouf I did it in the end in Items.t in addition to existing test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84820|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84958&action=edit Bug 22140: Use of EasyAnalyticalRecords pref in search Like Bug 20702 defined GetHostItemsInfo does nothing if EasyAnalyticalRecords pref is disabled, there are other places where code must be dependant on this pref. Test plan : 1) Build an analitical record with 773$0 and $9 2) Enable EasyAnalyticalRecords 3) Don't apply patch 4) Go to OPAC 5) Perform a search that displays the record, check there is the linked item 6) Open record detail page, check there is the linked item 7) Apply patch and redo 5) and 6) 8) Disable EasyAnalyticalRecords 9) redo 5) and 6), you should not see the linked item Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84822|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84959&action=edit Bug 22140: Use of EasyAnalyticalRecords pref is get_hostitemnumbers_of Like Bug 20702 defined GetHostItemsInfo does nothing if EasyAnalyticalRecords pref is disabled, get_hostitemnumbers_of must be dependant on this pref too. Test plan : 1) Build an analytical record with 773$0 and $9 2) Enable EasyAnalyticalRecords 4) Place an hold on the record 5) => You see the linked item 6) Disable EasyAnalyticalRecords 7) Place an hold on the record 8) => You dont see the linked item Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84828|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 84960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84960&action=edit Bug 22140: Larger unit test for get_hostitemnumbers_of Add syspref EasyAnalyticalRecords impact in unit test for get_hostitemnumbers_of Test plan : Run t/db_dependent/Items.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry it took me a while to test this after you mentioned it, I wanted to give it my due attention. Looks good and works as expected for me with no regressions that I can see. Signing Off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84958|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 85143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85143&action=edit Bug 22140: Use of EasyAnalyticalRecords pref in search Like Bug 20702 defined GetHostItemsInfo does nothing if EasyAnalyticalRecords pref is disabled, there are other places where code must be dependant on this pref. Test plan : 1) Build an analitical record with 773$0 and $9 2) Enable EasyAnalyticalRecords 3) Don't apply patch 4) Go to OPAC 5) Perform a search that displays the record, check there is the linked item 6) Open record detail page, check there is the linked item 7) Apply patch and redo 5) and 6) 8) Disable EasyAnalyticalRecords 9) redo 5) and 6), you should not see the linked item Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84959|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 85144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85144&action=edit Bug 22140: Use of EasyAnalyticalRecords pref is get_hostitemnumbers_of Like Bug 20702 defined GetHostItemsInfo does nothing if EasyAnalyticalRecords pref is disabled, get_hostitemnumbers_of must be dependant on this pref too. Test plan : 1) Build an analytical record with 773$0 and $9 2) Enable EasyAnalyticalRecords 4) Place an hold on the record 5) => You see the linked item 6) Disable EasyAnalyticalRecords 7) Place an hold on the record 8) => You dont see the linked item Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84960|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 85145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85145&action=edit Bug 22140: Larger unit test for get_hostitemnumbers_of Add syspref EasyAnalyticalRecords impact in unit test for get_hostitemnumbers_of Test plan : Run t/db_dependent/Items.t Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 [Bug 21971] TestBuilder::build_sample_item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This was a "fun" backport.. had to backport the build_sample_* tree for t/lib/TestBuilder too... shout if you need a had with that subsequent rmaints.. hopefully I've taken the edge off it if you do decide to backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22416 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22416 [Bug 22416] Search.t tests need adjustment for EasyAnalyticRecords syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- cant cleanly apply this to 18.05.x. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Bug 22140 depends on bug 21971, which changed state. Bug 21971 Summary: TestBuilder::build_sample_item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27683 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27683 [Bug 27683] Bind results of GetAnalyticsCount to the EasyAnalyticalRecords pref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37964 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org