[Bug 42723] New: Purchase suggestion 500 when EmailPurchaseSuggestions is set to BranchEmailAddress
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Bug ID: 42723 Summary: Purchase suggestion 500 when EmailPurchaseSuggestions is set to BranchEmailAddress Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Set EmailPurchaseSuggestions to BranchEmailAddress. 2. Make a purchase suggestion 3. Be sure to set the branchcode ( "Library:" ) to 'Any' 4. 500 error Can't call method "inbound_email_address" on an undefined value at /kohadevbox/koha/Koha/Suggestion.pm line 107 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39721 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 [Bug 39721] Remove GetSuggestion from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 --- Comment #1 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 199723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199723&action=edit Bug 42723: Purchase suggestion 500 when EmailPurchaseSuggestions is set to BranchEmailAddress Testing plan: - Set EmailPurchaseSuggestions to BranchEmailAddress - Go to create suggestion on the staff side /suggestion/suggestion.pl?op=add_form - Create a suggestion with Library: Any - 500 error: inbound_email_address is not a method of undef - Apply patch & repeat - Suggestion created -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu Assignee|koha-bugs@lists.koha-commun |ephetteplace@cca.edu |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Eric Phetteplace <ephetteplace@cca.edu> --- `prove t/db_dependent/Suggestions.t` should also pass The tests took a while to get passing and might not be formatted the best. They have to increment every other line checking for a specific message in the EmailPurchaseSuggestions subtest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 199724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199724&action=edit Bug 42723: Purchase suggestion 500 when EmailPurchaseSuggestions is set to BranchEmailAddress Testing plan: - Set EmailPurchaseSuggestions to BranchEmailAddress - Go to create suggestion on the staff side /suggestion/suggestion.pl?op=add_form - Create a suggestion with Library: Any - 500 error: inbound_email_address is not a method of undef - Apply patch & repeat - Suggestion created Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Purchase suggestion 500 |Purchase suggestion 500 |when |page error when |EmailPurchaseSuggestions is |EmailPurchaseSuggestions is |set to BranchEmailAddress |set to "email address of | |library" CC| |david@davidnind.com Text to go in the| |This fixes a 500 page release notes| |error[1] when creating a | |suggestion in the staff | |interface if: | |- the | |EmailPurchaseSuggestions | |system preference is set to | |"email address of library", | |and | |- the library for | |acquisition information is | |set to "Any". | | | |[1] Can't call method | |"inbound_email_address" on | |an undefined value at | |/kohadevbox/koha/Koha/Sugge | |stion.pm line 107 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Keywords| |rel_25_11_candidate, | |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |nick@bywatersolutions.com --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- I don't understand what caused this regression on bug 39721. Did you find out, Eric? Also is that expected to not send an email at all if EmailPurchaseSuggestions=BranchEmailAddress and branchcode=Any? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I don't think this is caused by Bug 42723, I can reproduce it on 24.11.x. However this looks like it was less visible before. The regression caused by the bug is Bug 42710 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 --- Comment #6 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I don't think this is caused by Bug 39721, I can reproduce it on 24.11.x. However this looks like it was less visible before. The regression caused by the bug is Bug 42710 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #4)
I don't understand what caused this regression on bug 39721. Did you find out, Eric?
Also is that expected to not send an email at all if EmailPurchaseSuggestions=BranchEmailAddress and branchcode=Any?
I think one could argue both ways. If we want to send an email we could fall back to the KohaAdminEmailAdress, but if there is no library complaining, no email might be best for now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 --- Comment #8 from Eric Phetteplace <ephetteplace@cca.edu> --- I debated where the email should go myself. Right now, a message with to_address undef is enqueued, and since borrowernumber is also pased as undef to EnqueueLetter(), I believe that means no mail is sent. One could argue it should fallback to KohaAdminEmailAddress or ReplytoDefault. I'm not sure what a library using BranchEmailAddress would expect in this situation. I agree leaving it be and seeing if libraries complain may be the best solution. They can always pick a branch if they want an email sent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 --- Comment #9 from Eric Phetteplace <ephetteplace@cca.edu> --- I suppose that begs the question, if nothing's going to be sent does it make sense to be enqueueing the message? Perhaps I should add an `if ($toaddress)` condition before calling EnqueueLetter()? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|39721 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39721 [Bug 39721] Remove GetSuggestion from C4/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199724|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 199845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199845&action=edit Bug 42723: Purchase suggestion 500 when EmailPurchaseSuggestions is set to BranchEmailAddress Testing plan: - Set EmailPurchaseSuggestions to BranchEmailAddress - Go to create suggestion on the staff side /suggestion/suggestion.pl?op=add_form - Create a suggestion with Library: Any - 500 error: inbound_email_address is not a method of undef - Apply patch & repeat - Suggestion created Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 --- Comment #11 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.06 released in| | --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.06 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|26.11.00,26.05.01,25.11.06 |26.11.00,26.05.01,25.11.06, released in| |25.05.12 --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Backported to 25.05.x for 25.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01,25.11.06, |26.11.00,26.05.01,25.11.06, released in|25.05.12 |25.05.12,24.11.18 CC| |fridolin.somers@biblibre.co | |m Status|Pushed to oldoldstable |Pushed to oldoldoldstable --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42723 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Keywords|rel_25_11_candidate, | |rel_26_05_candidate | Status|Needs documenting |RESOLVED --- Comment #16 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org