[Bug 42130] New: Holdings created in ERM with a linked bibliographic record do not link to the record, nor is the record indexed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Bug ID: 42130 Summary: Holdings created in ERM with a linked bibliographic record do not link to the record, nor is the record indexed Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@openfifth.co.uk, martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, pedro.amorim@openfifth.co.uk To test: 1 - Enable ERMModule 2 - Go to ERM 3 - eHoldings->Titles 4 - New title 5 - Populate the form 6 - Check the create bibliographic record box 7 - Save 8 - No link to record 9 - Check the background jobs, no index job queued 10 - You can find the title in the DB, but it is not findable in the interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
From the commit message:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- The link is done in the DB title_id: 1 biblio_id: 439 However the biblio is indeed not indexed. Because of: commit d2820f57d6a738786a243e558e43ba640eaf7165 Bug 34788: (QA follow-up) Koha/ERM/EHoldings/Title.pm - C4::Biblio::ModBiblio( $record, $self->biblio_id, '' ); + C4::Biblio::ModBiblio( $record, $self->biblio_id, '', { skip_record_index => 1 } ); 2) The background job now uses skip_record_index to avoid queuing indexing jobs for every new biblio and instead queues one job at the end -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 [Bug 34788] Add the ability to import KBART files to ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
From the commit message:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 195678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195678&action=edit Bug 42130: ERM - Index biblio when local title is created/updated The indexation step has been removed by commit d2820f57d6a738786a243e558e43ba640eaf7165 Bug 34788: (QA follow-up) Koha/ERM/EHoldings/Title.pm - C4::Biblio::ModBiblio( $record, $self->biblio_id, '' ); + C4::Biblio::ModBiblio( $record, $self->biblio_id, '', { skip_record_index => 1 } ); 2) The background job now uses skip_record_index to avoid queuing indexing jobs for every new biblio and instead queues one job at the end it's then missing when we add or edit a local title. Test plan: 1 - Enable ERMModule 2 - Go to ERM 3 - eHoldings->Titles 4 - New title 5 - Populate the form 6 - Check the create bibliographic record box 7 - Save => Confirm that the biblio is now indexed 8. Edit the title, modify a value, tick the box, save => Confirm that the biblio is now indexed with the new value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195678|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
From the commit message:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 195683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195683&action=edit Bug 42130: ERM - Index biblio when local title is created/updated The indexation step has been removed by commit d2820f57d6a738786a243e558e43ba640eaf7165 Bug 34788: (QA follow-up) Koha/ERM/EHoldings/Title.pm - C4::Biblio::ModBiblio( $record, $self->biblio_id, '' ); + C4::Biblio::ModBiblio( $record, $self->biblio_id, '', { skip_record_index => 1 } ); 2) The background job now uses skip_record_index to avoid queuing indexing jobs for every new biblio and instead queues one job at the end it's then missing when we add or edit a local title. Test plan: 1 - Enable ERMModule 2 - Go to ERM 3 - eHoldings->Titles 4 - New title 5 - Populate the form 6 - Check the create bibliographic record box 7 - Save => Confirm that the biblio is now indexed 8. Edit the title, modify a value, tick the box, save => Confirm that the biblio is now indexed with the new value Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Reproduce the issue (as per the description). 2. Apply the patch 3. Rebuild things: yarn build 4. Restart everything: restart_all 5. As per the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- This all works, but it still does not provide a link for the user to go to the bibliographic record - is this possible? I think I was not clear about the missing link? It is linked in the DB, but not hyperlinked in the interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Summary|Holdings created in ERM |Holdings created in ERM |with a linked bibliographic |with a linked bibliographic |record do not link to the |record does not index the |record, nor is the record |record |indexed | --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Nick Clemens (kidclamp) from comment #5)
This all works, but it still does not provide a link for the user to go to the bibliographic record - is this possible?
I think I was not clear about the missing link? It is linked in the DB, but not hyperlinked in the interface
I would suggest to open a separate bug report. This patch fixes a bug and the other request seems like an enhancement. Where would you like to add the new link? Within the "Update linked bibliographic record" block? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42522 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #195683|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
From the commit message:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 199495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199495&action=edit Bug 42130: ERM - Index biblio when local title is created/updated The indexation step has been removed by commit d2820f57d6a738786a243e558e43ba640eaf7165 Bug 34788: (QA follow-up) Koha/ERM/EHoldings/Title.pm - C4::Biblio::ModBiblio( $record, $self->biblio_id, '' ); + C4::Biblio::ModBiblio( $record, $self->biblio_id, '', { skip_record_index => 1 } ); 2) The background job now uses skip_record_index to avoid queuing indexing jobs for every new biblio and instead queues one job at the end it's then missing when we add or edit a local title. Test plan: 1 - Enable ERMModule 2 - Go to ERM 3 - eHoldings->Titles 4 - New title 5 - Populate the form 6 - Check the create bibliographic record box 7 - Save => Confirm that the biblio is now indexed 8. Edit the title, modify a value, tick the box, save => Confirm that the biblio is now indexed with the new value Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 --- Comment #8 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes indexing of release notes| |records, so that when a new | |title is added in the ERM | |module (ERM > eHoldings > | |Local > Titles) and 'Create | |bibliographic record' is | |selected, the new record | |can be found when | |searching. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.01 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01 |26.11.00,26.05.01,25.11.05 released in| | CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Pushed into 25.11.x for 25.11.05 nice work everyone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01,25.11.05 |26.11.00,26.05.01,25.11.06 released in| | --- Comment #11 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- EDIT: pushed to 25.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |wainuiwitikapark@catalyst.n | |et.nz Version(s)|26.11.00,26.05.01,25.11.06 |26.11.00,26.05.01,25.11.06, released in| |25.05.12 --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Backported to 25.05.x for 25.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00,26.05.01,25.11.06, |26.11.00,26.05.01,25.11.06, released in|25.05.12 |25.05.12,24.11.18 Status|Pushed to oldoldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42130 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #14 from David Nind <david@davidnind.com> --- Bug fix, no update to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org