[Bug 21406] New: Not adding author to request can cause JS errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Bug ID: 21406 Summary: Not adding author to request can cause JS errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com If an ILL request does not contain an author, when viewing the ILL requests table, the following errors are displayed by Datatables: DataTables warning: table id=ill-requests - Requested unknown parameter 'metadata_Author' for row 0, column 0. For more information about this error, please see http://datatables.net/tn/4 DataTables warning: table id=ill-requests - Requested unknown parameter 'metadata_Author' for row 358, column 0. For more information about this error, please see http://datatables.net/tn/4 We need better handling of requests without populated author in the JS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens@lancasterseminar | |y.edu --- Comment #1 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- +1 Agreed. I have noticed that the table that generates in the OPAC view adds 'N/A' to the author field. Perhaps the JS for the staff client table could be amended to insert "N/A" when the author field is absent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- I'm not actually seeing this any more on master. There have been a lot of changes to both the ILL template and the associated JS since this bug was created, so it's highly likely it was fixed. I've looked through the commits to try and identify where it was fixed, but there are so many and some are so far reaching that I gave up. Suffice it to say, this is now fixed! I'll mark this bug "Resolved" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #3 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- We are on 18.11.08 with the Free Form backend and are experiencing this error. Would it be possible to still get a patch backported to 18.11.x? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #4 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Nick Clemens tracked it down to bug 18589, which made it to 19.05 and won't be backported to 18.11.x. Our library is scheduled to be upgraded to 19.05 in about 2 months, so we will just wait. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- CC| |nick@bywatersolutions.com Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |18.11 Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92608&action=edit Bug 21406: [18.11.x only] Prevent errors from undefined fields in requests To test: 1 - In 18.11 enable ILL and install the freeform backend 2 - Create a request for 'Journal article' 3 - Note there is no 'Author' field 4 - Try to view ILL requests 5 - You get a datatables error about missing metadata_author column 6 - Apply patch 7 - No more error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Clearly Nick's sleuthing skills are far superior to mine, either that or he just doesn't give up so easily. Anyway, glad he was able to track it down! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Myka Kennedy Stephens <mkstephens@lancasterseminary.edu> --- Tested patch. Works as expected. Results of test: 1. Applied patch. 2. Created journal article request, filling in values for fields provided (no author field) 3. Viewed list of ILL Requests. No error or warning message. 4. Author field for new journal article request says "N/A" Thank you!! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92608|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94824&action=edit Bug 21406: [18.11.x only] Prevent errors from undefined fields in requests To test: 1 - In 18.11 enable ILL and install the freeform backend 2 - Create a request for 'Journal article' 3 - Note there is no 'Author' field 4 - Try to view ILL requests 5 - You get a datatables error about missing metadata_author column 6 - Apply patch 7 - No more error Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected, passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@bywatersolutions.com, | |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org