[Bug 23075] New: Incorrect URL should have a meaningful error message
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Bug ID: 23075 Summary: Incorrect URL should have a meaningful error message Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Mana-kb Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com Target Milestone: --- Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22915 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90440&action=edit Bug 23075: Better error handling in Mana config Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. This patch makes it display a more friendly message. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- I wanted to test this, but couldn't figure it out! Any hints or direction would be appreciated. Is this talking about etc/koha-config.xml and the URL in there? For testing is this the URL to configure in koha-config.xml? https://mana-test.koha-community.org/ Or is it once you have it enabled and working, that is you have enabled and added a token? Up-to-date on master. I haven't been to get registration to work either, I get these two error messages when on /cgi-bin/koha/admin/share_content.pl: - An error occurred, mana server returned: URL must be absolute - Mana configuration is currently empty. This feature will not work. Please contact your site administrator. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to David Nind from comment #2)
I wanted to test this, but couldn't figure it out! Any hints or direction would be appreciated.
Is this talking about etc/koha-config.xml and the URL in there? For testing is this the URL to configure in koha-config.xml? https://mana-test.koha-community.org/
Or is it once you have it enabled and working, that is you have enabled and added a token? David, just enter a non valid URL in mana_config and try to register via cgi-bin/koha/admin/share_content.pl (request a mana token).
Up-to-date on master.
I haven't been to get registration to work either, I get these two error messages when on /cgi-bin/koha/admin/share_content.pl:
- An error occurred, mana server returned: URL must be absolute
- Mana configuration is currently empty. This feature will not work. Please contact your site administrator. As said, mana_config is empty. enter the following in your koha-conf.xml:
<mana_config>https://mana-test.koha-community.org</mana_config> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Alex Arnaud <alex.arnaud@biblibre.com> --- This makes we lost the response code ($result->{code} = $response->code;) We need it in some place to test the response. I.e: report search is broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Are you sure Alex? This patch did not remove the line you are referring to, it moved it above. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ha! my bad, got it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #7 from Alex Arnaud <alex.arnaud@biblibre.com> --- My explanation was not very clear, i admit :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90440|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90459&action=edit Bug 23075: Better error handling in Mana config Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. This patch makes it display a more friendly message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #9 from David Nind <david@davidnind.com> --- I'm having difficulty getting mana enabled using koha-testing-docker. I assume I have to update the instance configuration file in /etc/koha/sites/kohadev/koha-conf.xml I'll try kohadevbox (but last time I tried this I had problems with getting a local git repository and nfs working). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #10 from David Nind <david@davidnind.com> --- (In reply to David Nind from comment #9)
I'm having difficulty getting mana enabled using koha-testing-docker.
Solved my problem! Needed to go flush_memcached and the restart_all to get changes to /etc/koha/sites/kohadev/koha-conf.xml recognised. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90459|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 90594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90594&action=edit Bug 23075: Better error handling in Mana config Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. This patch makes it display a more friendly message. Test plan: 1. Add <mana_config>http://mana-test.koha-community.org</mana_config> to /etc/koha/sites/<instancename>/koha-conf.xml (see etc/koha-conf.xml in the Koha code repositoty for an example of where to add this; <instancename> if using koha-testing-docker is kohadev). 2. Clear memcached and restart services so that the changes in your Koha instance configuration are recognised (if using koha-testing-docker enter flush_memcached and then restart_all). 3. From the staff client home page go to Koha administration > Additional parameters > Share content with Mana KB. 4. Enable content sharing: change 'Use Mana KB for sharing content' to Yes and press Save. 5. Enter your first name, last name and email address in the Configure Mana KB section of the page and then press Send to Mana KB. 6. An error message is displayed, this may be something like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.' 7. Apply the patch (git so bz apply 23075). 8. Change the Mana config to the correct URL: <mana_config>https://mana-test.koha-community.org</mana_config> 9. Repeat steps 2,3 and 5. 10. A more friendly/human readable error message is now displayed: 'Error trying to connect or read response from the Mana server (Code: 301) Moved Permanently'. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #12 from David Nind <david@davidnind.com> --- Ignore step 8 in the test plan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90594|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 90595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90595&action=edit Bug 23075: Better error handling in Mana config Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. This patch makes it display a more friendly message. Test plan: 1. Add <mana_config>http://mana-test.koha-community.org</mana_config> to /etc/koha/sites/<instancename>/koha-conf.xml (see etc/koha-conf.xml in the Koha code repositoty for an example of where to add this; <instancename> if using koha-testing-docker is kohadev). 2. Clear memcached and restart services so that the changes in your Koha instance configuration are recognised (if using koha-testing-docker enter flush_memcached and then restart_all). 3. From the staff client home page go to Koha administration > Additional parameters > Share content with Mana KB. 4. Enable content sharing: change 'Use Mana KB for sharing content' to Yes and press Save. 5. Enter your first name, last name and email address in the Configure Mana KB section of the page and then press Send to Mana KB. 6. An error message is displayed, this may be something like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.' 7. Apply the patch (git so bz apply 23075). 8. Change the Mana config to the correct URL: <mana_config>https://mana-test.koha-community.org</mana_config>9. Repeat steps 2,3 and 5. 9. A more friendly/human readable error message is now displayed: 'Error trying to connect or read response from the Mana server (Code: 301) Moved Permanently'. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90595|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 90596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90596&action=edit Bug 23075: Better error handling in Mana config Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. This patch makes it display a more friendly message. Test plan: 1. Add <mana_config>http://mana-test.koha-community.org</mana_config> to /etc/koha/sites/<instancename>/koha-conf.xml (see etc/koha-conf.xml in the Koha code repositoty for an example of where to add this; <instancename> if using koha-testing-docker is kohadev). 2. Clear memcached and restart services so that the changes in your Koha instance configuration are recognised (if using koha-testing-docker enter flush_memcached and then restart_all). 3. From the staff client home page go to Koha administration > Additional parameters > Share content with Mana KB. 4. Enable content sharing: change 'Use Mana KB for sharing content' to Yes and press Save. 5. Enter your first name, last name and email address in the Configure Mana KB section of the page and then press Send to Mana KB. 6. An error message is displayed, this may be something like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.' 7. Apply the patch (git so bz apply 23075). 8. Repeat steps 2,3 and 5. 9. A more friendly/human readable error message is now displayed: 'Error trying to connect or read response from the Mana server (Code: 301) Moved Permanently'. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90596|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90606&action=edit Bug 23075: Better error handling in Mana config Currently, if you input an incorrect mana service URL in your config (http rather than https for example) the error message you are given is the direct output of a failed json parse. We should be able to catch such failures and display a more meaningful error to the end user. This patch makes it display a more friendly message. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement displays a release notes| |more meaningful error | |message if an incorrect | |Mana KB service URL is used | |in the koha-conf.xml | |configuration file (for | |example, if http is used | |instead of https), rather | |than the direct output from | |the failed json parse. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oops, this one slipped passed. I'm going to revert as I don't think the solution here is tangible unfortunately. The Mana server itself may return codes that are still meaningful even if they're not 200.. i.e. 201 has a meaning of it's own and as we're short-circuiting anything that's not 200 in this patch we'll be dropping OK responses of kinds. I have a plan and will post an alternative shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff Depends on| |22913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22913 [Bug 22913] https://mana-kb.koha-community.org/ should not return a 404 error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 90682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90682&action=edit Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90606|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've submitted an alternative resolution to this bug above. This alternative checks for a known response for a mana server to identify if the URL appears to be correct. It relies on bug 22913 at the mana-kb serverside to match this known state.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23139 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #20 from David Nind <david@davidnind.com> --- Patch now fails to apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90682|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94098&action=edit Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@bugs.koha-c |martin.renvoize@ptfs-europe |ommunity.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from David Nind <david@davidnind.com> --- Still getting message like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.' when URL is incorrect. (have run flush_memcached and restart_all). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Confirmed. Maybe a change server-side? $result is: \ { code 200, description "Mana KB is a global knowledge base for library-centric data. It has been designed initially to interact with Koha, the Open Source ILS, but can be used by any other software.", title "Mana KB API", version 0.1 } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to David Nind from comment #22)
Still getting message like 'malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "<html>\r\n<head><tit...") at /usr/share/perl5/JSON.pm line 171.' when URL is incorrect. (have run flush_memcached and restart_all).
Hmm, where are you seeing this exactly.. I'm struggling to replicate it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 94363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94363&action=edit screenshot This is what I see with the patch applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #25)
Created attachment 94363 [details] screenshot
This is what I see with the patch applied.
Try with http://mana-test.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #26)
(In reply to Martin Renvoize from comment #25)
Created attachment 94363 [details] screenshot
This is what I see with the patch applied.
Try with http://mana-test.koha-community.org
But that is a 'good' URL.. so I don't expect to see any errors.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #28 from David Nind <david@davidnind.com> --- The https version works fine, the http version produces errors as it is not a 'valid' URL. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Failing because of David's last comment, can you have a look Martin? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Still confused.. it should warn you when using http and not https as that's an invalid mana url. http://neverssl.com/mana-test.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What I see https://snipboard.io/bWxT4B.jpg with <mana_config>http://mana-test.koha-community.org</mana_config> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94098|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95000&action=edit Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed yet another rebased version.. but nothing has actually changed in the code.. I can't reproduce your issues, and can't see in the code how you would get that either. :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95003&action=edit Bug 23075: (follow-up) Dissallow transparent redirects GET request redirects were causing the http URL to 'pass' our 'good url' test for http => https redirected mana servers. However, on the subsquent POST request to get a mana security token we would fail as the POST was not transparently redirected. This patch changes the request to be a simple_request so we will catch bad urls earlier and it also prevents submissions for security tokens if the configured URL is identified as bad. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bad to needs signoff.. after a long chat with Jonathan on IRC I managed to replicate it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95009&action=edit Bug 23075: Do not 'Send' if the url is not correct Just in case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95000|0 |1 is obsolete| | --- Comment #37 from David Nind <david@davidnind.com> --- Created attachment 95074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95074&action=edit Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95003|0 |1 is obsolete| | --- Comment #38 from David Nind <david@davidnind.com> --- Created attachment 95075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95075&action=edit Bug 23075: (follow-up) Dissallow transparent redirects GET request redirects were causing the http URL to 'pass' our 'good url' test for http => https redirected mana servers. However, on the subsquent POST request to get a mana security token we would fail as the POST was not transparently redirected. This patch changes the request to be a simple_request so we will catch bad urls earlier and it also prevents submissions for security tokens if the configured URL is identified as bad. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95009|0 |1 is obsolete| | --- Comment #39 from David Nind <david@davidnind.com> --- Created attachment 95076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95076&action=edit Bug 23075: Do not 'Send' if the url is not correct Just in case. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #40 from David Nind <david@davidnind.com> --- Thanks Jonathan and Martin for your perseverance in resolving this! Message if an incorrect URL in config now says 'Cannot detect mana server at http://mana-test.koha-community.org, please ask an administrator to check your configuration.' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95074|0 |1 is obsolete| | Attachment #95075|0 |1 is obsolete| | Attachment #95076|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95078&action=edit Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #42 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95079&action=edit Bug 23075: (follow-up) Dissallow transparent redirects GET request redirects were causing the http URL to 'pass' our 'good url' test for http => https redirected mana servers. However, on the subsquent POST request to get a mana security token we would fail as the POST was not transparently redirected. This patch changes the request to be a simple_request so we will catch bad urls earlier and it also prevents submissions for security tokens if the configured URL is identified as bad. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95080&action=edit Bug 23075: Do not 'Send' if the url is not correct Just in case. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95081&action=edit Bug 23075: Correct indendation Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org