https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37832 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 171028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171028&action=edit Bug 37832: Fix Rentaldiscount to be decimal like other similar fields Added decimal input_mode and pattern for "Rental discount (%)" so it functions same way as "Fine amount" or "Overdue fines cap (amount)" rules, allowing user to save decimals only. 1. Go to Circulation and fine rules page and save some gibberish into "Rental discount (%)", see that it allows you to do that. 2. Apply the patch, and try same thing again, this time it should only allow you to save decimal numbers. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37832 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovezina@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37832 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171495|0 |1 is obsolete| | --- Comment #3 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 176240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176240&action=edit Attachment to Bug 37832 - Rentaldiscount is not required to be decimal like other similar fields in smart-rules.tt Bug 37832: Fix Rentaldiscount to be decimal like other similar fields Added decimal input_mode and pattern for "Rental discount (%)" so it functions same way as "Fine amount" or "Overdue fines cap (amount)" rules, allowing user to save decimals only. 1. Go to Circulation and fine rules page and save some gibberish into "Rental discount (%)", see that it allows you to do that. 2. Apply the patch, and try same thing again, this time it should only allow you to save decimal numbers. Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37832 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rentaldiscount is not |Rental discount is should |required to be decimal like |be decimal like other |other similar fields in |similar fields in |smart-rules.tt |circulation rules -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37832 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37832 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Caroline Cyr La Rose contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1084 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37832 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #6 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.