[Bug 26817] New: "Total" line in checkouts table is too short when ExportCircHistory is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Bug ID: 26817 Summary: "Total" line in checkouts table is too short when ExportCircHistory is activated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org There is a display error in the checkouts table in the staff interface when the ExportCircHistory system preference is activated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 112517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112517&action=edit Bug 26817: Change checkouts table footer colspan based on ExportCircHistory This patch makes a minor change to the include file which generates the checkouts table footer. It now includes some logic checking for the ExportCircHistory system preference, adjusting the colspan accordingly. To test, apply the patch and enable the ExportCircHistory system preference. - Check out to a patron who has checkouts. In the table of checkouts there should be an "Export" column. The footer at the bottom of the table should span the width of the table. - Disable the ExportCircHistory preference. - View the checkout page again and confirm that table footer still looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112517|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112728&action=edit Bug 26817: Change checkouts table footer colspan based on ExportCircHistory This patch makes a minor change to the include file which generates the checkouts table footer. It now includes some logic checking for the ExportCircHistory system preference, adjusting the colspan accordingly. To test, apply the patch and enable the ExportCircHistory system preference. - Check out to a patron who has checkouts. In the table of checkouts there should be an "Export" column. The footer at the bottom of the table should span the width of the table. - Disable the ExportCircHistory preference. - View the checkout page again and confirm that table footer still looks correct. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112728|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 112776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112776&action=edit Bug 26817: Change checkouts table footer colspan based on ExportCircHistory This patch makes a minor change to the include file which generates the checkouts table footer. It now includes some logic checking for the ExportCircHistory system preference, adjusting the colspan accordingly. To test, apply the patch and enable the ExportCircHistory system preference. - Check out to a patron who has checkouts. In the table of checkouts there should be an "Export" column. The footer at the bottom of the table should span the width of the table. - Disable the ExportCircHistory preference. - View the checkout page again and confirm that table footer still looks correct. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26817 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org