[Bug 26664] New: Inventory: Sorting column 'Last seen' goes wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Bug ID: 26664 Summary: Inventory: Sorting column 'Last seen' goes wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: christian.stelzenmueller@bsz-bw.de QA Contact: testopia@bugs.koha-community.org The column 'Last seen' on the results page of inventory.pl doesn't sort correctly. Only the date is taken into account, not the whole date. That was already described in Bug 24601, but here on the page inventory.pl. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24601 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 --- Comment #1 from Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> --- I mean day, not date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24601 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111822&action=edit Bug 26664: Fix sorting for date last seen in inventory tool This adds the standard datatable sorting for dates to the inventory table as described here: https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardle... To test: - Go to the inventory tool - Search for a big sample list of items with different date last seen - Sort the table now by "date last seen" by clicking on the table header cell - Try different settings of the DateFormat system preferences - Verify sorting is incorrect (alphabetic, not by date) - Apply patch - Repeat testing and very all is sorting correctly now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25897 [Bug 25897] Inventory table call number sort should use cn_sort value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111822|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 112482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112482&action=edit Bug 26664: Fix sorting for date last seen in inventory tool This adds the standard datatable sorting for dates to the inventory table as described here: https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardle... To test: - Go to the inventory tool - Search for a big sample list of items with different date last seen - Sort the table now by "date last seen" by clicking on the table header cell - Try different settings of the DateFormat system preferences - Verify sorting is incorrect (alphabetic, not by date) - Apply patch - Repeat testing and very all is sorting correctly now Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112482|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112890&action=edit Bug 26664: Fix sorting for date last seen in inventory tool This adds the standard datatable sorting for dates to the inventory table as described here: https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardle... To test: - Go to the inventory tool - Search for a big sample list of items with different date last seen - Sort the table now by "date last seen" by clicking on the table header cell - Try different settings of the DateFormat system preferences - Verify sorting is incorrect (alphabetic, not by date) - Apply patch - Repeat testing and very all is sorting correctly now Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112891&action=edit Bug 26664: (QA follow-up) Add filters Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected; passes QA tests (with follow-up) Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26664 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org