[Bug 38929] New: POST endpoints not returning the Location header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Bug ID: 38929 Summary: POST endpoints not returning the Location header Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com I found `POST /biblios` is not returning it. Opening this bug to track and fix such problems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38926 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38926 [Bug 38926] POST /biblios returns 200 even if AddBiblio fails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 176832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176832&action=edit Bug 38929: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 176833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176833&action=edit Bug 38929: Make POST endpoints return the `Location` header This patch makes the POST endpoints missing the Location header return it. Some endpoints I skipped: * /patrons/account/credits (doesn't have a GET route to point to) * /patrons/account/debits (doesn't have a GET route to point to) To test: 1. Apply the regression tests 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/authorities.t \ t/db_dependent/api/v1/biblios.t \ t/db_dependent/api/v1/clubs_holds.t \ t/db_dependent/api/v1/holds.t \ t/db_dependent/api/v1/ill_batchstatuses.t \ t/db_dependent/api/v1/import_batch_profiles.t \ t/db_dependent/api/v1/transfer_limits.t => FAIL: Tests fail! The endpoints don't return the header! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 176834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176834&action=edit Bug 38929: (follow-up) Replace SWAGGER -> REST in the tests The wiki now uses `REST*` for the rule names instead of `SWAGGER*` some tests have their descriptions correct, but most don't. This is a follow-up to an editorial decision made on the Wiki (probably at a dev meeting too, I don't remember). QA tests will probably not pass, but I refrain from tidying it because there's a major tidy on its way to main. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38931 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38931 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38932 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I hadn't thought about this use case but it makes sense to return the Location header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Do we want a test to enforce this? Should we ALWAYS find $c->res->headers->location before the render call? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Do we want a test to enforce this?
Should we ALWAYS find $c->res->headers->location before the render call?
Well, we have a long time voted coding guideline https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#REST3.4.1_POST -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176901&action=edit Bug 38929: Add xt test to enforce REST3.4.1 POST -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #6)
(In reply to Jonathan Druart from comment #5)
Do we want a test to enforce this?
Should we ALWAYS find $c->res->headers->location before the render call?
Well, we have a long time voted coding guideline
https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#REST3.4.1_POST
Yes, and it's not enough. Here is a test to enforce it, we have 3 failures. # Failed test 'Koha/REST/V1/Auth/Password.pm does not contain the location header' # at xt/api.t line 186. # Failed test 'Koha/REST/V1/Patrons/Account.pm does not contain the location header' # at xt/api.t line 186. # Failed test 'Koha/REST/V1/Preservation/WaitingList.pm does not contain the location header' # at xt/api.t line 186. # Looks like you failed 3 tests of 55. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #9 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #8)
(In reply to Tomás Cohen Arazi (tcohen) from comment #6)
Well, we have a long time voted coding guideline
https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#REST3.4.1_POST
Yes, and it's not enough. Here is a test to enforce it, we have 3 failures.
I know about them. Answering inline:
# Failed test 'Koha/REST/V1/Auth/Password.pm does not contain the location header' # at xt/api.t line 186.
I'm not sure what location it should return. Maybe the same was used for the request.
# Failed test 'Koha/REST/V1/Patrons/Account.pm does not contain the location header' # at xt/api.t line 186.
This is certainly handled by bug 38932.
# Failed test 'Koha/REST/V1/Preservation/WaitingList.pm does not contain the location header' # at xt/api.t line 186. # Looks like you failed 3 tests of 55.
A complex one. The POST receives a list of items. I'm also not sure on this one. Ideas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #9)
(In reply to Jonathan Druart from comment #8)
(In reply to Tomás Cohen Arazi (tcohen) from comment #6) # Failed test 'Koha/REST/V1/Auth/Password.pm does not contain the location header' # at xt/api.t line 186.
I'm not sure what location it should return. Maybe the same was used for the request.
This one could be skip I guess.
# Failed test 'Koha/REST/V1/Preservation/WaitingList.pm does not contain the location header' # at xt/api.t line 186. # Looks like you failed 3 tests of 55.
A complex one. The POST receives a list of items. I'm also not sure on this one. Ideas?
Point to the first one? Of we skip this specific file from the test. Exceptions are not bad, if they prevent us from new missing occurrences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 176906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176906&action=edit Bug 38929: Add 2 exceptions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #12 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. xt tests now fail: prove xt/api.t 2. Other tests pass after pacthes applied: - Tests in step 2 of the test plan - All the API tests: prove t/db_dependent/api/v1/* prove xt/api.t xt/api.t .. 3/6 # Failed test 'Koha/REST/V1/Patrons/Account.pm does not contain the location header' # at xt/api.t line 193. # Looks like you failed 1 test of 55. # Failed test 'POST (201) have location header' # at xt/api.t line 196. # Looks like you failed 1 test of 6. xt/api.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/6 subtests Test Summary Report ------------------- xt/api.t (Wstat: 256 (exited 1) Tests: 6 Failed: 1) Failed test: 6 Non-zero exit status: 1 Files=1, Tests=6, 4 wallclock secs ( 0.01 usr 0.01 sys + 4.39 cusr 0.32 csys = 4.73 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- David, this failure should be fixed with the patches from bug 38932 applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- @RM - Push along with bug 38932. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176832|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 177068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177068&action=edit Bug 38929: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176833|0 |1 is obsolete| | --- Comment #16 from David Nind <david@davidnind.com> --- Created attachment 177069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177069&action=edit Bug 38929: Make POST endpoints return the `Location` header This patch makes the POST endpoints missing the Location header return it. Some endpoints I skipped: * /patrons/account/credits (doesn't have a GET route to point to) * /patrons/account/debits (doesn't have a GET route to point to) To test: 1. Apply the regression tests 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/authorities.t \ t/db_dependent/api/v1/biblios.t \ t/db_dependent/api/v1/clubs_holds.t \ t/db_dependent/api/v1/holds.t \ t/db_dependent/api/v1/ill_batchstatuses.t \ t/db_dependent/api/v1/import_batch_profiles.t \ t/db_dependent/api/v1/transfer_limits.t => FAIL: Tests fail! The endpoints don't return the header! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176834|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 177070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177070&action=edit Bug 38929: (follow-up) Replace SWAGGER -> REST in the tests The wiki now uses `REST*` for the rule names instead of `SWAGGER*` some tests have their descriptions correct, but most don't. This is a follow-up to an editorial decision made on the Wiki (probably at a dev meeting too, I don't remember). QA tests will probably not pass, but I refrain from tidying it because there's a major tidy on its way to main. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176901|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 177071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177071&action=edit Bug 38929: Add xt test to enforce REST3.4.1 POST Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176906|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 177072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177072&action=edit Bug 38929: Add 2 exceptions Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #20 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #13)
David, this failure should be fixed with the patches from bug 38932 applied.
Thanks Jonathan! Testing notes (using KTD): 1. Apply 38926. 2. Apply 38932. 3. Run: yarn api:bundle 4. Apply 38929. 5. Restart everything: restart_all 6. Check that these tests pass (step 2 of the test plan): prove t/db_dependent/api/v1/authorities.t \ t/db_dependent/api/v1/biblios.t \ t/db_dependent/api/v1/clubs_holds.t \ t/db_dependent/api/v1/holds.t \ t/db_dependent/api/v1/ill_batchstatuses.t \ t/db_dependent/api/v1/import_batch_profiles.t \ t/db_dependent/api/v1/transfer_limits.t 7. Check that these tests pass: prove xt/api.t 8. Check that all the API tests pass: prove t/db_dependent/api/v1/* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177068|0 |1 is obsolete| | --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 177106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177106&action=edit Bug 38929: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177069|0 |1 is obsolete| | --- Comment #22 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 177107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177107&action=edit Bug 38929: Make POST endpoints return the `Location` header This patch makes the POST endpoints missing the Location header return it. Some endpoints I skipped: * /patrons/account/credits (doesn't have a GET route to point to) * /patrons/account/debits (doesn't have a GET route to point to) To test: 1. Apply the regression tests 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/authorities.t \ t/db_dependent/api/v1/biblios.t \ t/db_dependent/api/v1/clubs_holds.t \ t/db_dependent/api/v1/holds.t \ t/db_dependent/api/v1/ill_batchstatuses.t \ t/db_dependent/api/v1/import_batch_profiles.t \ t/db_dependent/api/v1/transfer_limits.t => FAIL: Tests fail! The endpoints don't return the header! 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177070|0 |1 is obsolete| | --- Comment #23 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 177108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177108&action=edit Bug 38929: (follow-up) Replace SWAGGER -> REST in the tests The wiki now uses `REST*` for the rule names instead of `SWAGGER*` some tests have their descriptions correct, but most don't. This is a follow-up to an editorial decision made on the Wiki (probably at a dev meeting too, I don't remember). QA tests will probably not pass, but I refrain from tidying it because there's a major tidy on its way to main. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177071|0 |1 is obsolete| | --- Comment #24 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 177109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177109&action=edit Bug 38929: Add xt test to enforce REST3.4.1 POST Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177072|0 |1 is obsolete| | --- Comment #25 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 177110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177110&action=edit Bug 38929: Add 2 exceptions Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |matt.blenkinsop@ptfs-europe |y.org |.com CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please note: xt/api.t will fail without Bug 38932. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 --- Comment #28 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37622 [Bug 37622] "location" header is set for non-POST routes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #29 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #30 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38929 Bug 38929 depends on bug 38926, which changed state. Bug 38926 Summary: POST /biblios returns 200 even if AddBiblio fails https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38926 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org