[Bug 11820] New: dead code in basketgroup.pl : "add" operation is never invoked without a booksellerid
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Bug ID: 11820 Summary: dead code in basketgroup.pl : "add" operation is never invoked without a booksellerid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: gmcharlt@gmail.com QA Contact: testopia@bugs.koha-community.org There is code in basketgroup.pl that handles the case where the "add" operation is called without a booksellerid being passed as well. However, there is no sign that this actually happens. Remove the extra conditional branch will simplify the script slightly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Indeed, upon review, it's /very/ unlikely that it's called that way: otherwise, folks would be seeing crashes like this: Undefined subroutine &main::GetBookSeller called at /home/gmc/koha/acqui/basketgroup.pl line 258, <DATA> line 558. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 25551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25551&action=edit Bug 11820: remove dead code in basket group management There was some code in acqui/basketgroup.pl that was apparently intended to let one create a basket group for no (or an unknown) vendor. However, this code was never reached, as there is nothing in the templates that invokes basketgroup.pl with 'add' as the operation that doesn't also pass the vendor ID along. This patch removes that dead code. To test: [1] Create a new basket group for a vendor and verify that it is created correctly. [2] Edit an existing basket group, including moving baskets in and and out of, and verify that it works. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11471 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25551|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25572&action=edit Bug 11820: remove dead code in basket group management There was some code in acqui/basketgroup.pl that was apparently intended to let one create a basket group for no (or an unknown) vendor. However, this code was never reached, as there is nothing in the templates that invokes basketgroup.pl with 'add' as the operation that doesn't also pass the vendor ID along. This patch removes that dead code. To test: [1] Create a new basket group for a vendor and verify that it is created correctly. [2] Edit an existing basket group, including moving baskets in and and out of, and verify that it works. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |gmc@esilibrary.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25572|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26159&action=edit [PASSED QA] Bug 11820: remove dead code in basket group management There was some code in acqui/basketgroup.pl that was apparently intended to let one create a basket group for no (or an unknown) vendor. However, this code was never reached, as there is nothing in the templates that invokes basketgroup.pl with 'add' as the operation that doesn't also pass the vendor ID along. This patch removes that dead code. To test: [1] Create a new basket group for a vendor and verify that it is created correctly. [2] Edit an existing basket group, including moving baskets in and and out of, and verify that it works. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> No regressions found, passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11820 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch does not apply on 3.14.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org