http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11686 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11686 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 25057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25057&action=edit Bug 11686 - "please note your reason here..." does not get translated Through some quirk of the translation script a predefined value on a text input is not properly translated even though the string appears in the po file. On the suggestions form the problem can be solved by using the HTML5 placeholder attribute. To test you must have existing suggestions to manage. Apply the patch and: - Update a translation by running tranlsate update [language code] - Install/reinstall the translation by running translate install [language code] - In the English templates: - Navigate to Acquisitions -> Suggestions and find the "Mark selected as:" section below the table of existing suggestions. - Select "Other" from the "choose a reason" field. A text input field should appear with the placeholder text "please note your reason here." - In the templates you updated and installed, follow the same procedure above. The placeholder text should now appear with the correct translation. - In both English and translated templates using this bulk-status option should save your chosen status correctly with the correct reason, whether that reason be predefined or manually entered. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11686 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25057|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25737&action=edit Bug 11686 - "please note your reason here..." does not get translated Through some quirk of the translation script a predefined value on a text input is not properly translated even though the string appears in the po file. On the suggestions form the problem can be solved by using the HTML5 placeholder attribute. To test you must have existing suggestions to manage. Apply the patch and: - Update a translation by running tranlsate update [language code] - Install/reinstall the translation by running translate install [language code] - In the English templates: - Navigate to Acquisitions -> Suggestions and find the "Mark selected as:" section below the table of existing suggestions. - Select "Other" from the "choose a reason" field. A text input field should appear with the placeholder text "please note your reason here." - In the templates you updated and installed, follow the same procedure above. The placeholder text should now appear with the correct translation. - In both English and translated templates using this bulk-status option should save your chosen status correctly with the correct reason, whether that reason be predefined or manually entered. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25737|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 26157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26157&action=edit [PASSED QA] Bug 11686 - "please note your reason here..." does not get translated Through some quirk of the translation script a predefined value on a text input is not properly translated even though the string appears in the po file. On the suggestions form the problem can be solved by using the HTML5 placeholder attribute. To test you must have existing suggestions to manage. Apply the patch and: - Update a translation by running tranlsate update [language code] - Install/reinstall the translation by running translate install [language code] - In the English templates: - Navigate to Acquisitions -> Suggestions and find the "Mark selected as:" section below the table of existing suggestions. - Select "Other" from the "choose a reason" field. A text input field should appear with the placeholder text "please note your reason here." - In the templates you updated and installed, follow the same procedure above. The placeholder text should now appear with the correct translation. - In both English and translated templates using this bulk-status option should save your chosen status correctly with the correct reason, whether that reason be predefined or manually entered. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script. Tested successfully with German - nice to see this fixed! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11686 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.