[Bug 21942] New: Clean up cataloging merge template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Bug ID: 21942 Summary: Clean up cataloging merge template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There are a few minor markup issues with the cataloging merge template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82845&action=edit Bug 21942: Clean up cataloging merge template This patch makes a few minor markup corrections to the cataloging merge template: - Remove invalid "type" attributes from <style> and <script> - Add missing closing </span> - Remove obsolete YUI grid markup To test, apply the patch and test the process of merging records in Cataloging. Everything should look correct and work correctly. Validating the HTML source should return no errors stemming from the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #2 from Michal Denar <black23@gmail.com> --- Hi Owen, can you rebase patch on master? Thank you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82845|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 88000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88000&action=edit Bug 21942: Clean up cataloging merge template This patch makes a few minor markup corrections to the cataloging merge template: - Remove invalid "type" attributes from <style> and <script> - Add missing closing </span> - Remove obsolete YUI grid markup To test, apply the patch and test the process of merging records in Cataloging. Everything should look correct and work correctly. Validating the HTML source should return no errors stemming from the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88000|0 |1 is obsolete| | --- Comment #4 from Michal Denar <black23@gmail.com> --- Created attachment 88034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88034&action=edit Bug 21942: Clean up cataloging merge template This patch makes a few minor markup corrections to the cataloging merge template: - Remove invalid "type" attributes from <style> and <script> - Add missing closing </span> - Remove obsolete YUI grid markup To test, apply the patch and test the process of merging records in Cataloging. Everything should look correct and work correctly. Validating the HTML source should return no errors stemming from the template. Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88034|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 88129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88129&action=edit Bug 21942: Clean up cataloging merge template This patch makes a few minor markup corrections to the cataloging merge template: - Remove invalid "type" attributes from <style> and <script> - Add missing closing </span> - Remove obsolete YUI grid markup To test, apply the patch and test the process of merging records in Cataloging. Everything should look correct and work correctly. Validating the HTML source should return no errors stemming from the template. Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21942 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org