[Bug 21545] New: Update German web Installer for 18.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Bug ID: 21545 Summary: Update German web Installer for 18.11 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The same procedure as every release...check sample files for missing values and translations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22024 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Splitting rules added by bug 22024 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83376&action=edit Bug 21545: Translate 'Stock rotation slip' Throwing in some capitalization fixes for the English version of the notice as well. To test: - Verify the changes make sense and the SQL is still valid and executes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83377&action=edit Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German To test: - Apply patch - Run the German web installer - Verify the sample notices installs without error - Verify it looks 'German' in the GUI :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83377|0 |1 is obsolete| | --- Comment #4 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 87749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87749&action=edit Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German To test: - Apply patch - Run the German web installer - Verify the sample notices installs without error - Verify it looks 'German' in the GUI :) Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #5 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #2)
Created attachment 83376 [details] [review] Bug 21545: Translate 'Stock rotation slip'
Throwing in some capitalization fixes for the English version of the notice as well.
To test: - Verify the changes make sense and the SQL is still valid and executes
Couldn't figure out how to amend this commit, but I followed the test plan for it so please consider both patches signed off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Hayley, thx a lot for testing! There are some tricks to make sighing off multiple patches super easy: https://wiki.koha-community.org/wiki/Tips_and_tricks In my devbox it's git so2 2 (sign-off last 2 patches, without running tests) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 --- Comment #7 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #6)
Hi Hayley, thx a lot for testing!
There are some tricks to make sighing off multiple patches super easy: https://wiki.koha-community.org/wiki/Tips_and_tricks
In my devbox it's git so2 2 (sign-off last 2 patches, without running tests)
Thank you very much Katrin, that's very useful! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83376|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88023&action=edit Bug 21545: Translate 'Stock rotation slip' Throwing in some capitalization fixes for the English version of the notice as well. To test: - Verify the changes make sense and the SQL is still valid and executes Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87749|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 88024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88024&action=edit Bug 21545: Translate new ACCOUNT_PAYMENT and ACCOUNT_WRITEOFF notices to German To test: - Apply patch - Run the German web installer - Verify the sample notices installs without error - Verify it looks 'German' in the GUI :) Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Simple translation fix.. works for me.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21545 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.00, 18.11.05 released in| | Severity|enhancement |minor Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org