[Bug 7500] New: Use CSS Sprites for faster page loading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Bug #: 7500 Summary: Use CSS Sprites for faster page loading Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: In Discussion Severity: enhancement Priority: P5 - low Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: koha.sekjal@gmail.com QAContact: koha.sekjal@gmail.com In order to reduce the number of image requests on the OPAC, perhaps it would be advantageous to create a single PNG containing all the images tiled together, then use CSS values to 'mask' the unnecessary parts. This could reduce the overall page load time by several hundred milliseconds. Not a significant percentage in the grand scheme of things, but every little bit counts. Thoughts? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2012-02-03 20:22:18 UTC --- I agree, a worthy goal. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED CC| |paul.poulain@biblibre.com --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-10 13:57:00 UTC --- I don't see which discussion to start here. it's the kind of question we have on a lot of other bugs: it's a cool idea, now who do it ? removing the "in discussion" status. If one of you think it's usefull, switch back, and start the discussion on the wiki & mailing list -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9226&action=edit Bug 7500 - Use CSS Sprites for faster page loading This patch moves *most* small interface icons and the Koha log into a single 10K sprite image. CSS is used to position the sprite correctly for each icon instance. Not covered by this patch: XSLT icons, star ratings icons, table sort icons (the latter which I don't think can be done using this technique). A follow-up patch should remove the individual images which have been replaced by the sprite. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #4 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Owen, I love this patch, it goes a long way towards reducing round trip times to server :-) However, I don't think we should include koha-logo.gif in sprites, since it's element which most library customize, and applying your patch on top of customized installation shows correct logo but shifted because of css modifications to h1#libraryname Dropping koha-logo.gif from sprites.png would also make sprites smaller, since all other icons are smaller than Koha logo. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)
Created attachment 9226 [details] Bug 7500 - Use CSS Sprites for faster page loading
This patch moves *most* small interface icons and the Koha log into a single 10K sprite image. CSS is used to position the sprite correctly for each icon instance.
woo - nice idea! Owen, whats the method to create the 10k sprites file?, just curious... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #6 from Dobrica Pavlinusic <dpavlin@rot13.org> --- A long time ago, I wrote automatic CSS sprite generator: http://svn.rot13.org/index.cgi/Frey/view/trunk/lib/Frey/Web/CombineImages.pm Would it make sense to turn it into Template Toolkit plugin, possibly as part of Bug 1918 so we can generate sprites automatically? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #5)
Owen, whats the method to create the 10k sprites file?, just curious...
The images are just grouped together in one tall narrow file. I did it in Photoshop, but it could have been done just as easily in another image editor. (In reply to comment #6)
Would it make sense to turn it into Template Toolkit plugin, possibly as part of Bug 1918 so we can generate sprites automatically?
That seems like more work for the server than is necessary considering how seldom we add new image files for the interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9239&action=edit Bug 7500 [FOLLOW-UP] Use CSS Sprites for faster page loading This patch removes the Koha logo from the sprite and corrects the positioning of other elements in the CSS. Apply this one on top of the first to test this option. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9226|0 |1 is obsolete| | Attachment #9239|0 |1 is obsolete| | --- Comment #9 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 9241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9241&action=edit Bug 7500 - Use CSS Sprites for faster page loading This patch moves *most* small interface icons and the Koha log into a single 10K sprite image. CSS is used to position the sprite correctly for each icon instance. Not covered by this patch: XSLT icons, star ratings icons, table sort icons (the latter which I don't think can be done using this technique). A follow-up patch should remove the individual images which have been replaced by the sprite. Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: nothing specific to say, passed QA Just some number YSLOW gives for a random opac-detail page (with "socialnetwork syspref activated, that add some image not concerned by this patch) : * BEFORE the patch = 50 components, 16 css images, images+css image = 30.5k * AFTER the patch = 43 components, 7 css images, images+css image = 36.3k (that's a larger size, probably because we load 1 large image, not X tiny ones. But they'll be cached, so it's OK) passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- I'd really like to push this patch before the release, but its an ENH that will wait for after 3.8 If there's something wrong hidden, I don't want to release without a good testing time. A question for Owen: * you say "most". Does it mean you'll provide a follow-up for other images, or images that aren't in won't be added -whatever the reason- * could you provide also the follow-up that removes now useless images ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- I missing from this first patch is: - Social network images - Star ratings images - XSLT icons Each of these is a feature which can be turned on or off. Options: - Make a single sprite for each - Add them all to the main sprite Opinions? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #12)
I missing from this first patch is:
- Social network images - Star ratings images - XSLT icons
Each of these is a feature which can be turned on or off. Options:
- Make a single sprite for each - Add them all to the main sprite I would say a sprite for each. About XSLT icons, are you talking of itemtype images ? if you're I'm not sure we should "sprite" them: most libraries use a few of them.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|rel_3_8 |rel_3_10 --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #12)
I missing from this first patch is:
- Social network images - Star ratings images - XSLT icons
Each of these is a feature which can be turned on or off. Options:
- Make a single sprite for each - Add them all to the main sprite I think social network images is worth being put in a separate sprite and star rating in another one, and XSLT icons are probably not a good idea because only one is used on a given record and we have a lot of icons, so we would upload an image much larger than needed
PS: for social network & star, the sprite being loaded only if those features are ON, of course -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9594&action=edit Bug 7500 [FOLLOW-UP] Use CSS Sprites for faster page loading This patch adds a new sprite image for social network links. The page markup has been modified to accommodate the image- replacement technique used to display the images. When testing be sure to clear your cache to load the new CSS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9599&action=edit Bug 7500 [FOLLOW-UP][Star ratings] Use CSS Sprites for faster page loading Combines two star ratings sprites into one and makes the corresponding CSS changes. The two original images have been removed. To test, view star ratings on search results and the detail page. Try setting star ratings on the detail page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9594|Bug 7500 [FOLLOW-UP] Use |Bug 7500 [FOLLOW-UP][Social description|CSS Sprites for faster page |networks] Use CSS Sprites |loading |for faster page loading -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9623&action=edit Bug 7500 [FOLLOW-UP][Missing images] Use CSS Sprites for faster page loading - Adds shelf browser navigational arrows to the main sprite. - Removes "caret.gif" (a sort of breadcrumbs separator in the OPAC) and replaces it with a similar Unicode arrow entity. - Replaces item-bullet.gif (a custom list bullet used in the Cart) with data URI encoding the image in the CSS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #15)
Created attachment 9594 [details] Bug 7500 [FOLLOW-UP][Social networks] Use CSS Sprites for faster page loading
This patch does not apply (I just test this one), can you rebase it please ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9594|0 |1 is obsolete| | --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9677&action=edit Bug 7500 [FOLLOW-UP][Social networks] Use CSS Sprites for faster page loading This patch adds a new sprite image for social network links. The page markup has been modified to accommodate the image- replacement technique used to display the images. When testing be sure to clear your cache to load the new CSS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9677|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9678&action=edit Bug 7500 [FOLLOW-UP][Social networks] Use CSS Sprites for faster page loading This patch adds a new sprite image for social network links. The page markup has been modified to accommodate the image- replacement technique used to display the images. When testing be sure to clear your cache to load the new CSS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9678|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #21 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9679&action=edit Bug 7500 [FOLLOW-UP][Social networks] Use CSS Sprites for faster page loading This patch adds a new sprite image for social network links. The page markup has been modified to accommodate the image- replacement technique used to display the images. When testing be sure to clear your cache to load the new CSS. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9679|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9680&action=edit Bug 7500 [SIGNED-OFF][FOLLOW-UP][Social networks] Use CSS Sprites for faster page loading -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9241|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #23 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I am a little confused by the status of this bug. Does anything here still need sign off? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- Yes, two patches still need to be signed off: Attachment 9599 (Star ratings) and Attachment 9623 (Missing images). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9599|0 |1 is obsolete| | --- Comment #25 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11398&action=edit Bug 7500 [FOLLOW-UP][Star ratings] Use CSS Sprites for faster page loading Combines two star ratings sprites into one and makes the corresponding CSS changes. The two original images have been removed. To test, view star ratings on search results and the detail page. Try setting star ratings on the detail page. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9623|0 |1 is obsolete| | --- Comment #26 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11399&action=edit Bug 7500 [FOLLOW-UP][Missing images] Use CSS Sprites for faster page loading - Adds shelf browser navigational arrows to the main sprite. - Removes "caret.gif" (a sort of breadcrumbs separator in the OPAC) and replaces it with a similar Unicode arrow entity. - Replaces item-bullet.gif (a custom list bullet used in the Cart) with data URI encoding the image in the CSS Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl QA Contact|koha.sekjal@gmail.com |m.de.rooy@rijksmuseum.nl --- Comment #27 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks good to me. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #28 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: if i'm not wrong owen, you replaced /opac-tmpl/prog/images/socnet/facebook16.png by a social sprite, but facebook16.png is not removed. Shouldn't it be removed ? (same thing for other social network links) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #29 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #28)
QA comment: if i'm not wrong owen, you replaced /opac-tmpl/prog/images/socnet/facebook16.png by a social sprite, but facebook16.png is not removed.
Shouldn't it be removed ? (same thing for other social network links)
Owen = ping -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9680|0 |1 is obsolete| | --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12165&action=edit Bug 7500 [FOLLOW-UP, revised][Social networks] Use CSS Sprites for faster page loading This patch adds a new sprite image for social network links. The page markup has been modified to accommodate the image- replacement technique used to display the images. When testing be sure to clear your cache to load the new CSS. Revision: Rebased, and unused social network images removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #31 from Paul Poulain <paul.poulain@biblibre.com> --- The 3 follow-up have been pushed to master: Bug 7500 [FOLLOW-UP][Star ratings] Use CSS Sprites for faster page loading Bug 7500 [FOLLOW-UP][Missing images] Use CSS Sprites for faster page loading Bug 7500 [FOLLOW-UP, revised][Social networks] Use CSS Sprites for faster page loading (does not apply to new/Bug_7500, that is old, so pushed directly to master) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11398|0 |1 is obsolete| | Attachment #11399|0 |1 is obsolete| | Attachment #12165|0 |1 is obsolete| | --- Comment #32 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13314&action=edit Bug 7500 [Lists follow-up] Use CSS Sprites for faster page loading I just noticed there were a couple of instances where the lists page referred to an image which was removed in a previous patch for Bug 7500. This patch corrects it. To test, edit a list in the OPAC. The breadcrumbs menu should have no broken images. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |minor --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Owen's description for the last patch sounds like a bug - please reset to enhancement if I am wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13314|0 |1 is obsolete| | --- Comment #34 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13386&action=edit Signed patch (lists follow-up) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment for attachment 13386: trivial one-line fix. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #36 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The patch that is attached to this bug seems to be unrelated. Could you please attach the signed-off version of the patch, Marcel? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13386|0 |1 is obsolete| | --- Comment #37 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 13421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13421&action=edit Signed patch (lists follow-up) This should be the right one now :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #38 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #39 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Use CSS Sprites for faster |Use CSS Sprites in the OPAC |page loading |for faster page loading -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- When YUI toolbars are fully purged from the staff client we'll need to do some cleanup on stray image files and evaluate what images need to be "sprited" for that interface. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10125 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org