[Bug 10115] New: Hiding advanced search in Orders search tab removes plus button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10115 Bug ID: 10115 Summary: Hiding advanced search in Orders search tab removes plus button Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: jcamins@cpbibliography.com If you click the plus button to display advanced search options in the Orders search tab on the masthead then hide those options by clicking the minus button, rather than the options being hidden and the plus sign reappearing, but the options and the plus sign vanish. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10115 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10115 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10115 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17684&action=edit Bug 10115 - Hiding advanced search in Orders search tab removes plus button The logic of the JavaScript for showing and hiding additional options in the orders search form wasn't quite right, resulting in the +/- control being hidden incorrectly. This patch corrects and simplifies the JS in order to fix the problem. To test: - Open any page in Acquisitions which shows the orders search form in the header search bar (for instance, Acquisitions home). - Open the orders search tab and click on the "+" to show more options. - Click the "-" to hide the additional options. The additional options should now be hidden and the "+" displayed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10115 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17684|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 17687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17687&action=edit Bug 10115 - Hiding advanced search in Orders search tab removes plus button The logic of the JavaScript for showing and hiding additional options in the orders search form wasn't quite right, resulting in the +/- control being hidden incorrectly. This patch corrects and simplifies the JS in order to fix the problem. To test: - Open any page in Acquisitions which shows the orders search form in the header search bar (for instance, Acquisitions home). - Open the orders search tab and click on the "+" to show more options. - Click the "-" to hide the additional options. The additional options should now be hidden and the "+" displayed. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Works as expected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10115 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10115 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Simple patch, works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10115 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17687|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17695&action=edit Bug 10115 - Hiding advanced search in Orders search tab removes plus button The logic of the JavaScript for showing and hiding additional options in the orders search form wasn't quite right, resulting in the +/- control being hidden incorrectly. This patch corrects and simplifies the JS in order to fix the problem. To test: - Open any page in Acquisitions which shows the orders search form in the header search bar (for instance, Acquisitions home). - Open the orders search tab and click on the "+" to show more options. - Click the "-" to hide the additional options. The additional options should now be hidden and the "+" displayed. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Works as expected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10115 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org