https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33276 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33276 --- Comment #2 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 148412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148412&action=edit Bug 33276: Get auth values for location on serials Serial location is linked to a library, if we want to modify serial with users does not belongs to, location is not in select and we could erase it. Test plan: 1) Be sure to have a LOC authorized value limited to one library at least 2) See when editing serial subscription you didn't get the current location 3) Apply this patch 4) Refresh and now you've got the value -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33276 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Summary|Library limitations will |Library limitations will |cause data loss when |cause data loss when |editing serial items |editing locations in the | |subscription form --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Thibaud Guillot from comment #3)

(In reply to Katrin Fischer from comment #1)

...

Hi Thibaud, I think the item form in acquisitions is also based on the same code as the one in serials.

Hi Katrin,

Hum.. I wrote a patch but it's not like in items, the form isn't generated on the same way.. or I miss up :/

What I meant: The item forms in Koha are built with different code: * Cataloguing / Item form * Serial item form / Acquisition item form But I misunderstood your patch: you are updating the location in the subscription form. That's also a great catch and I am very happy to see more and more of these issues fixed! There is also an option to set the collection for the subscription now, I think we'll need the same fix there. What do you think? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33276 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148412|0 |1 is obsolete| | --- Comment #5 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 148958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148958&action=edit Bug 33276: Get auth values for location on serials Serial location is linked to a library, if we want to modify serial with users does not belongs to, location is not in select and we could erase it. Test plan: 1) Be sure to have a LOC authorized value limited to one library at least 2) See when editing serial subscription you didn't get the current location 3) Apply this patch 4) Refresh and now you've got the value Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33276 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #7 from Mathieu Saby <mathsabypro@gmail.com> --- "data loss", should not it be categorized as a major issue? I would be glad to test a new version once we are done with Bug 32748... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33276 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148958|0 |1 is obsolete| | --- Comment #8 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 204864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204864&action=edit Bug 33276: Keep restricted serial location selectable The Location dropdown on subscription-add.pl is built from GetAuthorisedValues("MYAV"), which filters authorised values by the logged-in user's library. When a subscription's location is an AV restricted to another library it is absent from the list, so it shows as unselected and gets wiped on save. This adds Koha::AuthorisedValues->add_current_value, which re-appends the stored value (scoped to its category) flagged as restricted, and uses it in subscription-add.pl. Test plan: 1) Create an authorised value limited to library A 2) Log in as staff at library B, which cannot use that value 3) Edit a subscription whose location is that AV => without the patch the value is missing 4) Apply the patch, restart_all => the value is shown, selected, with a warning marker; saving keeps it 5) prove t/db_dependent/AuthorisedValues.t Sponsored-by: BibLibre -- You are receiving this mail because: You are watching all bug changes.