[Bug 31763] New: Add 'page-section' to patron lists page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Bug ID: 31763 Summary: Add 'page-section' to patron lists page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lucas@bywatersolutions.com, oleonard@myacpl.org, testopia@bugs.koha-community.org Depends on: 30952 Blocks: 31757 We need the page-section div adding to patron lists page to ensure proper contrast for even/odd rows on the tables. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 141835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141835&action=edit Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a <fieldset> to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141835|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141840&action=edit Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a <fieldset> to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141840|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 141845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141845&action=edit Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a <fieldset> to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I hadn't refreshed the page - I now see it was already signed off! I notice that the auto complete for patron search when adding patrons to a list is not working (it wasn't working before the patch was applied). Should this be a separate bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #4)
I hadn't refreshed the page - I now see it was already signed off!
I notice that the auto complete for patron search when adding patrons to a list is not working (it wasn't working before the patch was applied).
Should this be a separate bug?
Never hurts to have 2 sign-offs! I see there is a JS error on that page and that is likely why the auto complete function is broken: Uncaught TypeError: $(...).autocomplete(...).data(...) is undefined Let's file a separate bug for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Lucas Gass from comment #5)
Let's file a separate bug for that.
Bug 31782 created for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141845|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141865&action=edit Bug 31763: Add 'page-section' to patron lists page This patch updates patron lists templates so that the main content of the page is wrapped with a "page-section" div. This ensures that content has sufficient contrast. See Bug 31757. Unrelated change: I wrapped some form controls in a <fieldset> to make it consistent with other pages and to work better with the updated markup. Note: This patch contains indentation changes, so use diff accordingly. To test, apply the patch and go to Tools -> Patron lists. - If necessary, create one or more patron lists so that the table appears. Confirm that the content area looks correct. - Click Actions -> Add patrons to confirm that the screen looks correct. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks good, thanks for the quick work. Passing QA.. Thanks for opening another bug regarding autocomplete.. that confused me for a moment too before I read your comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31763 Bug 31763 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org