[Bug 39735] New: Typo in system preference call 'OPACFineNoRenewalsIncludeCredit'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 Bug ID: 39735 Summary: Typo in system preference call 'OPACFineNoRenewalsIncludeCredit' Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org Typo in system preference call 'OPACFineNoRenewalsIncludeCredit' => 'OPACFineNoRenewalsIncludeCredits' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39720 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39720 [Bug 39720] Search for system preferences call errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |fridolin.somers@biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> ---
git grep OPACFineNoRenewalsIncludeCredit | grep -v OPACFineNoRenewalsIncludeCredits C4/Circulation.pm: C4::Context->preference("OPACFineNoRenewalsIncludeCredit") opac/opac-user.pl: C4::Context->preference("OPACFineNoRenewalsIncludeCredit") t/db_dependent/Circulation.t: subtest "auto_too_much_oweing | OPACFineNoRenewalsBlockAutoRenew & OPACFineNoRenewalsIncludeCredit" => sub { t/db_dependent/Circulation.t: C4::Context->set_preference( 'OPACFineNoRenewalsIncludeCredit', '1' ); t/db_dependent/Circulation.t: 'Can auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' t/db_dependent/Circulation.t: C4::Context->set_preference( 'OPACFineNoRenewalsIncludeCredit', '0' ); t/db_dependent/Circulation.t: 'Cannot auto renew, OPACFineNoRenewals=10, OPACFineNoRenewalsIncludeCredit=1, patron has 15 debt, 5 credit' t/db_dependent/Circulation.t: C4::Context->set_preference( 'OPACFineNoRenewalsIncludeCredit', '1' );
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 181420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181420&action=edit Bug 39735: Fix typo in system preference call 'OPACFineNoRenewalsIncludeCredit' Typo in system preference call 'OPACFineNoRenewalsIncludeCredit' => 'OPACFineNoRenewalsIncludeCredits' Test plan : Run : prove t/db_dependent/Circulation.t Run test plan of Bug 23293 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181420|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 181468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181468&action=edit Bug 39735: Fix typo in system preference call 'OPACFineNoRenewalsIncludeCredit' Typo in system preference call 'OPACFineNoRenewalsIncludeCredit' => 'OPACFineNoRenewalsIncludeCredits' Test plan : Run : prove t/db_dependent/Circulation.t Run test plan of Bug 23293 Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.10 released in| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- << The devil is in the detail >> XD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39735 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org