[Bug 20111] New: Patron card creator - some strings are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Bug ID: 20111 Summary: Patron card creator - some strings are not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: victor.grousset@biblibre.com QA Contact: testopia@bugs.koha-community.org Hopefully at least 80% of the fixes and 70% of the test plan of bug 19522 will be reusable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19522 Assignee|koha-bugs@lists.koha-commun |victor.grousset@biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Component|Tools |I18N/L10N -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 --- Comment #1 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 71603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71603&action=edit Bug 20111: Coding style: Fix indentation before doing actual change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 --- Comment #2 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 71604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71604&action=edit Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Actually the Patron card creator didn't lack as much i18n as the Label creator. I was fooled by the french translations not being complete in master when they were in Pootle. ^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We should surround these strings with a HTML tag (span?) to avoid TT directives in the po files (please apply the fix to both .tt) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to Jonathan Druart from comment #4)
(please apply the fix to both .tt)
There is one .tt in this bug. Did you mean bug 19522? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 --- Comment #6 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 72409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72409&action=edit Bug 20111: i18n Patron card creator: wrap with <span> To avoid pollution and duplication in the .po files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71604|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- Created attachment 72410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72410&action=edit Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72409|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #8 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to Jonathan Druart from comment #4)
We should surround these strings with a HTML tag (span?) to avoid TT directives in the po files (please apply the fix to both .tt)
Done in this bug. Initially in a separate patch but then the two patches were squashed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72410|0 |1 is obsolete| | --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73146&action=edit Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71603|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73147&action=edit Bug 20111: Coding style: Fix indentation before doing actual change Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73146|0 |1 is obsolete| | --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 73148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73148&action=edit Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73147|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73236&action=edit Bug 20111: Coding style: Fix indentation before doing actual change Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73148|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73237&action=edit Bug 20111: i18nize units in Patron card creator Test plan: 1. install and switch to the fr_FR locale or another one and adapt the test plan accordingly 2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new 3. then you should see the "Unités" dropdown with english units 4. apply this patch 5. install the language 6. refresh the page 7. then you should see the "Unités" dropdown with french units Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org