[Bug 31905] New: Buttons lack spacing on Holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Bug ID: 31905 Summary: Buttons lack spacing on Holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 31806 The buttons on the reserves/request.pl page have no spacing between them. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 [Bug 31806] Add 'page-section' to holds page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 142315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142315&action=edit Example -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Also, ater the page section is fixed, the background for the row/line with the buttons is a light grey. See the screenshots attached to bug 31806. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142667&action=edit Bug 31905: Fix button spacing on holds page This patch makes minor modifications to the holds template in order to improve the display of the hold buttons related to existing holds. The patch also adds "display:none" to the hold cancellation fieldset so there isn't a flash of content before JavaScript hides it. To test, apply the patch and locate a record in the catalog. - Place one or more holds on the record. - View the holds for that record. - Under the "Existing holds" heading there should be a toolbar of buttons which sits above the page-section div. The buttons should be well spaced. - If you have cancellation reasons defined in authorized values, the "Cancel selected" button should correctly trigger a modal with the option to specify a cancellation reason. - The display should work well for any setting of the HoldsSplitQueue system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142667|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 142670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142670&action=edit Bug 31905: Fix button spacing on holds page This patch makes minor modifications to the holds template in order to improve the display of the hold buttons related to existing holds. The patch also adds "display:none" to the hold cancellation fieldset so there isn't a flash of content before JavaScript hides it. To test, apply the patch and locate a record in the catalog. - Place one or more holds on the record. - View the holds for that record. - Under the "Existing holds" heading there should be a toolbar of buttons which sits above the page-section div. The buttons should be well spaced. - If you have cancellation reasons defined in authorized values, the "Cancel selected" button should correctly trigger a modal with the option to specify a cancellation reason. - The display should work well for any setting of the HoldsSplitQueue system preference. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142670|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142689&action=edit Bug 31905: Fix button spacing on holds page This patch makes minor modifications to the holds template in order to improve the display of the hold buttons related to existing holds. The patch also adds "display:none" to the hold cancellation fieldset so there isn't a flash of content before JavaScript hides it. To test, apply the patch and locate a record in the catalog. - Place one or more holds on the record. - View the holds for that record. - Under the "Existing holds" heading there should be a toolbar of buttons which sits above the page-section div. The buttons should be well spaced. - If you have cancellation reasons defined in authorized values, the "Cancel selected" button should correctly trigger a modal with the option to specify a cancellation reason. - The display should work well for any setting of the HoldsSplitQueue system preference. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Summary|Buttons lack spacing on |Buttons lack spacing on |Holds |holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Bug 31905 depends on bug 31806, which changed state. Bug 31806 Summary: Add 'page-section' to holds page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31806 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31905 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org