[Bug 14905] New: search_utf8.t fails to upload a file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 Bug ID: 14905 Summary: search_utf8.t fails to upload a file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: m.de.rooy@rijksmuseum.nl QA Contact: gmcharlt@gmail.com Follow-up from error reported on bug 14321 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42903&action=edit Bug 14905: Search_utf8.t fails to upload a file Running the test fails on test 7: not ok 7 - upload succeeded The changes on bug 14321 included a temp flag for script upload-file.pl. Since this upload for stage-marc-import should be temporary, adding this flag to line 131 resolves the problem. Test plan: Run the adjusted test. NOTE: I still had some problems with this test. And will still be looking to these errors (perhaps open a new report). But this fix should at least fix the above-mentioned test. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|chris@bigballofwax.co.nz |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #1)
NOTE: I still had some problems with this test. And will still be looking to these errors (perhaps open a new report). But this fix should at least fix the above-mentioned test.
I had warnings on test 27 and test 59 too about a empty kw= missing in the base. Will address these warnings on bug 14909. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14909 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14909 [Bug 14909] Warnings from search_utf8.t when empty kw= misses in returned base -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #2)
(In reply to Marcel de Rooy from comment #1)
NOTE: I still had some problems with this test. And will still be looking to these errors (perhaps open a new report). But this fix should at least fix the above-mentioned test.
I had warnings on test 27 and test 59 too about a empty kw= missing in the base. Will address these warnings on bug 14909.
kw= should be read as idx= :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42903|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42909&action=edit Bug 14905: Search_utf8.t fails to upload a file Running the test fails on test 7: not ok 7 - upload succeeded The changes on bug 14321 included a temp flag for script upload-file.pl. Since this upload for stage-marc-import should be temporary, adding this flag to line 131 resolves the problem. Test plan: Run the adjusted test. NOTE: I still had some problems with this test. And will still be looking to these errors (perhaps open a new report). But this fix should at least fix the above-mentioned test. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Taking the liberty to pass QA on it, small patch and no QA activities at the moment... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14321 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321 [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org