http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14909 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The regex in this test looks like: opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 The result it got was: opac-search.pl?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 Note that it fails on the missing idx= -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Warnings from search_utf8.t |Warnings from search_utf8.t |when empty kw= misses in |when empty idx= misses in |returned base |returned base -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14909 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 42907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42907&action=edit Bug 14909: Warnings from search_utf8.t when empty idx= misses in base The regex in this test looks like: opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 The result it got was: opac-search.pl?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 The empty idx should not be a reason to fail the test. I changed the original regex to make the 'idx=&' part optional and added a base_unlike test to verify that the base does not include a idx=\w+ anywhere. Also corrected the typo Goog. Good! Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> All 66 tests now pass with me. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14909 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42907|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 42910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42910&action=edit Bug 14909: Warnings from search_utf8.t when empty idx= misses in base The regex in this test looks like: opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 The result it got was: opac-search.pl?q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1 The empty idx should not be a reason to fail the test. I changed the original regex to make the 'idx=&' part optional and added a base_unlike test to verify that the base does not include a idx=\w+ anywhere. Also corrected the typo Goog. Good! Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> All 66 tests now pass with me. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14909 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.