[Bug 37427] New: Searching for an empty string for clubs in an item's hold tab is not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Bug ID: 37427 Summary: Searching for an empty string for clubs in an item's hold tab is not allowed Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: samalau@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To reproduce: 1) have some patron clubs 2) find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. However, when searching for a patron with an empty string, it returns the entire list of patrons. I think it would be useful if club searching followed this same functionality. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 --- Comment #1 from Sam Lau <samalau@gmail.com> --- Created attachment 169382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169382&action=edit Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169382|0 |1 is obsolete| | --- Comment #2 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169385&action=edit Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169385|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 174945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174945&action=edit Bug 37427: Fix club search to display all clubs when search field is empty, consistent with patron search behavior To test: 1) Create multiple patron clubs 2) Find a bib 3) Click Holds, then Clubs 4) Without entering any text, press the search button 5) Note that the list of clubs is not shown. 6) Apply patch and restart_all 7) Press the search button again, the entire list of clubs should be shown. 8) Ensure original search functionality still works Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This improves searching for release notes| |patron clubs on a record's | |holds page - it now works | |similar to the patron | |search tab. You can now | |click search with no text | |in the search box, and a | |list of clubs are | |displayed. Previously, you | |had to enter the club ID or | |partial name to get a | |result. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #5 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- This is in the commit log for 24.11, though not noted here yet. Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to 24.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37427 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org