[Bug 37360] New: Add 'Protected Status' as one of the things that can be updated via Batch Patron Modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Bug ID: 37360 Summary: Add 'Protected Status' as one of the things that can be updated via Batch Patron Modification tool Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.auld@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The new 'Protected Status' characteristic is something that could usefully be included as editable via Batch Patron Modification. Please consider adding. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Chanel Wheeler <chanel.wheeler@yavapaiaz.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chanel.wheeler@yavapaiaz.go | |v --- Comment #1 from Chanel Wheeler <chanel.wheeler@yavapaiaz.gov> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jake.deery@ptfs-europe.com |ity.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 [Bug 37755] Change in Bootstrap5 has broken batch patron modification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #2 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 170932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170932&action=edit Bug 37360: Add protected as a borrower mod option This patch adds protected status as a batch borrower modification option, if the user performing the modification is a superlibrarian. TO TEST: a) login as a superlibrarian b) attempt to batch modify these k.t.d user barcodes: 1) 23529000035676 2) 23529001000463 3) 23529000050113 c) notice that there is no protected option d) APPLY PATCH e) repeat step b f) notice that protected is now an option g) set all borrowers to protected (yes) 1) notice that the status has changed, in each individual user record h) set all borrowers to unprotected (no) 1) notice that the status has changed, in each individual user record i) set the proctedted status back to yes, but also set some other random options (e.g. city to Cork) 1) notice that the city and protected status are both updated j) use the disabled checkbox next to protected 1) notice that this always sets the protected status to zero k) SIGN OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Jake Deery <jake.deery@ptfs-europe.com> --- Thanks in advance for the sign-off and QA :-) Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36085 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36085 [Bug 36085] Setting and unsetting the protected flag should be limited to superlibrarian accounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170932|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 170991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170991&action=edit Bug 37360: Add protected as a borrower mod option This patch adds protected status as a batch borrower modification option, if the user performing the modification is a superlibrarian. TO TEST: a) login as a superlibrarian b) attempt to batch modify these k.t.d user barcodes: 1) 23529000035676 2) 23529001000463 3) 23529000050113 c) notice that there is no protected option d) APPLY PATCH e) repeat step b f) notice that protected is now an option g) set all borrowers to protected (yes) 1) notice that the status has changed, in each individual user record h) set all borrowers to unprotected (no) 1) notice that the status has changed, in each individual user record i) set the proctedted status back to yes, but also set some other random options (e.g. city to Cork) 1) notice that the city and protected status are both updated j) use the disabled checkbox next to protected 1) notice that this always sets the protected status to zero k) SIGN OFF Signed-off-by: Catrina <catrina@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Catrina Berka <catrina@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |catrina@bywatersolutions.co | |m --- Comment #5 from Catrina Berka <catrina@bywatersolutions.com> --- Test plan works as described. Selecting the box to clear the value on "Protected" sets the users to "No" (not protected) - some clarifying helper text might be useful there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #6 from Jake Deery <jake.deery@ptfs-europe.com> --- Thanks for the sign-off, Catrina. I could add a tooltip, but it might also be worth considering properly documenting this? Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Just curious, why push, push, unshift for the options for the dropdown? Could you just define them all at once or push the empty option first? I think the bigger issue is that the values will not be translatable, failing for this You also change the check for empty fields from a truth check to only assigning if not empty string, then checking if defined, is there a reason for that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #8 from Jake Deery <jake.deery@ptfs-europe.com> --- Thanks for the feedback. Because this hasn't been done before, I sort of adapted what's there. I guess the solution would be to put the Yes/No text within the template? I can put together a follow-up to address this. Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #9 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 172385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172385&action=edit Bug 37360: (follow-up) added bool type to modborrowers This follow-up patch adds a bool type to modborrowers, so that the options can be translated within the template files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Jake Deery <jake.deery@ptfs-europe.com> --- All done – thanks for the FQA on this one. I think this is a much cleaner solution. Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #11 from Kristi <kkrueger@cuyahogalibrary.org> --- Looks like this one has been signed off already. Should it be marked as Signed off status? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170991|0 |1 is obsolete| | --- Comment #12 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 172977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172977&action=edit Bug 37360: Add protected as a borrower mod option This patch adds protected status as a batch borrower modification option, if the user performing the modification is a superlibrarian. TO TEST: a) login as a superlibrarian b) attempt to batch modify these k.t.d user barcodes: 1) 23529000035676 2) 23529001000463 3) 23529000050113 c) notice that there is no protected option d) APPLY PATCH e) repeat step b f) notice that protected is now an option g) set all borrowers to protected (yes) 1) notice that the status has changed, in each individual user record h) set all borrowers to unprotected (no) 1) notice that the status has changed, in each individual user record i) set the proctedted status back to yes, but also set some other random options (e.g. city to Cork) 1) notice that the city and protected status are both updated j) use the disabled checkbox next to protected 1) notice that this always sets the protected status to zero k) SIGN OFF Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172385|0 |1 is obsolete| | --- Comment #13 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 172978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172978&action=edit Bug 37360: (follow-up) added bool type to modborrowers This follow-up patch adds a bool type to modborrowers, so that the options can be translated within the template files. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172977|0 |1 is obsolete| | --- Comment #14 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 173273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173273&action=edit Bug 37360: Add protected as a borrower mod option This patch adds protected status as a batch borrower modification option, if the user performing the modification is a superlibrarian. TO TEST: a) login as a superlibrarian b) attempt to batch modify these k.t.d user barcodes: 1) 23529000035676 2) 23529001000463 3) 23529000050113 c) notice that there is no protected option d) APPLY PATCH e) repeat step b f) notice that protected is now an option g) set all borrowers to protected (yes) 1) notice that the status has changed, in each individual user record h) set all borrowers to unprotected (no) 1) notice that the status has changed, in each individual user record i) set the proctedted status back to yes, but also set some other random options (e.g. city to Cork) 1) notice that the city and protected status are both updated j) use the disabled checkbox next to protected 1) notice that this always sets the protected status to zero k) SIGN OFF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172978|0 |1 is obsolete| | --- Comment #15 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 173274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173274&action=edit Bug 37360: (follow-up) added bool type to modborrowers This follow-up patch adds a bool type to modborrowers, so that the options can be translated within the template files. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #16 from Jake Deery <jake.deery@ptfs-europe.com> --- Ah whoops, removed the SO lines... one tick -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173273|0 |1 is obsolete| | --- Comment #17 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 173275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173275&action=edit Bug 37360: Add protected as a borrower mod option This patch adds protected status as a batch borrower modification option, if the user performing the modification is a superlibrarian. TO TEST: a) login as a superlibrarian b) attempt to batch modify these k.t.d user barcodes: 1) 23529000035676 2) 23529001000463 3) 23529000050113 c) notice that there is no protected option d) APPLY PATCH e) repeat step b f) notice that protected is now an option g) set all borrowers to protected (yes) 1) notice that the status has changed, in each individual user record h) set all borrowers to unprotected (no) 1) notice that the status has changed, in each individual user record i) set the proctedted status back to yes, but also set some other random options (e.g. city to Cork) 1) notice that the city and protected status are both updated j) use the disabled checkbox next to protected 1) notice that this always sets the protected status to zero k) SIGN OFF Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173274|0 |1 is obsolete| | --- Comment #18 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 173276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173276&action=edit Bug 37360: (follow-up) added bool type to modborrowers This follow-up patch adds a bool type to modborrowers, so that the options can be translated within the template files. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #19 from Jake Deery <jake.deery@ptfs-europe.com> --- Those patches are now rebased on main :-) Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #20 from Jake Deery <jake.deery@ptfs-europe.com> --- Any chance of a QA for this one in time for 24.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Bug 37360 depends on bug 37755, which changed state. Bug 37755 Summary: Change in Bootstrap5 has broken batch patron modification https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37755 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jake Deery from comment #20)
Any chance of a QA for this one in time for 24.11?
You wont pass the bug freeze anymore now. Sorry. Note that this feels like an enh instead of a bug ? This does not look good: + my $value = $input->param($field) if $input->param($field) ne ''; + $infos->{$field} = $value if defined $value; Never declare a variable with an if statement like that. The next line you are referring to it. Our qa tools see it too: FAIL tools/modborrowers.pl FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 4) Please tidy too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173276|0 |1 is obsolete| | --- Comment #22 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 174919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174919&action=edit Bug 37360: (follow-up) added bool type to modborrowers This follow-up patch adds a bool type to modborrowers, so that the options can be translated within the template files. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #23 from Jake Deery <jake.deery@ptfs-europe.com> --- Hi Marcel, Yes, I would agree, this is an enhancement. It will need to wait now until 25.05. I have tidied the offending file and rebased for good measure :-) Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just having a question still about this change: - my $value = $input->param($field); - $infos->{$field} = $value if $value; - $infos->{$field} = "" if grep { $_ eq $field } @disabled; + my $value; + $value = $input->param($field) if $input->param($field) ne ''; + $infos->{$field} = $value if defined $value; + $infos->{$field} = "" if grep { $_ eq $field } @disabled; On first glance, nothing special happens here. Code looks more complicated than before. And the $value assignemnt may trigger a warning now if the input->param is undef. Please explain why you are doing this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #25 from Jake Deery <jake.deery@ptfs-europe.com> --- Hi Marcel, I believe it was due to triggering Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations the old way. Happy to put it back, if we think this is safe to ignore? Or is there another way? :-) Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jake Deery from comment #25)
Hi Marcel,
I believe it was due to triggering Perl::Critic::Policy::Variables::ProhibitConditionalDeclarations the old way. Happy to put it back, if we think this is safe to ignore? Or is there another way? :-)
Jake.
- my $value = $input->param($field); - $infos->{$field} = $value if $value; - $infos->{$field} = "" if grep { $_ eq $field } @disabled; I remember the conditional declaration, but the original code above does not contain that. Could we just put these lines back? Or was there any issue with empty string versus undef that you wanted to fix here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174919|0 |1 is obsolete| | --- Comment #27 from Jake Deery <jake.deery@ptfs-europe.com> --- Created attachment 175253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175253&action=edit Bug 37360: (follow-up) added bool type to modborrowers This follow-up patch adds a bool type to modborrowers, so that the options can be translated within the template files. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #28 from Jake Deery <jake.deery@ptfs-europe.com> --- Hi Marcel, I've reverted the changes to those lines, but left the perltidy in as a cleansing operation. Hope this helps! :-) Jake. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Jake Deery <jake.deery@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #173275|0 |1 is obsolete| | --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 175254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175254&action=edit Bug 37360: Add protected as a borrower mod option This patch adds protected status as a batch borrower modification option, if the user performing the modification is a superlibrarian. TO TEST: a) login as a superlibrarian b) attempt to batch modify these k.t.d user barcodes: 1) 23529000035676 2) 23529001000463 3) 23529000050113 c) notice that there is no protected option d) APPLY PATCH e) repeat step b f) notice that protected is now an option g) set all borrowers to protected (yes) 1) notice that the status has changed, in each individual user record h) set all borrowers to unprotected (no) 1) notice that the status has changed, in each individual user record i) set the proctedted status back to yes, but also set some other random options (e.g. city to Cork) 1) notice that the city and protected status are both updated j) use the disabled checkbox next to protected 1) notice that this always sets the protected status to zero k) SIGN OFF Signed-off-by: Catrina <catrina@bywatersolutions.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175253|0 |1 is obsolete| | --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 175255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175255&action=edit Bug 37360: (follow-up) added bool type to modborrowers This follow-up patch adds a bool type to modborrowers, so that the options can be translated within the template files. Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add 'Protected Status' as |Add 'protected status' as |one of the things that can |one of the things that can |be updated via Batch Patron |be updated via batch patron |Modification tool |modification -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Small thing... CanUpdateProtectPatron... Why not ProtectedPatron? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement to the release notes| |batch patron modification | |tool allows superlibrarians | |to batch update the | |protected status setting | |for patrons, instead of | |having to change each | |patron individually. The | |edit patrons form now | |includes the "Protected" | |field. (The protected | |status option for patrons | |was added in Koha 23.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #33 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- This is in the commit log for 24.11, though not noted here yet. Not backporting to 24.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 --- Comment #34 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to 24.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37360 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #35 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org