[Bug 24624] New: Phase out jquery.cookie.js: Receipt summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 Bug ID: 24624 Summary: Phase out jquery.cookie.js: Receipt summary Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 23944 In acquisitions, the receipt summary page uses cookies to remember the settings in the sidebar filter. This process should use the newer cookie library, js-cookie. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Although the plugin is included in the template (acquit/parcel.tt) it isn't used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117011&action=edit Bug 24624: Remove unused jquery.cookie.js plugin This patch removes inclusion of the jquery.cookie.js plugin from the "Receive orders" page in Acquisitions. It is unused. To test apply the patch and follow the process for receiving an order in Acquisitions: - Acquisitions -> Vendor -> Receive shipments -> Receive a new shipment - The table of pending orders should display correctly, and there should be no JavaScript errors in the browser console. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117011|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 117105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117105&action=edit Bug 24624: Remove unused jquery.cookie.js plugin This patch removes inclusion of the jquery.cookie.js plugin from the "Receive orders" page in Acquisitions. It is unused. To test apply the patch and follow the process for receiving an order in Acquisitions: - Acquisitions -> Vendor -> Receive shipments -> Receive a new shipment - The table of pending orders should display correctly, and there should be no JavaScript errors in the browser console. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes: - Everything continues to work and display as expected. - lib/jquery/plugins/jquery.cookie.min.js is no longer in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt - No JavaScript errors in the console. - lib/jquery/plugins/jquery.cookie.min.js still appears in the page source, assume that is because it appears in other source files: git grep lib/jquery/plugins/jquery.cookie.min.js koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline-mf.tt koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27750 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27750 [Bug 27750] Remove jquery.cookie.js plugin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117105|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117421&action=edit Bug 24624: Remove unused jquery.cookie.js plugin This patch removes inclusion of the jquery.cookie.js plugin from the "Receive orders" page in Acquisitions. It is unused. To test apply the patch and follow the process for receiving an order in Acquisitions: - Acquisitions -> Vendor -> Receive shipments -> Receive a new shipment - The table of pending orders should display correctly, and there should be no JavaScript errors in the browser console. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch removes the release notes| |jquery.cookie.js plugin | |from the "Receive orders" | |page in acquisitions as it | |is no longer used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24624 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org