[Bug 26960] New: Move batch item modification template JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 Bug ID: 26960 Summary: Move batch item modification template JavaScript to the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 26959 In order to conform to best practices for performance, staff client template JavaScript should be in the footer instead of the header. This patch will do so for the batch item modification template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26959 [Bug 26959] Reindent batch item modification template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 113280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113280&action=edit Bug 26960: Move batch item modification template JavaScript to the footer This patch modifies the batch item modification template so that the JavaScript is in the footer, conforming with best practices. The items form can contain <script> tags injected by cataloging plugins. These are moved from the body of the page into the footer be repeating the template loop that previously output the script tag. To test, apply the patch and test the process of submitting items for batch modification. After submitting a batch of items, test the "Edit items" form. Confirm that JavaScript-dependent interactions work correctly: - Select2-styled dropdowns - RegEx checkboxes - Datepicker - Plugins like: - dateaccessioned.pl on 952d - stocknumberam123.pl on 952i - callnumber.pl on 952o -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113280|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116266&action=edit Bug 26960: Move batch item modification template JavaScript to the footer This patch modifies the batch item modification template so that the JavaScript is in the footer, conforming with best practices. The items form can contain <script> tags injected by cataloging plugins. These are moved from the body of the page into the footer be repeating the template loop that previously output the script tag. To test, apply the patch and test the process of submitting items for batch modification. After submitting a batch of items, test the "Edit items" form. Confirm that JavaScript-dependent interactions work correctly: - Select2-styled dropdowns - RegEx checkboxes - Datepicker - Plugins like: - dateaccessioned.pl on 952d - stocknumberam123.pl on 952i - callnumber.pl on 952o -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116266|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 117285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117285&action=edit Bug 26960: Move batch item modification template JavaScript to the footer This patch modifies the batch item modification template so that the JavaScript is in the footer, conforming with best practices. The items form can contain <script> tags injected by cataloging plugins. These are moved from the body of the page into the footer be repeating the template loop that previously output the script tag. To test, apply the patch and test the process of submitting items for batch modification. After submitting a batch of items, test the "Edit items" form. Confirm that JavaScript-dependent interactions work correctly: - Select2-styled dropdowns - RegEx checkboxes - Datepicker - Plugins like: - dateaccessioned.pl on 952d - stocknumberam123.pl on 952i - callnumber.pl on 952o Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117285|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117417&action=edit Bug 26960: Move batch item modification template JavaScript to the footer This patch modifies the batch item modification template so that the JavaScript is in the footer, conforming with best practices. The items form can contain <script> tags injected by cataloging plugins. These are moved from the body of the page into the footer be repeating the template loop that previously output the script tag. To test, apply the patch and test the process of submitting items for batch modification. After submitting a batch of items, test the "Edit items" form. Confirm that JavaScript-dependent interactions work correctly: - Select2-styled dropdowns - RegEx checkboxes - Datepicker - Plugins like: - dateaccessioned.pl on 952d - stocknumberam123.pl on 952i - callnumber.pl on 952o Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This works well in my tests. There is only one small glitch: with and without the patch the pull down for the Yes/No for local holds priority is too short to fit the text. Not relevant for this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26960 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org