https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39462 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 179742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179742&action=edit Bug 39462: (bug 37870 follow-up) Default values from framework are inserted into existing record while editing Due to changes made by the commit 0472b56a671, when editing an existing bibliographic record a default value is inserted while it should not, according to ApplyFrameworkDefaults systempreference. Test plan: ========== 1. Verify that ApplyFrameworkDefaults systempreference is set to ‘when cataloguing new records only’. 2. Take any existing bibliographic record, e.g. sn:1. Open it in standard editor and identify a non used (empty) subfield, e.g. 024 $a. Note the framework (Books, Booklets, Workbooks). Close the editor (Cancel). 3. Modify the framework in question (Books, Booklets, Workbooks) by setting a default value for the chosen subfield (e.g. 024 $a). 4. Open the record in the editor again. Note that the 024 $a subfield has now an inserted default value while it should not, according to the ApplyFrameworkDefaults setting. Do not save the record, chose Cancel. 5. Apply the patch ; restart_all. 6. Repeat p. 4 -- there should be no default value inserted in the existing record now. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39462 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39462 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179742|0 |1 is obsolete| | Attachment #179743|0 |1 is obsolete| | --- Comment #3 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 179744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179744&action=edit Bug 39462: (bug 37870 follow-up) Default values from framework are inserted into existing record while editing Due to changes made by the commit 0472b56a671, when editing an existing bibliographic record a default value is inserted while it should not, according to ApplyFrameworkDefaults systempreference. Test plan: ========== 1. Verify that ApplyFrameworkDefaults systempreference is set to ‘when cataloguing new records only’. 2. Take any existing bibliographic record, e.g. sn:1. Open it in standard editor and identify a non used (empty) subfield, e.g. 024 $a. Note the framework (Books, Booklets, Workbooks). Close the editor (Cancel). 3. Modify the framework in question (Books, Booklets, Workbooks) by setting a default value for the chosen subfield (e.g. 024 $a). 4. Open the record in the editor again. Note that the 024 $a subfield has now an inserted default value while it should not, according to the ApplyFrameworkDefaults setting. Do not save the record, chose Cancel. 5. Apply the patch ; restart_all. 6. Repeat p. 4 -- there should be no default value inserted in the existing record now. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39462 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179744|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 180226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180226&action=edit Bug 39462: (bug 37870 follow-up) Default values from framework are inserted into existing record while editing Due to changes made by the commit 0472b56a671, when editing an existing bibliographic record a default value is inserted while it should not, according to ApplyFrameworkDefaults systempreference. Test plan: ========== 1. Verify that ApplyFrameworkDefaults systempreference is set to ‘when cataloguing new records only’. 2. Take any existing bibliographic record, e.g. sn:1. Open it in standard editor and identify a non used (empty) subfield, e.g. 024 $a. Note the framework (Books, Booklets, Workbooks). Close the editor (Cancel). 3. Modify the framework in question (Books, Booklets, Workbooks) by setting a default value for the chosen subfield (e.g. 024 $a). 4. Open the record in the editor again. Note that the 024 $a subfield has now an inserted default value while it should not, according to the ApplyFrameworkDefaults setting. Do not save the record, chose Cancel. 5. Apply the patch ; restart_all. 6. Repeat p. 4 -- there should be no default value inserted in the existing record now. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39462 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Status|Signed Off |Passed QA CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39462 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39462 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.