https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39095 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32341 [Bug 32341] Some OPAC tables are not displayed well in mobile mode -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39095 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 178102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178102&action=edit Bug 39095: Fix problems with article request deletion This patch fixes a number of issues with article request deletion in the OPAC: - Cancel button should work when initially hidden by DataTables' responsive behavior. - Table row hiding upon deletion should work when DataTables' responsive behavior has created a secondary row to display the hidden columns. - Tab and table caption article count should correctly update when a request is canceled. To test, apply the patch and enable ArticleRequests if necessary. If enabling ArticleRequests for the first time you may need to update your circulation rules to allow article requests on some patrons or item types. - Log in to the OPAC and place several article requests. - Go to your user summary page and open the article requests tab. - Narrow your browser window until at least the last column is hidden by DataTables. - Click the "+" button to show the hidden details, which should include the cancel button. - Click the cancel button. After confirming the deletion the original row should be hidden along with the row shown by DataTables. - The article request count in the article requests tab should now be updated to reflect the new number of requests. - The same should be true of the article requests table heading. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39095 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178102|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 178120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178120&action=edit Bug 39095: Fix problems with article request deletion This patch fixes a number of issues with article request deletion in the OPAC: - Cancel button should work when initially hidden by DataTables' responsive behavior. - Table row hiding upon deletion should work when DataTables' responsive behavior has created a secondary row to display the hidden columns. - Tab and table caption article count should correctly update when a request is canceled. To test, apply the patch and enable ArticleRequests if necessary. If enabling ArticleRequests for the first time you may need to update your circulation rules to allow article requests on some patrons or item types. - Log in to the OPAC and place several article requests. - Go to your user summary page and open the article requests tab. - Narrow your browser window until at least the last column is hidden by DataTables. - Click the "+" button to show the hidden details, which should include the cancel button. - Click the cancel button. After confirming the deletion the original row should be hidden along with the row shown by DataTables. - The article request count in the article requests tab should now be updated to reflect the new number of requests. - The same should be true of the article requests table heading. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39095 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178120|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178133&action=edit Bug 39095: Fix problems with article request deletion This patch fixes a number of issues with article request deletion in the OPAC: - Cancel button should work when initially hidden by DataTables' responsive behavior. - Table row hiding upon deletion should work when DataTables' responsive behavior has created a secondary row to display the hidden columns. - Tab and table caption article count should correctly update when a request is canceled. To test, apply the patch and enable ArticleRequests if necessary. If enabling ArticleRequests for the first time you may need to update your circulation rules to allow article requests on some patrons or item types. - Log in to the OPAC and place several article requests. - Go to your user summary page and open the article requests tab. - Narrow your browser window until at least the last column is hidden by DataTables. - Click the "+" button to show the hidden details, which should include the cancel button. - Click the cancel button. After confirming the deletion the original row should be hidden along with the row shown by DataTables. - The article request count in the article requests tab should now be updated to reflect the new number of requests. - The same should be true of the article requests table heading. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39095 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #1) Thx for this quick fix. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39095 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39095 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.06 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39095 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate, | |rel_24_05_candidate --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like this fell through the cracks... also an issue in 22.11. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39095 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Will need the merge conflicts for 24.05 to be fixed before I backport it to 22.11 Thanks :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39095 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #11 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.