[Bug 16947] New: Can not modify patron messaging preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Bug ID: 16947 Summary: Can not modify patron messaging preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It is no longer possible to modify messaging preferences for an existing patron. To verify: - Set syspref 'EnhancedMessagingPreferences' to 'Allow' - In staff client, go to a patron's detail page - Edit Patron messaging preferences (using link below table) - Save Result: Form does not save, stays open JavaScript error in intranet-tmpl/prog/js/members.js line 107 TypeError: document.form.password is undefined Note: Changing settings from OPAC works (needs EnhancedMessagingPreferencesOPAC) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 53553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53553&action=edit Bug 16947: Can not modify patron messaging preferences To verify: - Set syspref 'EnhancedMessagingPreferences' to 'Allow' - In staff client, go to a patron's detail page - Edit Patron messaging preferences (using link below table) - Save Result: Form does not save, stays open JavaScript error in intranet-tmpl/prog/js/members.js line 107 TypeError: document.form.password is undefined To test: - Apply patch - Repeat steps above - Verify that messaging preferences save as expected - Verify that other patron modifications work as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53553|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 53564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53564&action=edit Bug 16947: Can not modify patron messaging preferences To verify: - Set syspref 'EnhancedMessagingPreferences' to 'Allow' - In staff client, go to a patron's detail page - Edit Patron messaging preferences (using link below table) - Save Result: Form does not save, stays open JavaScript error in intranet-tmpl/prog/js/members.js line 107 TypeError: document.form.password is undefined To test: - Apply patch - Repeat steps above - Verify that messaging preferences save as expected - Verify that other patron modifications work as before NOTE: remember to force reload of the javascripts. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53564|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53593&action=edit Bug 16947: Can not modify patron messaging preferences To verify: - Set syspref 'EnhancedMessagingPreferences' to 'Allow' - In staff client, go to a patron's detail page - Edit Patron messaging preferences (using link below table) - Save Result: Form does not save, stays open JavaScript error in intranet-tmpl/prog/js/members.js line 107 TypeError: document.form.password is undefined To test: - Apply patch - Repeat steps above - Verify that messaging preferences save as expected - Verify that other patron modifications work as before NOTE: remember to force reload of the javascripts. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This will need to be adapted for stable versions. I have not tested on 3.22.x but looking at the code the issue certainly exists. Since the bug exists for a while, I don't think it's a critical one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org